a big one is to use a persistent cache for the planner, its just adding an atom to the env at ::pcp/plan-cache* key so the plan cache is preserved between requests

since the plan does care about the data values (just their shapes instead), the same query (even with different data) will reuse that cache

Yeah, I added that after I sent over the question and it made a radical difference.

Does the plan cache work independently of the values provided by the query’s ident? If, for example, a :user/username is provided, will the plan be cached for all possible values of :user/username?

it supposed to, but I went to check after you said it here, and I see how it isn't working that way

but I think there is a simple fix to it, can you please open an issue?

No problem, I’ll do that now. Can you imagine any side-effects of using a persistent cache for the planner? I can with the resolver cache, but it seems like the planner cache is more or less a free lunch.

https://github.com/wilkerlucio/pathom3/issues/182

thanks for the issue!

the major side effect is memory usage that will increase, but the tradeoff weights a lot more on the gains here

in case the memory usage of the plan cache becomes an issue, then you can switch the basic atom with some more sophisticated caching implementation, an atom is just a type that supports caching, but for pathom what matters is that it implements the cache protocol: https://pathom3.wsscode.com/docs/cache#the-cache-protocol

Gotcha, but with this patch the space taken up in the cache will be considerably less, I imagine.

yup

fix almost done 🙂

Excellent, thank you.

fixed on main

Thanks again. I think Pathom is, hands down, one of the best OSS libraries in the Clojure community, by the way.

humm, Im thinking my solution may have introduced a bug

let me check here

yup, bug confirmed, working on it

I was naive here, because I just changed the cache key, but in the way I did it will always use the same ident value

already have a test exposing it, now time for the fix

current main is working again, but with the ident optimization removed, have to give a bit more thinking to the solution. the issue is that I need to adapt the graph back after, to re-inject the proper ident values there

ok, it should be good now on main

As a recap, it’s all working as you’d like now?

If so, any chance you could cut a new release for Clojars?

(There are two patches I’m hoping to apply.)

yes, it's all running as expected, I plan to cut a release soon, prob today, but max tomorrow

Excellent, thank you!

ups, at least is a simple one, do you mind opening an issue please?

https://github.com/wilkerlucio/pathom3/issues/181

fixed on main