2023-02-08 matcher-combinators | Clojure Slack Archive

matcher-combinators

Phillip Mates 2023-02-08T13:55:57.308959Z

Earlier today I released 3.8.2, which resolves compatibility with browser-based CLJS test setups (https://github.com/nubank/matcher-combinators/pull/189) I also migrated from lein to deps.edn, but managed to temporarily mess up the migration, so please note that 3.8.1 on clojars is broken

Phillip Mates 2023-02-08T13:56:12.815019Z

while testing the build change I pushed 3.8.1-alpha (after releasing 3.8.2) so it shows as the latest on clojars. Is that an issue for anyone? Should I make a new empty release at 3.8.3 to restore order?

lread 2023-02-08T14:12:41.788619Z

Yeah maybe a 3.8.3 would be good. The clojars badge is also showing 3.8.1-alpha as current so that's a bit misleading.

lread 2023-02-08T14:25:11.314089Z

(I assumed clojars version sorted to show latest, but it seems to sort by publish date. TIL.)

Phillip Mates 2023-02-08T13:57:32.651209Z

Additionally what do folks think about a few tweaks to get Clojure 1.8 support? https://github.com/nubank/matcher-combinators/pull/194

dominicm 2023-02-08T14:03:28.150239Z

The main change, other than filling in a few missing predicates seems to be dropping spec. Was spec adding any value?

Phillip Mates 2023-02-08T14:04:58.566469Z

spec wasn't really doing anything other than a handful of function annotations. In theory that stuff is nice but I never got used to the spec way of describing things (I added these annotations as a trial many years ago)

Phillip Mates 2023-02-08T15:50:26.050239Z

went ahead and released the Clojure 1.8 compat change as 3.8.3 as a way of dealing with the 3.8.1-alpha version showing at the top of clojars

👍 1

lread 2023-02-08T15:59:47.416029Z

@phillipmates just happened to notice that the scm tag in the https://repo.clojars.org/nubank/matcher-combinators/3.8.3/matcher-combinators-3.8.3.pom is v3.8.3 which does not match the git tag 3.8.3. This means that tools like clojars and cljdoc that try to link back to sources on GitHub will get a 404.

Phillip Mates 2023-02-08T16:00:31.623129Z

was wondering if that mattered; I'll fix it up

👍 1

Phillip Mates 2023-02-08T16:02:22.170829Z

https://github.com/nubank/matcher-combinators/commit/4b7ce61020cf3b10b3906a1af5428e5eba1bdc0e (I guess will get resolved on next release)

lread 2023-02-08T16:03:15.962989Z

Yeah, that looks good.

borkdude 2023-02-08T16:25:47.633649Z

@phillipmates So they jumped hoops and made you able to merge and release stuff in this lib? https://clojurians.slack.com/archives/C04ABMF89D3/p1675094347689269

Phillip Mates 2023-02-08T16:26:46.813269Z

yeah 🙂

💯 1

lread 2023-02-08T16:47:28.506139Z

Yay! Thanks for all your hard work and contributions @phillipmates!

ericdallo 2023-02-08T17:41:00.420279Z

Thank you for the huge help @phillipmates!

👆 1

2023-02-08T20:31:53.797519Z

> So they jumped hoops and made you able to merge and release stuff in this lib? Some hoops are worth jumping through. Although, honestly, in this case we kinda walked right by them 🙂

Clojurians Log v2

matcher-combinators