matcher-combinators 2023-02-08

Phillip Mates13:02:57

Earlier today I released 3.8.2, which resolves compatibility with browser-based CLJS test setups (https://github.com/nubank/matcher-combinators/pull/189) I also migrated from lein to deps.edn, but managed to temporarily mess up the migration, so please note that 3.8.1 on clojars is broken

Phillip Mates13:02:12

while testing the build change I pushed 3.8.1-alpha (after releasing 3.8.2) so it shows as the latest on clojars. Is that an issue for anyone? Should I make a new empty release at 3.8.3 to restore order?

lread14:02:41

Yeah maybe a 3.8.3 would be good. The clojars badge is also showing 3.8.1-alpha as current so that's a bit misleading.

lread14:02:11

(I assumed clojars version sorted to show latest, but it seems to sort by publish date. TIL.)

Phillip Mates13:02:32

Additionally what do folks think about a few tweaks to get Clojure 1.8 support? https://github.com/nubank/matcher-combinators/pull/194

dominicm14:02:28

The main change, other than filling in a few missing predicates seems to be dropping spec. Was spec adding any value?

Phillip Mates14:02:58

spec wasn't really doing anything other than a handful of function annotations. In theory that stuff is nice but I never got used to the spec way of describing things (I added these annotations as a trial many years ago)

Phillip Mates15:02:26

went ahead and released the Clojure 1.8 compat change as 3.8.3 as a way of dealing with the 3.8.1-alpha version showing at the top of clojars

👍 2

lread15:02:47

@phillipmates just happened to notice that the scm tag in the https://repo.clojars.org/nubank/matcher-combinators/3.8.3/matcher-combinators-3.8.3.pom is v3.8.3 which does not match the git tag 3.8.3. This means that tools like clojars and cljdoc that try to link back to sources on GitHub will get a 404.

Phillip Mates16:02:31

was wondering if that mattered; I'll fix it up

👍 2

Phillip Mates16:02:22

https://github.com/nubank/matcher-combinators/commit/4b7ce61020cf3b10b3906a1af5428e5eba1bdc0e (I guess will get resolved on next release)

lread16:02:15

Yeah, that looks good.

borkdude16:02:47

@phillipmates So they jumped hoops and made you able to merge and release stuff in this lib? https://clojurians.slack.com/archives/C04ABMF89D3/p1675094347689269

Phillip Mates16:02:46

yeah 🙂

💯 2

lread16:02:28

Yay! Thanks for all your hard work and contributions @phillipmates!

ericdallo17:02:00

Thank you for the huge help @phillipmates!

👆 2

dchelimsky20:02:53

> So they jumped hoops and made you able to merge and release stuff in this lib? Some hoops are worth jumping through. Although, honestly, in this case we kinda walked right by them 🙂

2023-02-08

Channels