Fork me on GitHub
#hoplon
<
2017-11-28
>
thedavidmeister00:11:25

@rfhayashi have you used the profiler in the browser to identify what is running slow?

thedavidmeister01:11:57

@rfhayashi also, i don't think it should be too hard to upgrade if you do it in a few chunks

flyboarder01:11:03

@rfhayashi if you need help working through the upgrade process let us know!

flyboarder01:11:29

@thedavidmeister have you used Angular2 before?

thedavidmeister01:11:04

@flyboarder angular 4 i think it was

flyboarder01:11:36

I want to write an adapter for hoplon, to be able to make use of the angular goodies floating around the web, looks like a tough road tho

thedavidmeister01:11:51

from what i've seen angular is a bit of a walled garden

thedavidmeister01:11:11

it's like a monolithic framework that touches everything

thedavidmeister01:11:40

i think react plays more nicely with others

thedavidmeister01:11:07

and vue.js explicitly states compatibility with other systems as a design goal

flyboarder02:11:07

yeah vue.js looks cool too, we have some stakeholders that are pressuring for portions of our product extremely quickly so I am trying to figure out an approach on the client side that would help move more rapidly

flyboarder02:11:48

like someone literally asked if they could have a demo tomorrow

thedavidmeister02:11:32

well they just want what you have

thedavidmeister02:11:37

it's a good sign 🙂

thedavidmeister02:11:53

but hmmm, my experience with angular wasn't "rapid"

thedavidmeister02:11:22

and their native data model would probably conflict with javelin in nasty ways

flyboarder02:11:28

yeah i think ill stick with the hoplon stuff anyway, just wondering if I could pull some fancy ui stuff together

thedavidmeister02:11:42

actually the whole time i was working with angular, i was thinking about how much faster i could get what i was doing done in hoplon

flyboarder02:11:46

now if only there were better UI kits available

thedavidmeister02:11:58

what UI bits are you looking for?

thedavidmeister02:11:15

i might have some elements that i could share

flyboarder02:11:09

they are wanting us to shift focus to the webstore

thedavidmeister02:11:33

should we shift this convo to a different chat?

thedavidmeister02:11:59

maybe we can plan something, probably not for tomorrow, but soon

flyboarder02:11:23

yeah amelia said sunday she was free for a chat

thedavidmeister02:11:55

yup, she told me yesterday that she'll be working on your stuff in the next few days

flyboarder02:11:43

yeah thats fine, ill try to get more stuff up on the workspace, been working on the product pages

flyboarder18:11:38

I am anxiously awaiting the 1.9 release, builds still passing for hoplon tests 🙂

rfhayashi19:11:54

@thedavidmeister @flyboarder i managed to reproduce my problem in a small project, and upgrading hoplon does fix it. it seems like the best way forward, but as it's quite an old codebase and I'll also have to change some libs that are based on the old hoplon version, I was just wondering if you guys can think of anything that I could do to fix the problem without going through the upgrade process (sorry to insist)

flyboarder19:11:10

@rfhayashi you could try something like 6.0.0-alpha15 which might need less changes, however there were many things that were improved within the 6-alphaX builds

flyboarder19:11:03

we rolled most of them into v7 and then stripped out a bunch of things for 7.1-SNAPSHOT

rfhayashi19:11:37

both 6.0.0-alpha17 and 7.0.3 worked in the small project, probably 6.0.0-alpha15 will work as well, I was wondering if you'd happen to know which bug was that and than I'll could try to cherry-pick it to the version I'm using

flyboarder19:11:36

v7 is almost a complete rewrite, prior to that Hoplon is tied to jQuery, in v7+ it’s not

flyboarder19:11:09

I didnt work too much on the v6 builds, those were happening a few years back now

flyboarder19:11:18

so it will be hard to cherry pick anything to v6

flyboarder19:11:10

@rfhayashi in all honesty it will probably be easier to upgrade to v7.0.3

rfhayashi19:11:45

actually the fix is in v6 (it worked for me with 6.0.0-alpha17 in the small project), but we'd have to know what we need to cherry pick anyway, I'll try to work on the upgrade, thank you for your help

flyboarder19:11:43

@rfhayashi what did you change after upgrading to alpha17?

flyboarder19:11:54

To get it working?

flyboarder19:11:36

There are many changes to the tpl system itself throughout those builds, like skipping non-hoplon elements to improve performance

rfhayashi19:11:58

I just used the cond-tpl from alpha17 instead of the one I added to alpha1 (the cond-tpl code I copied from master)

flyboarder19:11:39

@rfhayashi I’m probably not the best person to speak on the tpl system, parts of that code still boggle me, @thedavidmeister might have more info

rfhayashi21:11:37

I am upgrading a lib to 6.0.0-alpha17, I have a couple of .hl files in it, after upgrading, the files are not being compiled anymore, I noticed I don't have a :source-paths entry, only a :resource-paths, but that also didn't work. the task does (comp (hoplon :lib true :pretty-print true)) (build-jar)) (removing the :lib attribute which does not exist anymore does not make any effect as well), any ideas?

flyboarder21:11:24

although it should be noted that using manifest is undesirable in most cases, as it requires the consuming project to use the boot-hoplon tasks

flyboarder21:11:46

not an issue if you are going hoplon all the way down

rfhayashi21:11:43

it worked! thanks again! yeap, that is not an issue for me

rfhayashi21:11:52

although, it hasn't actually compiled the files, so the :manifest makes the consuming project eventually compile them, is that right?

flyboarder21:11:09

yes make sure you call the hoplon task in your main project

flyboarder21:11:32

prior to compiling cljs

thedavidmeister23:11:58

@rfhayashi this is really testing my memory of hoplon, but i think some early versions of the tpls were a bit buggy

thedavidmeister23:11:32

might need to try a few different iterations of it to get the results you want