Fork me on GitHub
#fulcro
<
2020-08-16
>
nivekuil03:08:41

ok, duplicate items are not fulcro's fault.. it's a pebcak situation: turns out I never considered result order when I switched to pathom's batch resolvers, so the state was never populated correctly to begin with. That being said, I think the union routers are quite a bit snappier and will probably keep them.

nivekuil07:08:24

something that surprised me with the union routers is that each "screen" component needs an :initial-state, since it's nil unless explicitly set to {}. Would it be reasonable to default to {}? or any interest in a PR for the book to add a note to always set initial state on screens

tony.kay15:08:10

initial state could infer a to-one or to-many (could be a vector of empty maps). Defaulting the wrong way would cause other weirdness. There is no good default, and sometimes you don’t need it, which would generate bloat. I would consider a dev-time warning, but i’m not sure how to prevent false-positives there

cjmurphy15:08:27

It is possible for one/many to be known. And at the same time I find it a big help for readability of components - instead of get-query use get-one or get-many . Then can't default the wrong way.

tony.kay19:08:14

so you’re right, we could add those helpers and have them augment query metadata, which would in turn enable more dev warnings as well.

tony.kay19:08:40

get-query1 and get-query* might be better names

tony.kay19:08:01

no time on my end to add such things, but would be open to PR

Adam Helins12:08:37

I see that data targeting utilities such as appending idents, ensuring they are deduped, and so one, are all linear operations on vecs. Would it be interesting to rather imagine sorted sets sorting idents on information contained in their metadata? Reads would be slower I assume but it would allow for sublinear time for the common write operations other than appending (prepend, insert/remove from the middle, maintaining a sort order...)

tony.kay15:08:02

I think that pushes the system even further into magic-land, and people already struggle enough with normalization. Having to look at “hidden” things to figure out why something works is not something I want “more of”

tony.kay15:08:50

Realllllly long lists could certainly have optimized cases in those utils, and you can certainly add such a thing to your own app, but it doesn’t seem a fit for core.

👍 3
Adam Helins12:08:11

It would simplify quite a few common things (I find deduping to be particularly important when working with normalized data)

tbrooke15:08:46

This is a beginner question I have the rad-tutorial working fine locally but I am trying to figure out how to deploy with an uberjar - I created the jar (I think) with depster - I tried to invoke the app with java -cp fulcro-rad-tutorial.jar clojure.main fulcro-rad-tutorial/main/com/model.cljc - I am sure this is wrong but it seems the last argument contemplates a file such as core to run but I don’t see a main file. I have looked and haven’t seen easy instructions about how to deploy a Fulcro- rad App — Any suggestions?

souenzzo17:08:33

Not sure if the demo has a "main" endpoint to use as a JAR You need somehow call development/start function from the jar.

tony.kay19:08:05

that repo does not have a production entry point. See the Fulcro Template for what that would look like.

tbrooke19:08:15

It seems to me that it would make more sense to do two deployment one for the frontend and a jar for the backend

tony.kay20:08:09

to each his own

AJ Snow17:08:39

If I click a button and it disappears does that mean my queries are set up incorrectly?

AJ Snow17:08:06

yeah it looks like the contents of the whole component disappear

cjmurphy17:08:44

Props (and possibly computed) are all that determine what is rendered for a component. So debug those in the render function. Also use Fulcro Inspect to see what the props are, because all props come from app state.

cjmurphy17:08:52

You might be able to see what the mutation does to the app state using Fulcro Inspect. The queries really just determine the shape of your app state.

👍 3
souenzzo17:08:09

Hello I'm developing a "realworld" app: https://github.com/gothinkster/realworld using fulcro/pathom It's almost 100% complete. Still missing some mutations and somethings around comments. It's open for contributions/PR/issues 🙂 Any doubts DM me https://github.com/souenzzo/eql-realworld-example-app/

🚀 9
Michael W21:08:06

Using fulcro-rad, how do I set a field in a report to be a link? I have a url that I would like to be an anchor link but I'm not seeing a type other than string. Is there a way to use a function to generate the field, so I can build the link manually?

Michael W22:08:58

For future reference this can be done with a field-formatter:

ro/field-formatters {:item/url
  (fn [this v]
    (dom/a {:href (str v)} (str v)))}