Fork me on GitHub
#fulcro
<
2019-01-09
>
Twan15:01:46

@tony.kay I submitted a PR regarding an issue we got when removing translations and re-running i18n-extract and i18n-merge. https://github.com/fulcrologic/fulcro/pull/270 I'd love to get any feedback on this 🙂

đź‘Ť 2
tony.kay17:01:05

sounds fine to me. merged, and releases as 2.7.1.

j1mr10rd4n22:01:20

hi fulcro folk - happy new year! i’ve fixed a small bug in the client dom for wrapping form elements - https://github.com/j1mr10rd4n/fulcro/commit/66d95b7df9d9cce431db6b14d672daf75e5705d3 haven’t created a PR yet as it depends on a cljsjs PR being merged https://github.com/cljsjs/packages/pull/1776 because i added airbnb’s enzyme lib to help with react lifecycle testing https://airbnb.io/enzyme/ any feedback/objections to this strategy?

tony.kay23:01:40

@j1mr10rd4n I’ll need a lot more background…please open an issue and describe the problem/fix pls

tony.kay23:01:20

I’ve used enzyme…I can tolerate it as a test dep.

tony.kay19:01:52

Thanks! busy, but I’ll get to it ASAP.

tony.kay23:01:40

NOTE: The sente upgrade will break Fulcro Spec server test runner…patching now, but will require upgrading fulcro and fulcro-spec to latest versions at the same time (if you use the browser runner)