@here ^

@thomas611 I don't know what the latest state of electron is or what bundlers are supposed to do with the electron package. it appears to fail because shadow-cljs maybe bundled it incorrectly. or something in your code uses it incorrectly. do you use existsSync somwhere in your code? can't see your code

Uh, how are async fixtures supposed to work?

(use-fixtures :once
  {:before (fn [] (async done (.destroy (pouchdb "test") #(println "before" (done)))))
   :after  (fn [] (async done (.destroy (pouchdb "test") done)))})

(deftest test-put
  (async done
         (println "test") [...]

Testing hipflask-test
test
before #object[cljs.core.async.impl.channels.ManyToManyChannel]

Does someone have an example how the :target :bundle CLJS works for single node scripts? (context: https://clojurescript.org/news/2020-04-24-bundle-target)

Uhm... dumb question but what's the every? equivalent of alts! , I want to wait for all the results. Seems like it should be super obvious but I fail to find the correct search terms apparently.

I think you just loop thru all the channels and add each result to a collection of results. Each channel will block until it has a result, but since you’re waiting until you have all the results anyway, it doesn’t matter.

Or I should say, “park” not “block”.

@borkdude :bundle isn't for Node

@dnolen I'm trying to reproduce the following use case using "normal" CLJS: term-size (the newest version) is an ES Module

So in node.js this doesn't work:

require('term-size');

@pepijndevos https://github.com/clojure/core.async/blob/master/src/main/clojure/cljs/core/async.cljs#L694

so you have to write (I think) a .mjs file which says import 'term-size'

and I wondering how you would write a CLJS file which compiles to such a thing

with vanilla CLJS

@borkdude it cannot be done

lol, so it's not possible to write a script using normal CLJS where you use the newest term-size ?

you're asking multiple different things 🙂

:bundle target gets you out of the problem completely - if you're targeting the web

ok, we can ignore that one, I'm not targeting the web here

because someone else is going to solve that problem for you

prior to :bundle everything was still always possible

you just had to write some trivial JS to bridge this stuff by hand

@borkdude something else to consider is that :bundle isn't magic

all we do is look at node_modules and we generate the required JS for you

that's why I looked into it: I didn't expect it to be only for browsers

only really tested for browsers because that's by and large the primary use case

but your problem is different anyway

JS bundlers solve this annoying problem for you

you can always use require

@borkdude maybe worth playing around w/ this https://www.npmjs.com/package/esm

@dnolen I'm already using dynamic import in nbb, and the require is looking like ["term-size$default :as term-size]. I just want to know how this is normally done in CLJS to be compatible.

(aside from the unnecessary string, I know)

so any example that reproduces how to load (the newest) term-size in a CLJS node script is something I would look at

even with shadow

@borkdude so you're asking for more clarification - sorry I though this was a new question

well, the question is just: how does one do this normally in everyday CLJS + nodeJS

an example would be helpful

"everyday" changes "everyday" clearly

in the old days your question didn't even exist

but there's a tipping point now with .mjs but as far as I can tell the end result is the same as it is for :bundle

dynamic imports can't be known so you must go through $default

since nbb is still young and I want to be as compatible as possible with CLJS, I can still make changes: this is why I want to know if there's any precedence here

we refuse to do anything other than explain how it works in JS

w/ the caveat that we don't support ES6 import in CLJS and we aren't going to because of all the problems

it's worth pointing that it's not novel that we're going against the flow here

we don't even really use Node.js require system at all for ClojureScript itself

we break all the Node.js "rules"

and load everything globally

it's my opinion that trying any attempt fit into the Node.js / JS style or reconcile these problems is ill-considered

oh I'm not fighting that opinion. but it seems I've got nothing to look at in terms of existing scripts that use ES Modules then. The JS churn just leaks through and there's nothing to do about it in terms of trying to be compatible with anything I guess?

the thing I don't believe in is papering over it

yeah, I'm not trying to do that either

every time I read something like this - https://gils-blog.tayar.org/posts/using-jsm-esm-in-nodejs-a-practical-guide-part-1

it's hard for my eyes not to glaze over

but suppose :bundle worked for node scripts, how would the :require for term-size look like

similar to ["term-size$default :as term-size] ?

yes, I said that before and above - but probably not obvious 🙂

thanks :)

the whole point of $ that people missed IMO

is doesn't have anything to do with ESM at all

At least I've done my best to not invent something new, that's what I wanted to make sure

it's strictly more useful and it covers this super annoying case

so stop trying to make something new

$ lets you use any object as a namespace

and after that all of our ns require sugar applies

instead of this JS BS 🙂

alrighty

I've always wondered what all this module stuff was about: just use maps right

it's not more difficult than that probably

on our work project $ is used for importing $default but also RN Native Modules

so clearly we have a thing w/o all these pointless differentiations for what might appear like different situations

we're not quite there yet

but the last thing was globals

the reason that (require [window$console ...]) doesn't work yet is because the symbol has to be resolveable as a namespace

so that needs more thought

but the end goal is one way to do everything of interest

I noticed that some libs even have two nested defaults... https://github.com/huygn/nbb-scripts/blob/e96cd2af1f7c13edf85a7f71084b713f6e582535/github.cljs#L5

@borkdude that does seem weird to me - you should probably at least try some web compatible case with :bundle

import * as is from 'ink-spinner'

console.log(Object.keys(is.default));
// prints default

(this is executed from foo.mjs with npm install ink-spinner)

is.default.default is the actual thing you want to use from that lib`, the Spinner thing

if you do this:

import Spinner from 'ink-spinner'

console.log(Spinner);

{ default: [Function: Spinner] }

note that this happens specifically for this lib (and some others), for most libs there is no such nesting

perhaps this has to do with TS or so?

hrm dunno, but if it's like that, probably not our problem

exactly, I've just implemented $ similar to how CLJS does it: just look up the thing from the module (and any other properties like $default and $foo.bar)

I get an infinite re-render loop when i update the state in a child component. How do i fix this? Here is my app structure:

(defonce app-state (r/atom {:geolocation nil
                            :input {"age" 25
                                    "net-worth" 200000
                                    "monthly-income" 6500
                                    "monthly-expenses" 2500
                                    "investment-return" 8
                                    "investment-tax" 0
                                    "withdrawal-rate" 4}
                            :modal {:active? false}}))


(defn child [app-state]
  (let [input (:input @app-state)
        cashflows (:cashflows @app-state)
        monthly-expenses (get input "monthly-expenses")
        geolocation (:geolocation @app-state)
        withdrawal-rate (/ (get input "withdrawal-rate") 100)
        age (.parseInt js/Number (get input "age"))
        cities-table-data (map #(city-table-data % geolocation cashflows withdrawal-rate) cities)
        cheapest-city (first (sort (fn [city1 city2] (< (:fire-number city1) (:fire-number city2))) cities-table-data))]
    (swap! app-state assoc-in [:a :path] cheapest-city) ;; This swap causes infinite re-renders
    [:div "nothing"]))


(defn app []
    [child app-state])

@simon.el.nahas Probably don't use app-state as an argument

since both arguments and r/atoms trigger re-renders

Or rather, don't use swap! in the view function.

yes, but sometimes that's what you want, e.g. in click handlers etc

that's kind of how reagent is expected to work

That would be a handler, not the view function itself.

true

removing app-state the prop still gives the same error

Just move the chepest-city computation to the level where you already have the required data.

Don't shift it to some component.

yeah, because your view triggers the re-render every time it's rendering

I'm not sure i understand. This doesn't fix it:

(defn cheapest-city [cities-table-data]
  (first (sort (fn [city1 city2] (< (:fire-number city1) (:fire-number city2))) cities-table-data)))

(defn child []
  (let [input (:input @app-state)
        cashflows (:cashflows @app-state)
        monthly-expenses (get input "monthly-expenses")
        geolocation (:geolocation @app-state)
        withdrawal-rate (/ (get input "withdrawal-rate") 100)
        age (.parseInt js/Number (get input "age"))
        cities-table-data (map #(city-table-data % geolocation cashflows withdrawal-rate) cities)
        cheapest-city (cheapest-city cities-table-data)]
    (swap! app-state assoc-in [:a :path] cheapest-city)
    [:div "nothing"]))

This component is the one where it generate the needed data using city-table-data

it seems you want to have some derived data from your state

but why do you want to put that back into your state?

since i need to access it from another component far from itself

perhaps calculate it before you store it in the state and then update the state with that atomically

or use something like re-frame where you can use subscriptions to derive state from the app state

Y'all got any more of those go gotchas? I'm getting Uncaught TypeError: p.then is not a function when using <p! but when I print the promise at the same spot it's definitely a promise. Actually, I commented out all the <p! and it's still doing it! WTF?

Uncaught TypeError: p.then is not a function
    cljs$core$async$interop$p__GT_c interop.cljs:19
    switch__29745__auto__ main.js line 486 > eval line 775 > eval:10
 

1. i'm not sure i understand the first approach you suggest. 2. I'm also considering re-frame, for my next refactor. But right now I just need to get the cheapest city.

@simon.el.nahas 1) Instead of storing state and then deriving data + storing that in the state you could do that in one go right?

Just make one update function through which you update the state

which also calculates the cheapest city

or just calculate it over and over if it's not that expensive

so I would have another function like this:

(defn state-updater [old-state]
  ;...
  new-state)

and when would I call it?

keep in mind the cities-table-data is needed in a child of the child

(defn child []
  (let [input (:input @app-state)
        cashflows (:cashflows @app-state)
        monthly-expenses (get input "monthly-expenses")
        geolocation (:geolocation @app-state)
        withdrawal-rate (/ (get input "withdrawal-rate") 100)
        age (.parseInt js/Number (get input "age"))
        cities-table-data (map #(city-table-data % geolocation cashflows withdrawal-rate) cities)
        cheapest-city (cheapest-city cities-table-data)]
    (swap! app-state assoc-in [:top-city] cheapest-city)
    [:div "a table using " cities-table-data]))

@borkdude

@simon.el.nahas My idea was to calculate the cheapest city in state-updater so you could just use (:top-city @app-state) directly in your component without any calculations

Where would i call the state updater?

@borkdude

any time you update the state

i see you are thinking something similar to redux/re-frame...

But then the state updater would take an event also right?

yeah, re-frame is a little bit different in that the derived state is not in the app db

but re-frame or similar is optimal for this kind of use case

In this case what would the state-updater do? @borkdude

sorry, meeting now

Okay thank you for your time

Is there like an into that deletes keys with nil values? If not, what would be a reasonable way to write it? I guess just a copy of into with something other than conj

I'v just released my new library, which is an atom (or ratom!) backed by PouchDB. It's an atom that syncs, hopefully great for writing offline-first collaborative apps in Reagent, Rum, or other reactive libraries. Feedback appreciated. Now, on to actually refactoring my app to use it. https://github.com/NyanCAD/hipflask

Hello everyone, I have a question, I'm planning to build a new SaaS in September and I'd like it to be in ClojureScript. I just started JavaScript this year and don't really feel comfortable with it I'd really be better with ClojureScript. The fact is I bought a SaaS boilerplate in JavaScript to speed up everything, I have 2 options to use ClojureScript in addition to this boilerplate 1. Translate the full boilerplate (3000 lines) in ClojureScript 2. If there is way, extends the JS boiletplate with ClojureScript (is that even possible?) 3. Third option would be to begin with a ClojureScript SaaS boilerplate but does that even exist? I'm thinking of executing 1 ASAP, to me it'd take the full month to translate the boilerplate in ClojureScript but I think the time investment is worth it. Would you have an idea on how I could be faster? On the short term it'd make more senses to just use JavaScript with this boiletplate but on the long term I think I'd be faster using ClojureScript that's why it's so important to me to begin with ClojureScript. I'm open to any ideas or recommandations you could have, thanks by advance ! Bryce Tichit

Hey friends, having another interesting problem with a JS library import using shadow-cljs.. a lib called "timeago.js". I've imported it:

(:require ["timeago.js" :refer [format]]) 

import { format } from 'timeago.js';

@tichit.bryce both 1) & 2) are possible - 2) seems faster since you can convert as you go

caveats would mostly about whether there will be a lot of marshalling between the two

Could you send me some documentation that would talk about possibility number 2? Do you mean that I could write my CLJS code, compile it into javascript and from javascript use the compiled code? Thanks a lot for the answer !

I think I will decide between both options by the end of this week

I understand the marshalling problem but don't know how big it would be

@dnolen (and @thheller): I was able to require term-size and some other ES module using shadow's :esm build type and it yields the same style of "requires" as nbb, so I'm even more confident now that I'm doing the right thing. https://gist.github.com/borkdude/7e548f06fbefeb210f3fcf14eef019e0

FWIW I didn't get this working using vanilla CLJS. Still interested in a similar setup using the vanilla tooling.