I'd rather not pass at all through map entries when possible and process maps with reduce-kv

I think the root cause should be solved which is clojure.walk. Then pick the most optimized solution built on that for keywordize-keys

Assuming the bug in clojure.walk is fixed, what is the most optimized option for keywordize-keys?

@UK0810AQ2 reduce-kv is not recusive

Neither is f in keywordize-keys. You can call it in a recursive fashion or recur from inside it

nor is the function passed to postwalk

It is my understanding that the most optimized option for the map? branch will be reduce-kv, more than into + xf. For anything faster than that you'll have to reimplement postwalk

If you have a guarantee the input is maps all the way down, you can forgo into completely in favor of reduce with recursive calls

> what is the most optimized option for keywordize-keys? benchmark

Assuming the input is only nested maps:

(defn foo
  [m]
  (reduce-kv
   (fn [m k v]
     (assoc m (if (string? k) (keyword k) k) (if (map? v) (foo v) v)))
   {}
   m))

(def m {"a" {"b" 1} "c" 2})

(cc/quick-bench
 (keywordize-keys m))
;; Execution time mean : 4.788510 µs

(cc/quick-bench
 (foo m))
;; Execution time mean : 332.201889 ns

For larger maps I'd reduce over transient maps

@borkdude beside performance, what code is more elegant/idiomatic ?

@U013AK7J8MA what do you mean by "I'm trying to install the twttr dependency"? How do you do that?

Also looking at https://github.com/reagent-project/reagent-template/blob/master/resources/leiningen/new/reagent/project.clj it seems there's no such depedency in the standard reagent template. Did you add it manually to your project.clj?

If you do lein install in your root project folder then the question is why would you need that....

@U013AK7J8MA I don’t see a mute-twitter.middleware namespace in your project. I think the message is unrelated to the dependency you’re trying to introduce.

@U0DTSCAUU it's in env - different for dev and prod: https://github.com/ealmz/mute-twitter/blob/master/env/prod/clj/mute_twitter/middleware.clj

Ah, I see. Carry on.

Hi Jumar, the dependency is [twttr "3.2.3"] and installed it under dependencies in project.clj

I'm not sure what the error message is trying to tell me since I haven't modified any code relating to the error message

I’d try it with an empty project skeleton first with no modifications. But better question is: why do you try to run lein install in the first place?

How do I install the twttr dependency?

This is how I've done it in the past

Hi, the author @U050CBXUZ (or one of the two) replied to a comment in Reddit a few days ago saying that the release might take a couple of more months (https://www.reddit.com/r/Clojure/comments/gwc1hf/borrow_copy_of_web_development_with_clojure_third/fsuznhj?utm_source=share&utm_medium=web2x)

Thanks for the info!

yeah, unfortunately fell a bit behind on the book with all the craziness 🙂

Can you give some more context? Is this a public demo project?

@U012V3C1TPF an example for you - https://github.com/luminus-framework/luminus-template/blob/master/resources/leiningen/new/luminus/core/env/dev/clj/user.clj#L36

@U0ETXRFEW, It's a private project and I'm using luminus framework. In the queries.sql all the queries are there, but when I do some modification in the file though I reload the db.core file it isn't reflected. So, I have to reopen the REPL for it. That's the main issue.

@U015E25EW80, I didn't understand perfectly, means what should I have to do?

@U012V3C1TPF Please don't cross-post the same question to both #clojure and #beginners

Sorry for that @U04V70XH6.

(into [] (comp (map :a) (mapcat #(partition-by #{1 2} %))) [{:a [1 2]} {:a [3 4]} {:a [5 6 1]}])

Following the reduce rational

(reduce
 (fn [acc v] (into acc (partition-by #{1 2} (:a v))))
 []
 [{:a [1 2]} {:a [3 4]} {:a [5 6 1]} ])

(let [as (mapcat :a coll)]
  (vec (partition-by #{1 2} as)))

@U3JH98J4R This version would put (3 4 5 6) in the same collection

ah, yeah you are right

which may be ok

I have 2 different source seqs though. fn-1 applied on seq-1 and fn-2 applied on seq-2

Yes

The vector at the front gets mapped over pairing elements up

Then juxt applies the fns to each element in the pair

Then fn-3 gets the whole pair (which is why it may need a partial apply)

Sorry, I do not follow. Would you be able to show via example?

(sequence (map vector)
          (sequence (map keyword) ["a" "b" "c"])
          (sequence (map inc) [1 2 3]))

On my phone, it would be something like (sequence (map (comp ...)) s1 s2)

Ok, thanks. Will play around with that idea