clojure-dev

2022-09-08T18:59:08.907159Z

Hey @alexmiller, I'm curious about your approach (and the clojure core team in general) to deciding which bugs to fix or even what counts as a bug. For example, I ran into the issue detailed in https://clojure.atlassian.net/browse/CLJ-2640 - "ex-info should be tolerant of nil data param" where an argument with map destructuring is nil and is passed to ex-info . I handled it as described in the ticket (`(ex-info "message" (or m {}))`) but it felt like a place where ex-info could just "do the right thing". What led you to the decision to not merge the patch? Or request an alternative version of the patch that makes the change in a new way.

Alex Miller (Clojure team) 2022-09-08T19:16:47.975859Z

just hasn't gone through the process yet

2022-09-08T19:19:13.230559Z

My apologies, I don't mean to ask directly about that one necessarily, I'm purely curious about your process. Hoping to better understand it as I recently added a patch for clojure.test and don't have a good frame of reference for how things work

2022-09-08T19:26:17.686029Z

If it's helpful, I'll pop this in the chat in case it's helpful: https://clojure.org/dev/workflow

Alex Miller (Clojure team) 2022-09-08T19:27:27.506779Z

that's the overall process but of course there are vastly more things to look at than we will actually have time to look at, so I assume your question is how do we pick

Alex Miller (Clojure team) 2022-09-08T19:28:51.819089Z

Fogus and I build target lists to go through with Rich - those are a combination of things highly voted on ask clojure, things of high priority (based on other time swept sweeping through big issue lists and prioritizing), and generally things people regularly ask about

👍 1
Alex Miller (Clojure team) 2022-09-08T19:29:25.091989Z

we've built some lists for 1.12, Rich hasn't looked at any of it yet

seancorfield 2022-09-08T19:43:31.613959Z

On the subject of 1.12, I still have regular reminders popping up about that stability issue I reported with the alpha but haven't yet had the space to put a version of the problematic app in production with the alpha in order to get thread and heap dumps. I will get to it. Maybe next week.

Alex Miller (Clojure team) 2022-09-08T20:47:52.649859Z

I did find one bad bug in the alpha1 code https://clojure.atlassian.net/browse/CLJ-2718

Alex Miller (Clojure team) 2022-09-08T20:48:35.699609Z

can turn a finite repeat into an infinite repeat, no idea if you happened to hit that

seancorfield 2022-09-08T21:22:36.159469Z

I wouldn't have expected that to be the cause but I guess it is possible. Strange that it affects only one app, as far as we could tell, although we do have a (drop 10 countries) in that app where countries is a lazy seq that could have less than 10 elements in some situations.

seancorfield 2022-09-08T21:25:02.115079Z

We also have a (drop n segments) call where n varies from 1 to (inc (count segments)) -- but none of those involve repeat (or can this bug surface with other drop calls?

Alex Miller (Clojure team) 2022-09-08T21:26:02.202429Z

it's specific to repeat

seancorfield 2022-09-08T21:26:25.009499Z

OK, then it wouldn't affect that app.

Alex Miller (Clojure team) 2022-09-08T21:26:49.424849Z

yeah, seemed unlikely

2022-09-08T19:57:24.131979Z

I didn't realize every single patch still had to get explicit approval from Rich, that's interesting. Cool, thanks for the explanation