clojure-dev

quoll 2022-02-05T01:13:46.520679Z

Another parse-double question.

quoll 2022-02-05T01:15:06.796119Z

In clojure.test-clojure.parse/test-parse-double I think that this line should be parse-double and not parse-long. It passes, because the strings are invalid, and therefore return nil https://github.com/clojure/clojure/blob/84811650bb33846c7212f391468f9661819b906b/test/clojure/test_clojure/parse.clj#L58

quoll 2022-02-05T01:20:19.913599Z

I believe that these tests are invalid, since they’re expecting nil to be returned when the number is out of range. Instead, the number returned is: • Infinity for very large values • Double/MIN_VALUE for small values that are close to Double/MIN_VALUE • 0 for values that are less than half the size of Double/MIN_VALUE

quoll 2022-02-05T01:22:27.680889Z

oh…. and I just realized. This number is not past min double https://github.com/clojure/clojure/blob/84811650bb33846c7212f391468f9661819b906b/test/clojure/test_clojure/parse.clj#L60

quoll 2022-02-05T01:35:59.584719Z

Sorry for all the noise. I wrote when I first realized something was wrong, and I wrote more as I figured out more. (Sorry, I should have worked it all out first)

devn 2022-02-09T04:35:59.632169Z

no need for apologies Paula, that's just how it goes. I like noise, actually.