sci

baibhavbista 2022-02-05T14:29:23.187779Z

hey folks, previously (0.2.1) when passing cljs values to js functions from sci, they would automatically be converted to js objects. This does not seem to be the case now (0.2.8). I'm curious if this change was intentional (maybe for perf benefits?) or a regression.

baibhavbista 2022-02-05T14:30:00.416109Z

I only noticed this because some scripts which seemed to be taking advantage of this in sci broke 😅

borkdude 2022-02-05T14:30:06.877659Z

@baibhavbista It was actually a bug that it converted those JS values, that shouldn't have happened and was now fixed

baibhavbista 2022-02-05T14:31:07.830569Z

Thanks for the super quick response @borkdude You're the best 😁

❤️ 1
baibhavbista 2022-02-05T14:31:24.658029Z

as an aside, in which version was that fix introduced?

baibhavbista 2022-02-05T14:32:06.227809Z

nvm found it

borkdude 2022-02-05T14:32:13.715439Z

It seems it was 0.2.7 https://github.com/babashka/sci/blob/master/CHANGELOG.md#v027

baibhavbista 2022-02-05T14:32:20.493019Z

yeah, thenks 😄

borkdude 2022-02-05T14:32:57.249319Z

There were a lot of improvements with JS interop in 0.2.7-0.2.8

🤩 1
borkdude 2022-02-05T14:33:14.713499Z

If I may ask, what are you using SCI for?

baibhavbista 2022-02-05T14:34:39.536049Z

oh, I work at RoamResearch and we use sci for running user's js and cljs scripts 😁

baibhavbista 2022-02-05T14:34:53.671629Z

I believe you've talked with Conor White Sullivan, our CEO?

borkdude 2022-02-05T14:35:30.812329Z

Cool! Yeah, we've spoken on Twitter

❤️ 1
borkdude 2022-02-05T14:36:36.596509Z

If you want, you can post something here: https://github.com/babashka/sci/discussions/662

👍 1
borkdude 2022-02-05T14:36:58.078279Z

Say hi to Conor from me.

❤️ 1
borkdude 2022-02-05T14:51:48.628649Z

If you're using SCI at your company or on a side project, you're welcome to share here: https://github.com/babashka/sci/discussions/662