This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-02-05
Channels
- # announcements (1)
- # aws (6)
- # babashka (8)
- # beginners (22)
- # cider (12)
- # clj-kondo (1)
- # cljdoc (15)
- # clojure (109)
- # clojure-dev (6)
- # clojure-europe (40)
- # clojure-losangeles (5)
- # clojure-uk (1)
- # clojurescript (28)
- # data-oriented-programming (3)
- # datahike (9)
- # datalevin (9)
- # holy-lambda (2)
- # juxt (5)
- # lsp (4)
- # malli (2)
- # meander (1)
- # missionary (5)
- # nextjournal (3)
- # off-topic (17)
- # reagent (1)
- # reitit (8)
- # releases (1)
- # sci (16)
- # shadow-cljs (7)
- # sql (9)
- # tools-deps (9)
- # transit (1)
In clojure.test-clojure.parse/test-parse-double
I think that this line should be parse-double
and not parse-long
. It passes, because the strings are invalid, and therefore return nil
https://github.com/clojure/clojure/blob/84811650bb33846c7212f391468f9661819b906b/test/clojure/test_clojure/parse.clj#L58
I believe that these tests are invalid, since they’re expecting nil
to be returned when the number is out of range. Instead, the number returned is:
• Infinity
for very large values
• Double/MIN_VALUE
for small values that are close to Double/MIN_VALUE
• 0 for values that are less than half the size of Double/MIN_VALUE
oh…. and I just realized. This number is not past min double https://github.com/clojure/clojure/blob/84811650bb33846c7212f391468f9661819b906b/test/clojure/test_clojure/parse.clj#L60