@braden.shepherdson take a look at the contents of the closure-library.jar file. that is basically what it needs to find on the classpath

@alexmiller would you mind if I added the cognitect test runner to tools.namespace while doing TNS-51?

{:deps {org.clojure/tools.namespace {:local/root "." :deps/manifest :pom}}
 :aliases
 {:test
  {:extra-paths ["src/test/clojure"]
   :extra-deps {io.github.cognitect-labs/test-runner
                {:git/tag "v0.5.0" :git/sha "b3fd0d2"}}
   :exec-fn cognitect.test-runner.api/test
   :exec-args {:dirs ["src/test/clojure"]}}}}

Nope, but we won't use that for any of the ci or release - that's all Maven

that's fine, I just prefer to run the tests like this :)

Sure

if I add a deps.edn like the above and someone uses tools.namespace via a gitlib, will it resolve via the pom via deps.edn?

I think that should be the desired behavior (not override the pom with the deps.edn)

deps is preferred right now over pom

ok, uploaded a patch: https://clojure.atlassian.net/browse/TNS-51

@alexmiller what I mean is: I redirect to the pom in the deps.edn:

:deps {org.clojure/tools.namespace {:local/root "." :deps/manifest :pom}}

it works and the pom.xml is still the only source of truth regarding deps

oh sorry, I didn't see all the parts of that question on my phone, seems cool

I'll submit the patch for this one: https://clojure.atlassian.net/browse/TNS-57 when TNS-51 has been processed, to not have to rebase patches.

Ffn JIRA, while I'm typing a name and selecting a person, it changes the UI from under me, so the wrong person gets assigned (and probably received a notification).

feel free to file a jira with jira :)

I probably won't look at the tns stuff until monday earliest

I noticed that ClojureScript depends on a fairly old version of clojure data json (0.2.6). Clojure.data.json has gotten significant performance improvements over the last few months, perhaps consider upgrading.

fwiw on the unshaded vs shaded compiler. The shaded compiler contains a copy of guava that's been prefixed with the google closure namespaces, so it doesn't conflict with the real copy of guava on your classpath. That could be an interim fix. I've found the problem in the build.bazel and let them know, but I'm not sure if there's any interest in actually fixing this from their end at this point.