Fork me on GitHub
#cljs-dev
<
2021-12-01
>
dnolen14:12:59

@orestis hrm I think you have a bad GCL dep declared (for the goog require problem)

dnolen14:12:23

I went back over the changes I actually handled this case, locally I could not reproduce once I just used the latest GCL

orestis15:12:27

@dnolen hm I literally used an Sdeps invocation on an otherwise empty project

dnolen15:12:54

@orestis oh ha sorry - that is the problem - I didn't bump the GCL dep, fixing

dnolen15:12:11

locally you can bump it and it will work

orestis15:12:33

Super 🙂

orestis15:12:59

We're actually removing the naked goog require but good to fix in any case

dnolen15:12:10

@orestis @borkdude cutting a release for these 2 regressions now - thanks for the reports

❤️ 2
dnolen15:12:29

@orestis I think should amend my early statement since base.js was definitely in there as providing goog - so I guess goog.require("goog"); is meant to work in JS - so it should probably work in ClojureScript

dnolen15:12:53

I got confused because I did fix this because some code relies on it - but I was using deps.edn / and CI uses that

dnolen15:12:07

but I hadn't updated the POM

borkdude15:12:35

there's tools build now which can generate that pom for you from deps.edn

dnolen15:12:36

and the code for allowing this is not in the compiler - but rather GCL itself

dnolen15:12:35

@borkdude yeah it's annoying - ClojureScript is so old that we just a bunch of methods lying around

dnolen15:12:49

I'm somewhat loathe to change stuff here because different contributors having different methods

dnolen15:12:14

in ClojureScript repo, we have bash + classpath, deps.edn, project.clj and pom for releases

borkdude15:12:40

doesn't sound unfamiliar to some of my projects ;)

Braden Shepherdson20:12:11

I'm endeavouring to get CLJS compiling under Bazel. it's dying with

{:type clojure.lang.ExceptionInfo,
    :message
    "No such namespace: goog.math.Long, could not locate goog/math/Long.cljs, goog/math/Long.cljc, or JavaScript source providing \"goog.math.Long\" in file /build/work/49eec4856eb3c9b898a9f1d1f20335698d75/project/bazel-out/host/bin/third_party/clojure/org_clojure_clojurescript/compiler.runfiles/project/third_party/clojure/org_clojure_clojurescript/src/main/cljs/core.cljs",
    :data {:tag :cljs/analysis-error},
    :at [cljs.analyzer$error invokeStatic "analyzer.cljc" 719]}]
which suggests it's not finding the GCL JS files properly. where does it expect to find the GCL namespaces like goog.math.Long (provided in math/long.js)?

arohner12:12:47

it has in-progress support for CLJS. I have a good chunk of uncommitted work I need to push

Braden Shepherdson20:12:59

my working guess is that it should be on the classpath as goog/math/long.js