@dnolen If you end up doing ClojureScript work today, I'd vote for this ticket. It is a regression currently only on master: https://dev.clojure.org/jira/browse/CLJS-2449

Yep gonna go through tickets probably cut a release unless there’s some reason not to?

That's the only regression on master I'm aware of.

Is there a file where I can see which externs were inferred?

Nvm, found it at the obvious place 🙂

what other issues should I look at?

I’m going to do :stable-names now since that’s an easy one and might mess around a bit with caching of JAR deps

@mfikes I’m fine with the ns special case approach on CLJS-2413

@juhoteperi what is the state of this one https://dev.clojure.org/jira/browse/CLJS-2389?

@dnolen Works for November Closure but not December, advanced build prints some warnings, not sure if those affect output

ok I’m going to leave it be - I feel like there’s too much churn around the modules stuff in Closure Compiler right now?

@kommen ping

https://dev.clojure.org/jira/browse/CLJS-2216, this an old one but it’s nice and just needs a rebase

3-way merge didn’t work, I can manually do this - but happy to give you credit via a new patch

@dnolen pong

I bumped your JIRA privs too

you think it’s a good idea to have :webworker it as a separate :target?

I’m happy to rebase it for you

I don’t see why not, people have been asking for this for years

alright

also re the :closure-defines build-affecting-options thing from a few days ago: for some reason I didn’t look close enough and the :output-to file was actually updated and I though it was not, so all good there now

ok good

@mfikes https://dev.clojure.org/jira/browse/CLJS-2197 is interesting

another case of direct invokes causing issues

Interesting

@dnolen If you end up releasing, I've written a draft of some copy that could go with the core.specs.alpha feature: https://gist.github.com/mfikes/a48780bec910e8c53a5b32e49f0d12f0

nice

I’m thinking we want a hook like warning handler for spec errors

so that people can interpret them however they see fit

If you end up having separate guides for the release, we could put that into one, or if you just make overall release notes, feel free to incorporate that copy.

Yeah, a hook might be nice. I wonder if Clojure has figured out a "standard" way to do this that ClojureScript can follow.

We have the explain-out dyn var

Ahh cool. So does ClojureScript.

cljs.user=> (source cljs.spec.alpha/*explain-out*)
(def ^:dynamic *explain-out* explain-printer)

but we probably want to have a compiler option to let people bind that through tooling

:explain-out

Thanks @alexmiller for the core.specs.alpha lib. I know it's your job and all, but... you know 🙂

sometimes porting Clojure code to ClojureScript is really mind bending - think I sorted this arity issue out

I get a downstream warning when building Planck; looking to see if it is innocuous

WARNING: Use of undeclared Var cljs.core$macros/m at line 756 out/cljs/core.cljc

My initial hunch is that this should be core/fn

@mfikes thanks

It is trivial to patch that... harder to test it

pushed that fix

Cool

Confirmed. Where previously

$ script/test-self-parity
WARNING: Use of undeclared Var cljs.core$macros/m at line 756 /Users/mfikes/Projects/clojurescript/src/main/clojure/cljs/core.cljc
WARNING: Use of undeclared Var cljs.core$macros/m at line 757 /Users/mfikes/Projects/clojurescript/src/main/clojure/cljs/core.cljc
WARNING: Use of undeclared Var cljs.core$macros/m at line 758 /Users/mfikes/Projects/clojurescript/src/main/clojure/cljs/core.cljc
Testing with Node

$ script/test-self-parity
Testing with Node

k good

@dnolen Draft of some copy for the iterate, repeat, cycle change: https://gist.github.com/mfikes/f775e56c2566e8ac6c7f159badb2c95d

@mfikes cool if you want to put these together into a PR for the site that would be awesome

Will do

@dnolen ^ https://github.com/clojure/clojurescript-site/pull/156

@dnolen I'm going to be AFK for the next several hours. If needed, feel free to pull this PR and post-edit.

k thanks

@juhoteperi this looks fine to me but the patch has at typo - path isn’t there

@dnolen Fixed now

thanks

@dnolen Regarding the compiler perf ticket: It's a modest speedup of ~20% only for recompiles. It's slightly noticable in figwheel when I re-compile "master namespaces" which a lot of other namespaces depend on. It seems to have little impact on initial compiles. Quote: "I'll give it a try with something else". Does that mean I should come up with something else or you have some ideas?

@dnolen rebased https://dev.clojure.org/jira/browse/CLJS-2216

not sure though if it has to be adapted still to reflect the changes from https://github.com/clojure/clojurescript/commit/345041b87f8004102aa300b50829e70fa0d646c4 ?

going to be afk for today

@rauh no I will try it with something else

easy to review one: https://dev.clojure.org/jira/browse/CLJS-2436

@martinklepsch thanks!