Fork me on GitHub

phew, cljs.closure/build is quite the beast ...


If you have any perf-critical ClojureScript code which is driven by large outputs of iterate, repeat, or cycle, especially if reduce or transducers are used, please give this patch a try and report how it goes for you.


@mfikes Just reviewing: Currently (realized (cycle [1 2])) returns false. In your test you now test this for true.


@rauh Yes, if that patch were accepted, it would be a change in behavior. It looks like Clojure addressed this here: I'll make a note in the ticket.

Jakub Holý (HolyJak)14:12:41

Follow-up of the previously shared article: I hope it can help others persuade their management to give Clojure(Script) a try. Feedback welcome!


@holyjak How has your experience been using NPM modules? Curious to what path you take - CLJSJS, :npm-deps, or something else?

Jakub Holý (HolyJak)15:12:33

We havent needed that yet, sorry :)


Cool, thanks for the reply. Would be interested to hear how that’s going when you get to that point.


I’ve used both. It’s really easy to get new packages on cljsjs if you do run into any issues with :npm-deps (since it’s in very early stages)


@dehli Have often do you run into issues using :npm-deps? I’ve tried in the past and seem to have come across compilation errors pretty frequently (e.g. not being able to locate a module in node_modules) to the point where I had to revert to CLJSJS. Just wanted to get a take on some other people’s experiences, and if it’s widespread or if I’m just doing it wrong.


Well this is my first time really using npm-deps 🙂 and none so far (but it’s a small library i’m writing with only two dependencies)


I think cljsjs is the way to go rn for an easy development experience


Cool, thanks for your feedback!


which version of clojurescript support tag #Inf?


It's likely the newest version of core.async use this?


I met this when I try to play with om and figwheel.

----  Could not Read  resources/public/js/compiled/out/cljs/core/async/impl/protocols.cljs   line:988  column:14  ----

  No reader function for tag Inf

----  Reader Error : Please see resources/public/js/compiled/out/cljs/core/async/impl/protocols.cljs  ----
my dependencies are:
[[org.clojure/clojure "1.9.0"]
 [org.clojure/clojurescript "1.9.946"]
 [org.clojure/core.async  "0.3.465"]
 [org.omcljs/om "1.0.0-beta1"]
 [com.taoensso/sente "1.12.0"]]


It's likely this is caused by [org.clojure/clojurescript "1.9.946"], the ##Inf in cljs.core/hash function has a syntax error.😢


@mfikes could you take a look on this?


@doglooksgood If you are using the latest ClojureScript you also need to ensure you are using the latest tools.reader


@mfikes how can I do that, by adding tools.reader as dependency?


@doglooksgood likely something is pulling in the wrong version


@dnolen I wonder if it's worth it to do a little check when booting up to see if the reader understands ##Inf and then just print out a descriptive error on how to fix it. This will error will probably keep coming up for a while.


not really that interested


there’s so many different cryptic errors if you have the wrong versions of things


@doglooksgood Presuming you are using Leiningen, lein deps :tree will give you a sense for what's pulling things in. Then it is a matter of the Maven dependency resolution rules. You can likely either add an exclusion on the dep that is pulling in an older version or explicitly specify the dep. If you are not using Leiningen, I'd check to see how it controls deps.


TIL: React devtools also has a "highlight updates". which flashes the elements every time they re-render. Which means I can retire my custom mixin I've had for years