Clojurians
#cljs-dev
<
2017-12-23
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro12:12:01

how does this work with e.g. JSX pre-processing now?

anmonteiro12:12:09

if a file is .jsx

juhoteperi12:12:12

@anmonteiro Do we support jsx?

anmonteiro12:12:26

I thought we did, with :pre-process

juhoteperi12:12:27

I don't think so? If we will, that code would need to be updated

juhoteperi12:12:35

Forgot about that

juhoteperi12:12:36

What would be the safest check here? Ignore only css? Allow js/json/jsx? Something else?

juhoteperi12:12:08

Closure might have some kind of TS support, or maybe that can be supported through preprocess also

anmonteiro12:12:10

perhaps introduce a compiler option for blacklisted extensions which defaults to only .css?

juhoteperi12:12:36

That's good idea

anmonteiro12:12:37

so that people can override it too

anmonteiro12:12:46

if they have a :preprocess for css

juhoteperi12:12:54

What about warning the first time a file is ignored?

anmonteiro12:12:09

doesn’t closure already do that?

anmonteiro12:12:13

I thought it did

juhoteperi12:12:43

Not in this case

anmonteiro13:12:11

looks OK to me

juhoteperi13:12:59

What about the warning? IF user has preprocess which does something with css, those would be now silently ignored

dnolen13:12:04

@juhoteperi I think logging that file is being ignored under :verbose is fine?

juhoteperi13:12:46

I'll implement that in a moment

thheller14:12:31

@juhoteperi +(some (fn [x] nil) []) don’t think that needs to be in the patch https://dev.clojure.org/jira/secure/attachment/17581/CLJS-2450-2.patch

dnolen15:12:00

yeah that should be fixed also need to pull master, that won’t apply