@juhoteperi hrm https://github.com/clojure/clojurescript/commit/123e8f9aa59899c6886bbe392128b22ae9a0def3

how does this work with e.g. JSX pre-processing now?

if a file is .jsx

@anmonteiro Do we support jsx?

I thought we did, with :pre-process

I don't think so? If we will, that code would need to be updated

Ohhh.. yeah

Forgot about that

What would be the safest check here? Ignore only css? Allow js/json/jsx? Something else?

Closure might have some kind of TS support, or maybe that can be supported through preprocess also

perhaps introduce a compiler option for blacklisted extensions which defaults to only .css?

That's good idea

so that people can override it too

if they have a :preprocess for css

What about warning the first time a file is ignored?

doesn’t closure already do that?

I thought it did

Not in this case

@anmonteiro https://dev.clojure.org/jira/secure/attachment/17579/CLJS-2450.patch any comments? Is the option name OK?

I think so

looks OK to me

What about the warning? IF user has preprocess which does something with css, those would be now silently ignored

@juhoteperi I think logging that file is being ignored under :verbose is fine?

I'll implement that in a moment

@juhoteperi +(some (fn [x] nil) []) don’t think that needs to be in the patch https://dev.clojure.org/jira/secure/attachment/17581/CLJS-2450-2.patch

yeah that should be fixed also need to pull master, that won’t apply