This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-05-12
Channels
- # bangalore-clj (1)
- # beginners (28)
- # boot (33)
- # chestnut (3)
- # cider (35)
- # cljs-dev (64)
- # cljsrn (16)
- # clojure (95)
- # clojure-android (6)
- # clojure-austin (1)
- # clojure-italy (5)
- # clojure-korea (1)
- # clojure-russia (55)
- # clojure-sg (1)
- # clojure-spec (25)
- # clojure-uk (57)
- # clojurescript (120)
- # code-reviews (7)
- # community-development (2)
- # core-async (3)
- # cursive (6)
- # data-science (3)
- # datascript (10)
- # datomic (12)
- # devcards (1)
- # emacs (9)
- # gsoc (7)
- # hoplon (18)
- # lumo (2)
- # off-topic (10)
- # om (24)
- # onyx (17)
- # pedestal (46)
- # powderkeg (1)
- # protorepl (7)
- # re-frame (31)
- # ring-swagger (34)
- # spacemacs (10)
- # specter (9)
- # sql (39)
- # unrepl (9)
- # untangled (3)
- # utah-clojurians (1)
probably going to cut a release today - if there’s something you’d like to see in there let me know - now would also be a good time to test
@dnolen https://dev.clojure.org/jira/browse/CLJS-2021 would be nice too (hope I'm not too late here)
@thheller I’m going to pass this time on CLJS-1992, don’t want to introduce new warnings with this cut
sure. an alternate solution would be to just silently drop the declare and do nothing since it is pointless anyway
I’m getting an NPE in jdk.nashorn.tools.Shell.preprocessArgs
running tests with latest master
@dnolen big and exciting one: https://dev.clojure.org/jira/browse/CLJS-2034
turns out Clojure swapped the transducer implementation back in 2015 but CLJS’s was still outdated, leading to certain bugs
^ that patch makes it up to date with the current impl in Clojure (`LazyTransformer` -> TransformerIterator
)
@anmonteiro thanks!
was really fun
@anmonteiro applied
awesome
@dnolen cljs.core is getting analyzed twice, the second pass will complain about every declare
because the first one had the defs
. not sure if that is new, will continue tomorrow.
@thheller right that will probably require some digging, tried pretty hard to avoid that - but obviously missed somethign
@mfikes looks like I have first regression in Dirac’s REPL with the new cljs release: https://gist.github.com/darwin/e5adfa335dd382289526410dfcac4ff9 not sure what this is, but it might be related to your patch
I’m probably passing incompatible reader for your new code, here: https://github.com/binaryage/dirac/blob/master/src/nrepl/dirac/nrepl/eval.clj#L211
I need to learn how to use Dirac anyway soon—the only downstream tooling I had tested that REPL change for regressions with was Figwheel.
my wild guess is that the reader I constructed is incompatible somehow:
1) I create a StringReader
here: https://github.com/binaryage/dirac/blob/master/src/nrepl/dirac/nrepl/eval.clj#L203
2) then I wrap it with source logging push back reader here: https://github.com/binaryage/dirac/blob/master/src/nrepl/dirac/nrepl/eval.clj#L92