Clojurians
#cljs-dev
<
2017-05-12
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen12:05:23

probably going to cut a release today - if there’s something you’d like to see in there let me know - now would also be a good time to test

mfikes12:05:21

Master currently LGTM

dnolen12:05:17

@thheller k will take a look

frank14:05:29

@dnolen https://dev.clojure.org/jira/browse/CLJS-2021 would be nice too (hope I'm not too late here)

dnolen14:05:58

@frank thanks will take a look

thheller14:05:44

let me know if I can help in any way

dnolen14:05:48

@thheller makes sense, I saw that one before, added to my queue

dnolen18:05:46

@thheller I’m going to pass this time on CLJS-1992, don’t want to introduce new warnings with this cut

thheller18:05:48

sure. an alternate solution would be to just silently drop the declare and do nothing since it is pointless anyway

dnolen18:05:06

@frank I don’t see your name in the contributor list

thheller18:05:17

currently it destroys some analyzer data which is bad

dnolen18:05:55

agreed but I just want to get the spec thing, so nothing against the ticket at all

dnolen18:05:00

let’s apply it after release

thheller18:05:27

ok much more interested in CLJS-2019 :slightly_smiling_face:

dnolen18:05:26

looking at that now

dnolen18:05:58

looks good applying

mfikes19:05:26

I’m getting an NPE in jdk.nashorn.tools.Shell.preprocessArgs running tests with latest master

mfikes19:05:05

Bisecting…

dnolen19:05:57

@mfikes which tests?

mfikes19:05:20

It is a fast-fail, before tests run. I’m re-checking. Probably an error on my part…

dnolen19:05:21

oh also bumping to Clojure 1.9.0-alpha16 broke some stuff

dnolen19:05:27

I’m fixing the bootstrap script now

dnolen19:05:36

if you’re running tests that depend on bootstrap being correct

mfikes19:05:58

OK… will hold off for your latest

dnolen19:05:37

master updated, probably want to delete all dirs that bootstrap script creates

dnolen19:05:50

I ran all the various testing scripts and they all passed w/o hitch over here

mfikes19:05:45

Cloning to a fresh dir to make absolutely sure…

dnolen19:05:20

cool, thanks - things are look alright over here

mfikes19:05:24

@dnolen With latest master, all tests pass for me, including downstream Planck tests

anmonteiro20:05:54

turns out Clojure swapped the transducer implementation back in 2015 but CLJS’s was still outdated, leading to certain bugs

anmonteiro20:05:39

^ that patch makes it up to date with the current impl in Clojure (`LazyTransformer` -> TransformerIterator)

dnolen20:05:29

@anmonteiro thanks!

anmonteiro20:05:45

was really fun

dnolen20:05:03

@anmonteiro applied

dnolen20:05:20

@theller left a comment CLJS-1992 - I see a bunch of warnings when I apply that

dnolen20:05:24

@thheller ^

dnolen20:05:27

when running tests

frank20:05:08

I signed the CA on may 1 under the name "Frank Wang"

dnolen21:05:42

@frank I only see Lei Wang, so maybe not posted yet?

dnolen21:05:54

this gets updated periodically

frank21:05:37

ah I guess it's just not posted yet

thheller21:05:33

@dnolen odd those weren't there before, will look into it

thheller21:05:31

@dnolen cljs.core is getting analyzed twice, the second pass will complain about every declare because the first one had the defs. not sure if that is new, will continue tomorrow.

dnolen21:05:08

@thheller right that will probably require some digging, tried pretty hard to avoid that - but obviously missed somethign

darwin21:05:00

@mfikes looks like I have first regression in Dirac’s REPL with the new cljs release: https://gist.github.com/darwin/e5adfa335dd382289526410dfcac4ff9 not sure what this is, but it might be related to your patch

mfikes21:05:36

Definitely looks like it could be

darwin22:05:34

I will look into it tomorrow, unfortunately don’t have time atm

darwin22:05:43

just wanted to post it here, just FYI

darwin22:05:49

I’m probably passing incompatible reader for your new code, here: https://github.com/binaryage/dirac/blob/master/src/nrepl/dirac/nrepl/eval.clj#L211

mfikes22:05:54

I need to learn how to use Dirac anyway soon—the only downstream tooling I had tested that REPL change for regressions with was Figwheel.

darwin22:05:09

my wild guess is that the reader I constructed is incompatible somehow: 1) I create a StringReader here: https://github.com/binaryage/dirac/blob/master/src/nrepl/dirac/nrepl/eval.clj#L203 2) then I wrap it with source logging push back reader here: https://github.com/binaryage/dirac/blob/master/src/nrepl/dirac/nrepl/eval.clj#L92

mfikes22:05:27

(It will take a bit of time for me to re-understand the code I had written—that patch was put together in Feb 2016.)

darwin22:05:28

and that is what you try to use with unread

darwin22:05:03

don’t spend time on it, I will try to fix it tomorrow on my end