This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-02-17
Channels
- # admin-announcements (3)
- # announcements (1)
- # aws (3)
- # beginners (41)
- # boot (109)
- # braid-chat (2)
- # braveandtrue (5)
- # cider (11)
- # cljs-dev (38)
- # cljsjs (15)
- # cljsrn (5)
- # clojure (87)
- # clojure-berlin (16)
- # clojure-ireland (1)
- # clojure-japan (10)
- # clojure-madison (3)
- # clojure-nl (3)
- # clojure-poland (6)
- # clojure-russia (115)
- # clojure-sg (1)
- # clojurebridge (35)
- # clojured (8)
- # clojurescript (36)
- # core-async (24)
- # cursive (18)
- # datavis (1)
- # datomic (27)
- # dirac (22)
- # editors (1)
- # emacs (3)
- # events (19)
- # hoplon (149)
- # ldnclj (7)
- # lein-figwheel (1)
- # luminus (1)
- # off-topic (70)
- # om (196)
- # onyx (63)
- # parinfer (155)
- # proton (36)
- # re-frame (69)
- # reagent (2)
- # ring (2)
- # ring-swagger (1)
- # slack-help (4)
- # spacemacs (9)
- # testing (11)
https://github.com/clojure/clojurescript/commit/2b948b0f36f897dab9575e6a5f35c70e61ea8a7f
Now would be a good time to test master in your projects - just bumped Google Closure Compiler
@dnolen https://github.com/clojure/clojurescript/commit/2b948b0f36f897dab9575e6a5f35c70e61ea8a7f#diff-84ffd22349e5ca1fe6322cb0e379b3b1R173
believe I’ve found a bug with source-maps in cljs.js when non-latin characters are used in strings/keywords/etc - "DOMException: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.” (at goog.crypt.base64.encodeString < cljs.js/append-source-map < cljs.js/compile-str). stack trace: https://gist.github.com/mhuebert/942c95e760ed2e6b5f7a, you can also see for yourself in a Chrome console by running btoa("•")
@mhuebert: source mapping hasn’t been extensively tested on the runtime side - so very possible
@dnolen we may just need to escape the string that we hand to base64/encodeString - https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#The_Unicode_Problem
aye the closure-compiler version in ClojureScript master has been rolled back: https://github.com/google/closure-compiler/wiki/Releases
oh hrm, I guess it doesn’t have an announce on the mailing list, so maybe it never happened officially?
but am not sure yet where one must change the version number, it’s in project.clj, pom.xml..
ah just that and pom.template.xml but I’m guessing you don’t normally update each manually
here it is in a gist: https://gist.github.com/mhuebert/286b09f672e834fbb21d feedback welcome of course. tested locally & works for me.
@mhuebert: you can attach the patch to the issue by clicking Edit
if that's not available to you, you might be missing permissions, in which case you need to ask David
@anmonteiro: yes ’tis a permissions lack