Clojurians
#cljs-dev
<
2016-02-17
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen13:02:46

Now would be a good time to test master in your projects - just bumped Google Closure Compiler

dnolen13:02:54

as well as tools reader

thheller14:02:08

unless I'm completely off

thheller14:02:25

you can just do (Charset/forName "us-ascii") etc.

thheller14:02:32

not sure you really need that conversion map

dnolen14:02:39

What does it do if none exists?

dnolen14:02:53

In the case of typo

thheller14:02:00

UnsupportedCharsetException

dnolen14:02:15

Ah k, thanks

thheller14:02:18

(java.nio.charset.Charset/forName "bla")

thheller14:02:34

UnsupportedCharsetException bla

mhuebert18:02:56

believe I’ve found a bug with source-maps in cljs.js when non-latin characters are used in strings/keywords/etc - "DOMException: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.” (at goog.crypt.base64.encodeString < cljs.js/append-source-map < cljs.js/compile-str). stack trace: https://gist.github.com/mhuebert/942c95e760ed2e6b5f7a, you can also see for yourself in a Chrome console by running btoa("•")

dnolen18:02:41

@mhuebert: source mapping hasn’t been extensively tested on the runtime side - so very possible

dnolen18:02:23

most people are just using source mapping to let the browser sort it out

mhuebert18:02:04

@dnolen we may just need to escape the string that we hand to base64/encodeString - https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#The_Unicode_Problem

dnolen18:02:26

@mhuebert: sure, ticket + patch welcome

dnolen18:02:38

I’ve done pretty much everything I intend to every to wrt. source maps long ago :simple_smile:

mhuebert20:02:05

aye the closure-compiler version in ClojureScript master has been rolled back: https://github.com/google/closure-compiler/wiki/Releases

dnolen20:02:06

@mhuebert: hrm but the Feb release also has no Maven artifact

dnolen20:02:57

oh hrm, I guess it doesn’t have an announce on the mailing list, so maybe it never happened officially?

mhuebert20:02:59

yeah, I’m trying to get the 0208 v installed locally

mhuebert20:02:49

but am not sure yet where one must change the version number, it’s in project.clj, pom.xml..

mhuebert20:02:30

ah just that and pom.template.xml but I’m guessing you don’t normally update each manually

mhuebert20:02:34

I don’t seem to be able to attach the patch to the issue

mhuebert20:02:42

here it is in a gist: https://gist.github.com/mhuebert/286b09f672e834fbb21d feedback welcome of course. tested locally & works for me.

mhuebert20:02:29

also just submitted the CA this evening

anmonteiro20:02:47

@mhuebert: you can attach the patch to the issue by clicking Edit

anmonteiro20:02:13

if that's not available to you, you might be missing permissions, in which case you need to ask David

mhuebert21:02:00

@anmonteiro: yes ’tis a permissions lack

dnolen21:02:35

@mhuebert: link to issue?

dnolen21:02:11

@mhuebert: I upgraded your privileges

mhuebert22:02:28

@dnolen thanks. I just uploaded the patch.

dnolen22:02:31

@mhuebert: thanks!

dnolen22:02:02

reverted ClojureScript master back to Closure Compiler v20151215 for the time being

mhuebert23:02:46

good idea. i did my testing with the latest jar but was a bit of a pain.