2022-06-28 cljdoc | Clojure Slack Archive

cljdoc

2022-06-28T13:42:58.255369Z

is this a good spot to post docs jobs that failed?

👍 1

lread 2022-06-28T14:56:14.054519Z

Absolutely @nbtheduke! If you are having trouble figuring out what has gone wrong we can try to help diagnose.

2022-06-28T14:57:03.226239Z

Well, it's not my project, but I can always try to open PRs/issues to help out

2022-06-28T14:57:04.145309Z

https://cljdoc.org/builds/57580

lread 2022-06-28T15:14:34.387549Z

Hmm.... a quick glance lounging with my laptop suggests that maybe deep-diff2 is bundling its tests in its release jar? I'll take a good look when I eventually drag myself over to my desktop.

2022-06-28T15:16:22.719789Z

cool, no worries, there's no rush

lread 2022-06-28T17:15:18.961999Z

Yeah my guess seems correct, if I list the jar contents:

$ jar tf ~/.m2/repository/lambdaisland/deep-diff2/2.2.124/deep-diff2-2.2.124.jar

META-INF/MANIFEST.MF
META-INF/
lambdaisland/
lambdaisland/deep_diff2/
lambdaisland/deep_diff2/puget/
lambdaisland/deep_diff2/puget/color/
META-INF/maven/
META-INF/maven/lambdaisland/
META-INF/maven/lambdaisland/deep-diff2/
lambdaisland/deep_diff2_test.cljc
lambdaisland/deep_diff2/printer_impl.cljc
lambdaisland/deep_diff2/printer_test.cljc
lambdaisland/deep_diff2/diff_impl.cljc
lambdaisland/deep_diff2/puget_test.cljc
lambdaisland/deep_diff2/puget/dispatch.cljc
lambdaisland/deep_diff2/puget/color/ansi.cljc
lambdaisland/deep_diff2/puget/color/html.cljc
lambdaisland/deep_diff2/puget/printer.cljc
lambdaisland/deep_diff2/puget/color.cljc
lambdaisland/deep_diff2/diff_test.cljc
lambdaisland/deep_diff2.cljc
META-INF/maven/lambdaisland/deep-diff2/pom.xml
META-INF/maven/lambdaisland/deep-diff2/pom.properties

we can see all test sources are included (ex. deep_diff2_test.cljc ) - most likely not on purpose. When cljdoc tries to analyze the jar, the test libs the the test sources depend on aren’t included as deps for the jar therefore they won’t be found and… then analysis fails.

lread 2022-06-28T17:22:00.944939Z

I can raise an issue over at deep-diff2.

👍 1

2022-06-28T17:29:26.640199Z

thanks for looking into it!

lread 2022-06-28T17:32:10.323609Z

Here it is!: https://github.com/lambdaisland/deep-diff2/issues/26

2022-06-28T17:33:46.232409Z

hashtag blessed

lread 2022-06-28T17:34:29.920929Z

Thanks for raising @nbtheduke, it’s nice to have docs of much loved libraries working on cljdoc!

👍 1

❤️ 1

2022-06-28T17:52:39.889139Z

cljdoc has become my goto way of reading docs, no more reading just the github readme lol

lread 2022-06-28T17:54:16.110689Z

I like it too @nbtheduke! Always happy to hear feedback on what we could improve (or what you want to help improve for that matter!).

lread 2022-07-03T15:33:41.609409Z

And... a new release of deep-diff2 by the good folks at lambdaisland has fixed the issue!

🎉 1

Clojurians Log v2

cljdoc