Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2022-06-28

Channels

#cljdoc
<
2022-06-28
>
Noah Bogart13:06:58

is this a good spot to post docs jobs that failed?

👍 1
lread14:06:14

Absolutely @nbtheduke! If you are having trouble figuring out what has gone wrong we can try to help diagnose.

Noah Bogart14:06:03

Well, it's not my project, but I can always try to open PRs/issues to help out

lread15:06:34

Hmm.... a quick glance lounging with my laptop suggests that maybe deep-diff2 is bundling its tests in its release jar? I'll take a good look when I eventually drag myself over to my desktop.

Noah Bogart15:06:22

cool, no worries, there's no rush

lread17:06:18

Yeah my guess seems correct, if I list the jar contents: 

$ jar tf ~/.m2/repository/lambdaisland/deep-diff2/2.2.124/deep-diff2-2.2.124.jar

META-INF/MANIFEST.MF
META-INF/
lambdaisland/
lambdaisland/deep_diff2/
lambdaisland/deep_diff2/puget/
lambdaisland/deep_diff2/puget/color/
META-INF/maven/
META-INF/maven/lambdaisland/
META-INF/maven/lambdaisland/deep-diff2/
lambdaisland/deep_diff2_test.cljc
lambdaisland/deep_diff2/printer_impl.cljc
lambdaisland/deep_diff2/printer_test.cljc
lambdaisland/deep_diff2/diff_impl.cljc
lambdaisland/deep_diff2/puget_test.cljc
lambdaisland/deep_diff2/puget/dispatch.cljc
lambdaisland/deep_diff2/puget/color/ansi.cljc
lambdaisland/deep_diff2/puget/color/html.cljc
lambdaisland/deep_diff2/puget/printer.cljc
lambdaisland/deep_diff2/puget/color.cljc
lambdaisland/deep_diff2/diff_test.cljc
lambdaisland/deep_diff2.cljc
META-INF/maven/lambdaisland/deep-diff2/pom.xml
META-INF/maven/lambdaisland/deep-diff2/pom.properties
we can see all test sources are included (ex. deep_diff2_test.cljc ) - most likely not on purpose. When cljdoc tries to analyze the jar, the test libs the the test sources depend on aren’t included as deps for the jar therefore they won’t be found and… then analysis fails.

lread17:06:00

I can raise an issue over at deep-diff2.

👍 1
Noah Bogart17:06:26

thanks for looking into it!

Noah Bogart17:06:46

hashtag blessed

lread17:06:29

Thanks for raising @nbtheduke, it’s nice to have docs of much loved libraries working on cljdoc!

👍 1
❤️ 1
Noah Bogart17:06:39

cljdoc has become my goto way of reading docs, no more reading just the github readme lol

lread17:06:16

I like it too @nbtheduke! Always happy to hear feedback on what we could improve (or what you want to help improve for that matter!).

lread15:07:41

And... a new release of deep-diff2 by the good folks at lambdaisland has fixed the issue!

🎉 1