Fork me on GitHub
#cljdoc
<
2018-11-01
>
timgilbert15:11:52

Hey, I noticed that this link: https://cljdoc.org/d/lambdaisland/kaocha/CURRENT ...winds up on the 0.0-7 version of the docs, but actually the most current version is 0.0-243. Presumably some logic is sorting the post-dash part alphabetically rather than numerically. I'm not really sure if this is a bug or not, honestly, but I thought I'd mention it

martinklepsch15:11:18

Hey @U08QZ7Y5S & thanks for bringing this up, I don’t think it was a known issue. We use version-clj for sorting versions in most places. It might be that we don’t for this particular thing (a bug) or that version-clj simply doesn’t agree with this kind of versioning scheme 😄

timgilbert15:11:47

Makes sense. Would it be helpful to open a ticket?

martinklepsch15:11:19

So we use this file to determine the latest release version: http://repo.clojars.org/lambdaisland/kaocha/maven-metadata.xml

martinklepsch15:11:45

(and we don't use version-clj contrary to what I said earlier)

timgilbert15:11:05

Oh, interesting. So maybe it's some kind of bug in the way they deployed that jar file. I'll bug the kaocha folks about it, thanks for the info!

martinklepsch15:11:02

I think the 0.0-N pattern is just not something Maven deals with very well

plexus15:11:28

so... this is probably because I screwed up. When I created kaocha-junit-xml I copied the pom over from kaocha and forgot to update the project name. So when I did the first release of kaocha-junit-xml it actually pushed it to clojars as kaocha 0.0-7...

plexus15:11:47

I'll push a new kaocha, that should make the problem go away

martinklepsch15:11:04

However in repositories.clj line 106 and onwards we could just extract all the listed versions and sort them using version-clj a quick REPL test seems to indicate that version-clj would handle this correctly

timgilbert15:11:07

Awesome,t hanks

plexus15:11:18

the 0.0-N pattern is what clojurescript used before they switched to following Clojure versions, that's where I got the idea.

martinklepsch15:11:39

Interesting... Well I'd be happy to accept a PR to support this. I think it should be a fairly easy thing that can be easily tested from the REPL as well (the repositories namespace doesn't require any system to be started etc.)

plexus15:11:31

note also that clojure itself is making it impossible right now to correctly sort by version, as they released beta1 > beta2 > RC1 > beta3 > beta4

😏 4
plexus16:11:02

the link to /CURRENT works again now

martinklepsch16:11:28

BTW the /CURRENT bit is optional now

upside_down_parrot 4