Clojurians
#cljs-dev
<
2018-11-01
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes12:11:33

With additional type inference being added to the compiler, we may end up fielding questions about the semantics of the type system. I've started drafting some copy that, once mature, might be suitable as a guide in the future: https://gist.github.com/mfikes/b87c67b4d3386f097bc629dab6f17e48

borkdude16:11:42

cljs.user=> *clojurescript-version*
"1.10.437"
cljs.user=> (stest/with-instrument-disabled 1)
            ^
WARNING: var: cljs.spec.test.alpha/*instrument-enabled* is not public at line 1

borkdude16:11:13

will do. this was a test if it was JIRA-worthy :slightly_smiling_face:

slipset16:11:25

The greatest benefit of speculative so far is that it uncovers bugs in Clojurescripts spec implementation.

mfikes22:11:07

^ patch attached

borkdude22:11:57

I’m running the tests from master with Nashorn, but it seems not all of them pass

mfikes22:11:59

script/test was passing under Nashorn for me a few weeks ago (but I haven’t tried current master)

mfikes22:11:15

I suspect we are OK in that Travis passed latest master commit and it runs the tests through Nashorn

borkdude23:11:58

Here is what I see with my checkout:

script/clean
script/build
script/test

ERROR in (test-cljs-1812) (ReferenceError:NaN:NaN)
Uncaught exception, not in assertion.
expected: nil
  actual: #object[ReferenceError ReferenceError: "f" is not defined]

ERROR in (column-writer-test) (Error:NaN:NaN)
...   actual: #object[Error Error: No protocol method IWriter.-write defined for type null: ]

FAIL in (column-writer-test) (core-advanced-test.js:NaN:1298)
Ran 432 tests containing 19224 assertions.
1 failures, 2 errors.

borkdude23:11:53

$ $NASHORN_HOME/jjs -v
nashorn 1.8.0_45

borkdude23:11:20

working dir clean +

$ git log
commit 6b9a37a294746148d3f4f8c1b6839823fe6e23f3 (HEAD -> master, origin/master, origin/HEAD)
Author: Jordan Biserkov <[email protected]>
Date:   Fri Sep 28 19:37:01 2018 +0300

    CLJS-2728: Ability to disable macro spec checks

mfikes23:11:00

I’m AFK, but I wonder if that jjs version corresponds to the JVM version. There are versions beyond 1.8.0_162 so perhaps that (presumably) older Nashorn VM has bugs.

dnolen23:11:54

@borkdude less concerned about Nashorn than other engines generally

borkdude23:11:52

Upgraded Nashorn to 191.

Ran 432 tests containing 19223 assertions.
0 failures, 0 errors.