anyone wants to test a new feature that shows unresolved symbols?

simple example: https://www.dropbox.com/s/8hwjal4aihae4gu/Screenshot%202019-06-11%2017.44.32.png?dl=0

the main goal is to eliminate false positives 🙂

I would be glad to

@thenonameguy would you like to run with a binary (if so, linux or mac), or the clojure version (JVM)?

I’m using OSX, I’ve been using brew to upgrade

but I can probably run it through clj

that would be fine, but here’s the MacOS binary just in case: https://3562-176829714-gh.circle-artifacts.com/0/release/clj-kondo-2019.06.08-alpha-SNAPSHOT-macos-amd64.zip

the branch with the work in progress is called unresolved-symbols in case you want to try it with clj

This is the issue, in case you want to report anything: https://github.com/borkdude/clj-kondo/issues/174

thanks, I’ll report back. It seems to work btw, I’m just seeing false positives like deftest, I’ll probably have to create a new cache for this

deftest should work, but you’ll have to use :require (unless I’m not understanding correctly your false positive)

clj-kondo doesn’t support use just like joker 🙂

./test/main/atlas/s3_test.clj:8:2: error: unresolved symbol use-fixtures
./test/main/atlas/s3_test.clj:9:4: error: unresolved symbol compose-fixtures
./test/main/atlas/s3_test.clj:16:2: error: unresolved symbol deftest

(ns atlas.s3-test
  (:require ...
            [clojure.test :refer :all]
           ...))

(use-fixtures :once
...

yeah, don’t use :refer :all (effectively the same as :use)

https://github.com/bbatsov/clojure-style-guide#prefer-require-over-use

I could make it work, technically, but it would be a lot more complex and at the same time, I think it make sense if we abandoned use and refer all as a community. Even more so, since ClojureScript doesn’t support it, so you’re already on your way to good .cljc if you adopt this practice.

I should probably document this in the “opinionated” section of clj-kondo 🙂

but I was going to write a “how to ns” kind of linter, which is also will help you with this: https://stuartsierra.com/2016/clojure-how-to-ns.html

@borkdude oh interesting, I thought the :refer :all in test code was the norm, it's the only place I've seen it and allowed it in my code

I guess the alternative is to :refer what you need by name

I use refer all extensively in dev namespaces, I think the clojure.test usage is okay also, because they're globally unique. But cljs doesn't even support it so makes life hard anyway.