Fork me on GitHub
#clj-commons
<
2021-11-17
>
martinklepsch10:11:18

Transfer initiated! 🙂

slipset10:11:47

Mail received 🙂

slipset20:11:51

I guess we should get a first clj-commons release of clj-http-lite. @borkdude are you ok if I do that?

slipset20:11:12

I might want to change from github-actions to circle to do the ci/cd stuff as well

slipset20:11:30

I’ll look into that tomorrow then.

borkdude20:11:32

as a fan of circle I'm not opposed to that

slipset20:11:09

Did you see @ingesol made a “port” of my build stuff to deps.edn based builds?

slipset20:11:50

There is some more to this, but basically he has the whole “deploy-to-clojars-by-pushing-a-tag” going for that project.

borkdude20:11:31

yeah, makes sense

seancorfield21:11:17

I have several of my projects auto-deploying SNAPSHOT builds to Clojars on every successful main branch CI run (via GH actions). I've been toying with the idea of automating releases but I'm still a bit paranoid about that last step 🙂

Ben Sless21:11:05

You can add manual prompt actions

seancorfield22:11:58

Yeah, I've been considering it.

seancorfield22:11:52

I decided to do it on push tags v* which triggers it when I cut a release on GH -- so I still have full control over change logs and release notes and no longer need to manually do the ci/deploy step locally 🙂

borkdude21:11:52

@seancorfield I have automated releases with automatic uploading of artifacts (even from different build environments to one release: Circle, Appveyor) but it puts the release in draft. Then when every process has uploaded its thing, I publish it from draft to public.

borkdude21:11:35

This is my personal lib I use in several builds: https://github.com/borkdude/gh-release-artifact

seancorfield22:11:03

Interesting approach. You're not uploading those to Clojars tho', right?

borkdude22:11:36

No. This is for files you can download from Github Releases.

borkdude22:11:01

I thought you meant that with Release :)

borkdude21:11:13

Oh you mean, non-SNAPSHOT releases? Why would you think it's safer to do this from your own machine rather than from CI?

borkdude21:11:33

I would think the reverse. It happened to me more than once that I compiled some Java sources using JVM 11 and someone on 8 couldn't use it.

seancorfield22:11:42

I don't have to worry about Java or AOT but I guess I still view non-snapshot releases as "Important(™)" and so they should be deliberate and not quite as automated. But I could add a manual GH action for it since the only difference is whether I specify :snapshot true for my build action or not...

seancorfield22:11:43

Y'all convinced me. next.jdbc 1.2.753 was an automated release to Clojars from GH Actions. Thank you for the "push". I'll update other repos as I get close to releases...

đź‘Ť 2
Ben Sless06:11:17

Do you trigger the push manually or by pushing a tag?

Ben Sless06:11:44

Asking after looking through the task and build files

seancorfield06:11:48

I created a release on github. Which is my normal process for a release. And then github actions built the jar and pushed it to Clojars with no further work from me.

seancorfield06:11:26

So "create a release" = "push a tag"

Ben Sless06:11:28

Did you tag from your computer or using an action?

seancorfield13:11:58

@UK0810AQ2 I create a release on github so that I can draft proper release notes. That triggers the tag-based Action.

Ben Sless14:11:17

Thanks I'll try experimenting with it, too