clj-commons

martinklepsch 2021-11-17T10:24:18.070200Z

Transfer initiated! ๐Ÿ™‚

slipset 2021-11-17T10:25:47.070400Z

Mail received ๐Ÿ™‚

slipset 2021-11-17T20:45:51.071100Z

I guess we should get a first clj-commons release of clj-http-lite. @borkdude are you ok if I do that?

borkdude 2021-11-17T20:46:02.071500Z

sure

slipset 2021-11-17T20:46:12.071800Z

I might want to change from github-actions to circle to do the ci/cd stuff as well

slipset 2021-11-17T20:46:30.072200Z

Iโ€™ll look into that tomorrow then.

borkdude 2021-11-17T20:46:32.072400Z

as a fan of circle I'm not opposed to that

slipset 2021-11-17T20:47:09.072900Z

Did you see @ingesol made a โ€œportโ€ of my build stuff to deps.edn based builds?

borkdude 2021-11-17T20:47:27.073100Z

I haven't

slipset 2021-11-17T20:48:50.074300Z

There is some more to this, but basically he has the whole โ€œdeploy-to-clojars-by-pushing-a-tagโ€ going for that project.

borkdude 2021-11-17T20:49:31.074700Z

yeah, makes sense

seancorfield 2021-11-17T21:30:17.076400Z

I have several of my projects auto-deploying SNAPSHOT builds to Clojars on every successful main branch CI run (via GH actions). I've been toying with the idea of automating releases but I'm still a bit paranoid about that last step ๐Ÿ™‚

Ben Sless 2021-11-17T21:47:05.076600Z

You can add manual prompt actions

seancorfield 2021-11-17T22:00:58.079500Z

Yeah, I've been considering it.

seancorfield 2021-11-17T22:39:52.082200Z

I decided to do it on push tags v* which triggers it when I cut a release on GH -- so I still have full control over change logs and release notes and no longer need to manually do the ci/deploy step locally ๐Ÿ™‚

borkdude 2021-11-17T21:47:52.077600Z

@seancorfield I have automated releases with automatic uploading of artifacts (even from different build environments to one release: Circle, Appveyor) but it puts the release in draft. Then when every process has uploaded its thing, I publish it from draft to public.

borkdude 2021-11-17T21:49:35.077900Z

This is my personal lib I use in several builds: https://github.com/borkdude/gh-release-artifact

seancorfield 2021-11-17T22:06:03.081600Z

Interesting approach. You're not uploading those to Clojars tho', right?

borkdude 2021-11-17T22:06:36.081800Z

No. This is for files you can download from Github Releases.

borkdude 2021-11-17T22:07:01.082Z

I thought you meant that with Release :)

borkdude 2021-11-17T21:54:13.078700Z

Oh you mean, non-SNAPSHOT releases? Why would you think it's safer to do this from your own machine rather than from CI?

borkdude 2021-11-17T21:54:33.079200Z

I would think the reverse. It happened to me more than once that I compiled some Java sources using JVM 11 and someone on 8 couldn't use it.

seancorfield 2021-11-17T22:03:42.081500Z

I don't have to worry about Java or AOT but I guess I still view non-snapshot releases as "Important(โ„ข)" and so they should be deliberate and not quite as automated. But I could add a manual GH action for it since the only difference is whether I specify :snapshot true for my build action or not...

seancorfield 2021-11-17T22:40:43.083300Z

Y'all convinced me. next.jdbc 1.2.753 was an automated release to Clojars from GH Actions. Thank you for the "push". I'll update other repos as I get close to releases...

๐Ÿ‘ 2
Ben Sless 2021-11-18T06:32:17.083600Z

Do you trigger the push manually or by pushing a tag?

Ben Sless 2021-11-18T06:32:44.083800Z

Asking after looking through the task and build files

seancorfield 2021-11-18T06:38:48.084Z

I created a release on github. Which is my normal process for a release. And then github actions built the jar and pushed it to Clojars with no further work from me.

seancorfield 2021-11-18T06:39:26.084200Z

So "create a release" = "push a tag"

Ben Sless 2021-11-18T06:49:28.084400Z

Did you tag from your computer or using an action?

seancorfield 2021-11-19T13:28:58.084800Z

@ben.sless I create a release on github so that I can draft proper release notes. That triggers the tag-based Action.

Ben Sless 2021-11-19T14:13:17.085Z

Thanks I'll try experimenting with it, too