@ikitommi (single) file upload added to swagger seems to work... but processing the request-body doesn't seem to work pretty well:

(def image-resource
  (yada
   (yada/resource
    {:id ::images
     :methods
     {:post {:summary "add new images"
             :consumes "multipart/form-data"
             :consumer (fn [ctx _ body-stream]
                         (let [ctx @(process-request-body ctx body-stream "multipart/form-data")]
                           (clojure.pprint/pprint (find-part ctx "image1"))
                           (clojure.pprint/pprint (find-part ctx "image2")))
                         {:something :ok})
             :parameters {:form {:image1 java.io.File
                                 :image2 java.io.File}}
             :response post-images}}})))

The result of above code: it hangs on (let [ctx @(process-request-body ctx body-stream "multipart/form-data")

Trying to consume multipart/form-data... :

:consumer (fn [ctx _ body-stream]
                         (with-open [rdr ( body-stream)]
                           (println (clojure.string/join "\n" (line-seq rdr)))))

-----------------------------938581027424650894225881368
Content-Disposition: form-data; name="image1"; filename="xxx"
Content-Type: text/csv
...

-----------------------------938581027424650894225881368
Content-Disposition: form-data; name="image2"; filename="yyy"
Content-Type: application/json

...
-----------------------------938581027424650894225881368--

However, when I try to use yada.request-body/process-request-body, things don't seem to work very well:

:consumer (fn [ctx _ body-stream]
                         (let [req (process-request-body ctx body-stream "multipart/form-data")]
                           {:something :ok
                            :image1 (find-part @req "image1")}))

no deref:

:consumer (fn [ctx _ body-stream]
                         (let [req (process-request-body ctx body-stream "multipart/form-data")]
                           {:something :ok
                            :image1 (find-part req "image1")}))

[manifold-pool-2-1:6510]ERROR:[clojure.tools]clojure.tools.logging.invoke at logging.clj:288
   error in HTTP handler: java.lang.AssertionError: Assert failed: (:method-wrapper ctx)
      at yada.interceptors$invoke_method.invokeStatic(interceptors.clj:364)
      at yada.interceptors$invoke_method.invoke(interceptors.clj:360)
      at manifold.deferred$eval8819$chain___8840.invoke(deferred.clj:862)
      at manifold.deferred$eval8819$chain___8840.doInvoke(deferred.clj:886)
...

How to handle multipart/form-data properly in Yada? Thx.

... all I want to do is get the different parts.

i'm having a weird problem with a DELETE request on yada 1.1.45

if I add the header 'Transfer-encoding: chunked', it responds with a 415 Unsupported media type

the thing is, either our Varnish or Google load balancer adds this header when issueing a non HTTP/2.0 request

any ideas on how to solve this?

ok, I see in yada.interceptors/process-request-body

RFC 7230 section 3.3 states
  "The presence of a message body in a request is signaled by a
  Content-Length or Transfer-Encoding header field. Request message
  framing is independent of method semantics, even if the method does
  not define any use for a message body"

why would a reverse proxy change that header?

and it doesn't do this when sending an HTTP/2 request

@kurt-yagram i've got a pretty complete yada multi-part upload implementation here: https://github.com/MastodonC/kixi.datastore/blob/master/src/kixi/datastore/web_server.clj#L171

it might be a different to what your doing, here i'm streaming uploading files straight to S3

if your just after simple part: https://github.com/MastodonC/kixi.datastore/blob/master/src/kixi/datastore/web_server.clj#L238

the two parts i deal with are defined there (file and file-metadata), if your parts are simple, you might get a way with the default Part implementations and just list your parts like that

@tcoupland Thanks a lot! I did get it working by now, but I still have to clean it up... I'll certainly have a look at your implementation!