Fork me on GitHub
#vim
<
2023-01-09
>
Martynas Maciulevičius10:01:45

My namespaced keyword/symbol highlighting PR was merged (no treesitter, the basic one). Now all of your syntax highlighters will be broken 🔥mr-burns-excellent🔥thisisfine🔥 https://github.com/clojure-vim/clojure.vim/issues/24 This is a colorscheme that I use: https://github.com/Invertisment/srcery-blue-vim And this is the highlighting that clojure.vim now supports with that specific theme:

🎉 2
brandon22:01:28

Nice! It looks like for the colorschemes I use, namespaced keyword tokens aren’t colorized anymore, or they are colorized differently in certain contexts. I’ll add a screenshot. Do my colorschemes need an update in order to colorize these tokens properly?

Martynas Maciulevičius09:01:07

> Do my colorschemes need an update in order to colorize these tokens properly The change is designed so that it wouldn't break the colorschemes too much. I only colored the / by default. You can color :, /, namespace and so on. So yes, you need to change your colorscheme to support it. By default it will only color the / I think this change I dones't color anything by default.. hm. I thought it does. Were you coloring the namespace before? How were you matching it? I think it wasn't implemented at all. Example how to color the namespace: https://github.com/Invertisment/srcery-blue-vim/blob/master/colors/srcery-blue.vim#L968 New matchers:

clojureSymbolNs
clojureSymbolNsSeparator
clojureKeywordNs
clojureKeywordNsSeparator
clojureKeywordNsColon
I didn't use all of the new matchers in that colorscheme but they can be found here: https://github.com/clojure-vim/clojure.vim/blob/06196d8fcfe8ac610f2471b3452bc54c314482a4/syntax/clojure.vim#L74 And here: https://github.com/clojure-vim/clojure.vim/blob/06196d8fcfe8ac610f2471b3452bc54c314482a4/syntax/clojure.vim#L84 Also this PR didn't remove any color scheme keywords so old colorschemes should work without maintenance.