I need a proper uber-build process for my project.

Also the compile is non deterministic. Sometimes it fails, sometimes it doesn't. My suspicion is that the https://github.com/bhauman/devcards/issues/168 no longer works with 2.19.0

(ns frontend.highlight
  (:require ["highlight.js" :as hljs]))

(js/goog.exportSymbol "hljs" hljs)
(js/goog.exportSymbol "DevcardsSyntaxHighlighter" hljs)

;;;

{:ns-aliases {devcards-syntax-highlighter frontend.highlight}

well what does /home/sam/Code/pitch-app/platform/node_modules/highlight.js/lib/languages/isbl.js look like?

as to shadow-js missing. that is only created for :js-provider :shadow (eg. :target :browser) builds that use actual npm dependencies. other targets such as :npm-module or the :node-* variants won't produce this

could just be a somehow corrupted js file?

Getting something fairly similar when updating to 2.19.0

Failed to inspect file                                                                                  
  /home/dan/code/story-builder/node_modules/highlight.js/lib/languages/gml.js                                                                                                                                       
                                                                                                                                                                                                                    
it was required from                                                                                    
  /home/dan/code/story-builder/node_modules/highlight.js/lib/index.js                                                                                                                                               
                                                                                                          
Errors encountered while trying to parse file                                        
  /home/dan/code/story-builder/node_modules/highlight.js/lib/languages/gml.js                                                                                                                                       
  {:line 1, :column 1, :message "The file could not be parsed as JavaScript."}     @

The gml.js doesn't look corrupted

is that the full error? there should be more?

I can't reproduce this locally

what is your build :target? any specific :compiler-options? you sure you have the matching shadow-cljs, cljs, closure-compiler versions?

Try running your compile a few times just to be sure. Like I said it was non-deterministic for me.

:target :karma

was that the full error for you? the error should be longer showing the actual cause?

looks fine

Closure compilation failed with 1 errors
--- node_modules/highlight_DOT_js/lib/languages/python.js:11
Cannot convert ECMASCRIPT_2018 feature "RegExp unicode property escape" to targeted output language.

this error I can reproduce but just requires setting :output-feature-set :es8

(which is the default for :karma so not needed to set it)

ah there you have it

that is a closure compiler error

weird since that should be totally reproducible

unless you have manually reduced the stack size or something?

If you're curious about the file. Only special thing I can see about it is it has some funky unicode chars

https://github.com/google/closure-compiler/issues/1661

that appears to match the source and error trace

but supposedly was fixed a long time ago 😛

There are two workarounds for this issue that I have found:

Break the string concatenation up into multiple statements
Increase JVM stack size, e.g. -Xss8M

dunno why that would break randomly though. stack size is fixed by default IIRC

why are you including this in the first place? do you really need syntax highlighting for isbl? whatever that is 😛

there is also an older https://github.com/thheller/shadow-cljs/issues/780

so looks like this isn't the first time this has come up

The error is deterministic for me. It happens every time

can you try setting :jvm-opts ["-Xss8M"] in shadow-cljs.edn (if you are not using deps.edn or project.clj, otherwise needs to be set there)

just to see if that removes it?

yup, increasing the stack size looks like it fixes it.

so in conclusion the new closure compiler version can't handle large strings in the stack as well as the previous version?

can't say. the error has come up before

can't think of anything else to address this either

https://github.com/google/closure-compiler/issues/3945

Feel free to add any extra info. Maybe someone will notice a regression introduced in the later version which blows up the stack in some edge cases.

Thanks for the help!

which java versions do you use? how much RAM do you have? I can't reproduce this locally in any way but my guess is that java17 with 32gb of ram sort of influences this?

I'd like to avoid a route where I bump the default stack size for every compile thread just because (like the closure compiler is doing)

just to confirm: this is due to you using re-frame-10x right? or do you use highlight.js in any other context?

the easiest fix for all of this is just not loading these highlight.js languages in the first place?

I'm on openJDK 11.0.15, 32GB of ram

I'm just working on a bit of an old app which uses devcards and devcards need to require highlight.js to work with shadow I suppose.

:js-options {:package-overrides {"highlight.js" {"./lib/languages/isbl.js" false}}} would also work to just manually disable that one

I agree this work isn't worth doing just for that, but if more people start reporting problems for other npm libraries, now we know

haven't tested this so it might blow up

but it'll make shadow-cljs just not bundle that file

you could also fix it manually by overriding the cljsjs require and only including the languages you want