emacs 2022-05-18 | Slack Archive

Chris Clark08:05:18

Hey Emacs friends! When I run M-x cider-javadoc on a symbol, it opens up a URL to Java 11 docs. E.g.: https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/net/ServerSocket.html I'm using Java 18 locally, and I'm hoping to make cider-javadoc use URLs for Java 18. E.g.: https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/net/ServerSocket.html I'm having trouble figuring out how, though. Anybody know?

jkxyz08:05:37

It looks like it defaults to Java 11 here: https://github.com/clojure-emacs/orchard/blob/master/src/orchard/java.clj#L384-L385

jkxyz08:05:39

I imagine you need to open a PR to add the Java 18 URL to that map

vemv09:05:37

No, fixing the fallback (L385) is just a workaround. L384 should be working to begin with. Currently it doesn't, next CIDER release will

jkxyz09:05:39

Yes I see there's a map of version numbers to URLs which is what needs updating

vemv09:05:29

L385 most likely should be removed, I'll look into it as I work on related CIDER features asap

Chris Clark10:05:33

Awesome, thanks so much for the help! Adding an item for 18 in the map of javadoc-base-urls does indeed make it work. I'll make a PR for that.

vemv11:05:22

Please don't (as I've already expressed my opinion on the topic), however a comment in https://github.com/clojure-emacs/orchard/issues/160 is welcome Thank you both for bringing the item to attention though!

👍 1

2022-05-18

Channels