Hello, Wondering if anyone can help me with a NodeJS + CLJS setup. I’ve got an app already written in CLJS for the browser, but there’s some code in there I want to share with an already written NodeJS server app. My plan is to separate out the shared code into its own library; using shadow-cljs :node-library target to be able to build a JS version for use on the NodeJS server, and pull the library into the CLJS browser app as a normal CLJS dependency. Does that sound sensible? The next question I have after having trying the above is: when I’m developing this library, how can I get live reloading / REPL based workflow with a :node-library target? I’ve tried running the shadow-cljs watcher in one terminal, calling node ./dist/lib.js and then shadow-cljs cljs-repl lib to connect a CLJS repl but live reload doesn’t seem to pick up changes after file save (but I can get changes if I eval the code changes within the REPL).

@austinbirch live-reload is a bit more restricted in node-library since we can't modify things after they were exported

so live-reload from within CLJS should work but if you the stuff loaded from node can't

but it should work depending on what you do. may need to manually enable it though :devtools {:autoload true}

(if you don't have other hooks configured, eg. :after-load)

Ah, I should have also mentioned that I set :devtools {:autoload true} and had live reloading working with :node-script (but then this isn’t consumable as a npm dependency). Maybe I should just create a :node-script build for development and a :node-library build for release?

I wouldn't recommend that. you want your dev build to be as close as possible to release

otherwise you'll end up debugging release builds endlessly 😛

Yes (been there…!)

but live-reload should work fine in node

just the exports themselves can't be reloaded

is your NodeJS service written in JS?

or CLJS?

I actually might have been testing by updating the exported function, so maybe that’s it. If I export functionA that calls functionB, update functionB and save the file, would you expect that the live reload would run the new functionB?

@lilactown existing project written in JS

yes that should work

I will try now and get back to you. Thanks so much for all the help!

var x = require("your-cljs.js"); x.foo();

the foo can't be updated

since node saves that references internally

but whatever that foo calls internally can be updated normally

Just tried and that’s working perfectly now. Very pleased!

Thanks again for your help.

When I was testing I’m pretty sure I had something like:

(defn exported-fn
  []
  "returning 1")

yeah I tried making the exports dynamic once but it had a bunch of issues so I opted out of that

Makes sense. I better get back to actually writing the code now then 🙂

Can you have browser tests that autorun on changes?

can anyone recommend getting started with https://github.com/minimal-xyz/minimal-shadow-cljs-browser versus the shadow-cljs lein template?

@ccann I recommend https://github.com/shadow-cljs/quickstart-browser

thank you

they are all pretty similar though. so its really up to you

:thumbsup:

I know this isn’t necessarily a beginner forum, but whenever I kill my repls and then restart (via cider-connect-clj&cljs -> shadow -> app) I get Stale Client! in the browser window … which goes away if I hard-refresh the page

@ccann this is absolutely a beginner forum 🙂 unfotrunately I can't help with cider issues as I know nothing about that

stale client is the message you get when you load js that was not compiled by the current watch

it seems to work anyway 🙂

depending on which server you use it may be a cache issue

okay interesting, thanks!

I'm trying to move a figwheel project to shadow, but when I run (server/start!) I get:

Execution error (NoSuchFieldError) at shadow.build.closure.JsInspector/getFileInfo (JsInspector.java:161).
PARSE_RESULTS

@souenzzo likely a bad version of the closure compiler on the classpath

should be [com.google.javascript/closure-compiler-unshaded "v20181125"] or later