In addition to core predicates, predicte-induced typo

fixed, thx

I'm curious to see how the loop/recur inference works, clojure does it but it requires some quadratic number of passes in the worse case

can anybody point me to where it's done?

the predicate inference stuff looks sick, I wanted to play with it in CinC too but never got round to it, congrats to everybody involved to getting it done

@bronsa it's probably different since we just loosen the inferred type

we don't really care about the primitive stuff that Clojure does

ah I see, yeah in clojure it's pretty involved as it completely changes the type inference in interop call s

right we don't need type inference for that

what happens in clojure is that the entire loop body needs to be re-analyzed if a recur point invalidates the inferred type from the loop point

yep

which is what makes the process O(scary)

don't need to do that

cool

types are represented as a set

so we just add whatever else we see

thanks for the info

@bronsa I’d have to re-look at the implementation again, but re-analysis is part of the game. IIRC, it is limited to one re-analysis pass. To address the compiler-perf concern we did some testing…

does that mean double macroexpansion?

Here is the ticket: https://dev.clojure.org/jira/browse/CLJS-2873 Empirically the effect in that test was a speedup of 0.97 when compiling a test corpus of code.

Good question about the macroexpansion :thinking_face:

clojure does macroexpand multiple times

in my tools.analyzer impl I implemented that pass by invalidating the type inference pass in the AST and re-running the pass rather than re-analyzing and re-macroexpanding the loop body

but it makes it a bit more complex

I'll take a look at that patch, thanks

More on the overall perf tests cited in that ticket are at https://github.com/mfikes/cljs-perf/

those look like some really nice incremental improvements, congrats :)

Just found out that you do need to require [clojure.test.check.properties] separately from [clojure.test.check] before using (stest/check), so I think going back to the old error message is better, which means reverting: https://github.com/clojure/clojurescript/commit/90c9a680e3e269a0b5f40cc907d9889d03c8dcbb

Sorry for the inconvenience 😞

I can make a JIRA + PR to the site tomorrow

sure, thanks