I’m trying to get a project building with shadow-cljs, and running into a problem compiling tools.reader:

failed to compile resource: [:shadow.build.classpath/resource "cljs/tools/reader/reader_types.cljs"]
{:tag :shadow.build.compiler/compile-cljs, :source-id [:shadow.build.classpath/resource "cljs/tools/reader/reader_types.cljs"], :url #object[java.net.URL 0x2be3d771 "jar:file:/Users/MattPro/.m2/repository/org/clojure/tools.reader/1.0.5/tools.reader-1.0.5.jar!/cljs/tools/reader/reader_types.cljs"], :file nil, :line 43, :column 1, :source-excerpt {:start-idx 38, :before [";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;" ";; reader deftypes" ";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;" ""], :line "(deftype StringReader", :after ["    [s s-len ^:mutable s-pos]" "  Reader" "  (read-char [reader]" "    (when (> s-len s-pos)" "      (let [r (.charAt s s-pos)]"]}}
ExceptionInfo: failed to compile resource: [:shadow.build.classpath/resource "cljs/tools/reader/reader_types.cljs"]
...
Caused by:
ClassCastException: clojure.lang.PersistentArrayMap cannot be cast to java.lang.String
	clojure.core/symbol (core.clj:579)
	clojure.core/symbol (core.clj:574)
	cljs.analyzer/dep-has-global-exports? (analyzer.cljc:763)
	cljs.analyzer/dep-has-global-exports? (analyzer.cljc:759)

full stacktrace: https://gist.github.com/mhuebert/ea628936b0bccd8c3890c8ef4867880d

in shadow.cljs is [org.clojure/tools.reader "1.0.5"]

shadow-cljs version 2.0.6

@mhuebert very confusing error, not sure how it ends up on that path. it compiles fine for me. might be a case of broken metadata which causes it to report the wrong location. will look into it

no idea what could cause this.

just released 2.0.7 which bumps the clj(s) versions, should not affect that error but who knows

@thheller is there any equivalent of lein clean to try in a case like this?

other than just removing the out directory

tried with 2.0.7 and deleted tools.reader from my repository (to fetch again) and deleted the target folder. same error, but much nicer formatting. agree it is very weird.

File: nil
--------------------------------------------------------------------------------
...
  42 |
  43 | (deftype StringReader
-------^------------------------------------------------------------------------
  44 |     [s s-len ^:mutable s-pos]
  ...
--------------------------------------------------------------------------------
ClassCastException: clojure.lang.PersistentArrayMap cannot be cast to java.lang.String
	clojure.core/symbol (core.clj:579)
	clojure.core/symbol (core.clj:574)
	cljs.analyzer/dep-has-global-exports? (analyzer.cljc:763)

i believe i require these as clojure.tools.reader (w/o reader conditionals), could the aliasing have anything to do with it?

I fixed the error format, guess I missed the File: nil 😉

shouldn’t have anything to do with the aliasing but might

I’ll check that

after switching all the tools.reader requires to reader conditionals, I get a different error, related to “cljs.repl” and ‘Unable to find static field: INFERRED_CONST_CHECKS’, full stacktrace: https://gist.github.com/mhuebert/263433cd01df6053f237d9671c3c6e41

[clojure.tools.reader.reader-types :as read]

hmm weird, do you import cljs.closure somewhere?

I made sure to never import that anywhere

do you use shadow-cljs standalone or embedded in lein or boot?

ah wait cljs.repl requires cljs.closure

standalone

the weird thing is that I can compile everything just fine

maybe some weird AOT artifact

can you delete target/shadow-cljs completely and restart the shadow-cljs process?

have you tried compiling with a require to `[clojure.tools.reader.reader-types] (instead of cljs.tools.reader)?

[clojure.tools.reader.reader-types :as read]
            [cljs.repl :as r]

tried deleting target & recompile, same thing

compiled just fine

what are your :dependencies? maybe there is an old version of closure in there somehow?

try starting shadow-cljs clj-repl and then (require 'cljs.repl)

that should not fail

does shadow-cljs have a way to print the dep tree

shadow-cljs --cli-info

so that fails for me

not a proper tree but it lists dependencies

the repl

mattpro:editor MattPro$ shadow-cljs clj-repl
shadow-cljs - config: /Users/MattPro/Documents/sites2017/maria/editor/shadow-cljs.edn version: 2.0.7
shadow-cljs - starting ...
WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.tools.analyzer.utils, being replaced by: #'clojure.tools.analyzer.utils/boolean?
WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.tools.analyzer, being replaced by: #'clojure.tools.analyzer.utils/boolean?
shadow-cljs - server running at 
shadow-cljs - socket repl running at localhost:62834
shadow-cljs - nrepl running at localhost/127.0.0.1:62836
shadow-cljs - REPL - see (help), :repl/quit to exit
[1:0]~shadow.user=> (require 'cljs.repl)
CompilerException java.lang.RuntimeException: Unable to find static field: INFERRED_CONST_CHECKS in class com.google.javascript.jscomp.DiagnosticGroups, compiling:(cljs/closure.clj:100:1)

what the heck … those boolean? warnings shouldn’t be there

in .lein/profiles.clj i have [lein-count "1.0.2"] [lein-clojars "0.9.1"] [lein-release "1.0.6"]

[zilence@zpro ~/code/tmp/weird]$ shadow-cljs init
shadow-cljs - init
- /Users/zilence/code/tmp/weird/shadow-cljs.edn
Create? [y/n]: y
shadow-cljs - created default configuration
[zilence@zpro ~/code/tmp/weird]$
[zilence@zpro ~/code/tmp/weird]$ shadow-cljs clj-repl
shadow-cljs - config: /Users/zilence/code/tmp/weird/shadow-cljs.edn version: 2.0.7
shadow-cljs - updating dependencies
Retrieving thheller/shadow-cljs/2.0.7/shadow-cljs-2.0.7.pom from 
Retrieving thheller/shadow-cljs/2.0.7/shadow-cljs-2.0.7.jar from 
shadow-cljs - dependencies updated
shadow-cljs - re-building aot cache on startup, that will take some time.
shadow-cljs - starting ...
shadow-cljs - server running at 
shadow-cljs - socket repl running at localhost:52062
shadow-cljs - nrepl running at localhost/127.0.0.1:52064
shadow-cljs - REPL - see (help), :repl/quit to exit
[1:0]~shadow.user=> (require 'cljs.repl)
nil
[1:0]~shadow.user=>

thats how it supposed to look

those boolean? warnings appear on my system no matter what tooling i use, and am unsure of why, even if i comment everything out in .lein/profiles

.lein/profiles doesn’t affect shadow-cljs

can you paste shadow-cljs --cli-info?

only thing I can think of is deps conflict

cli-info: https://gist.github.com/mhuebert/92187cd721d5c2fbf23df158f60673d2

[maven] org/clojure/clojurescript/1.9.854/clojurescript-1.9.854.jar how does that get there

do you have it in :dependencies?

yes

sorry i was going to paste that earlier.

please remove that. forgot to guard against that.

ah ok. i had an error with the clojure dependency but not cljs, hence i thought cljs was required

its fine in theory but there were some breaking changes in CLJS+Closure recently

[1:0]~shadow.user=> (require 'cljs.repl)
CompilerException java.lang.RuntimeException: No such var: util/normalize-path, compiling:(cljs/closure.clj:1601:22)

that might be AOT now

delete target/shadow-cljs just to be safe

ok i’ll clear it out

i still wonder why i get these WARNING‘s about boolean?.

🎉

ok requiring ‘cljs.repl works now

going to try compiling the project again

cljs/core.cljs [line 988, col 14] No reader function for tag Inf.
{:type :reader-exception, :ex-kind :reader-error, :file "cljs/core.cljs", :line 988, :col 14}
ExceptionInfo: cljs/core.cljs [line 988, col 14] No reader function for tag Inf.

hmm maybe tools.reader in your :dependencies still?

I really need to make the whole dependencies resolution more robust

is the latest tools.reader included automatically? i need it for my app

yes

CLJS always ships with tools.reader

1.1.0 is the latest version that fixes the Inf issue above

ah ok, i need to remove it from a bunch of things in my project then

ok the problem is that shadow-cljs already depends on those things but if you declare them in :dependencies they overwrite the version that shadow-cljs wants

I need to fix that or at least warn

so shadow-cljs will ignore the project.clj in the current directory but still use the deps listed in the dependencies

somewhere i have tools.reader-1.0.3 in clj-info

shadow-cljs does not use lein in any way unless you tell it to

so project.clj might as well not exist

deps only whats listed in :dependencies in shadow-cljs.edn

i mean transitive deps

Not sure what you mean? it uses the same lib that lein uses to resolve dependencies, so the same rules apply

in theory the tools.reader dep of shadow-cljs should be chosen since its 1.1.0

i mean somewhere in a transitive dependency of my project, an old version of tools.reader is included, [maven] org/clojure/tools.reader/1.0.3/tools.reader-1.0.3.jar

it shows up when i run --cli-info and I am guessing that’s why i am still getting the Inf error

ah ok. yes thats the source of the Inf error

but i am not sure yet where it is being included

can you give me your :dependencies so I can track this down properly?

i have a bunch of local libs unfortunately which might make that complicated because i’ve been makign changes to them during this debugging process so there are a bunch of undeployed snapshots

is there a way to see a tree of dependencies / see where a particular dep is coming from?

ah ok, you could try lein deps :tree if you have a project.clj anyways

no but I will definitely add the tree visualizer, the flat list is kinda useless

easy fix would be to just add [org.clojure/tools.reader "1.1.0"] to your deps (I think)

so the only place 1.0.3 from tools.reader exists is in cljs 1.9.854

which is listed in several project.clj‘s of my dependencies

does it still list 1.9.854 in --cli-info?

I might be wrong in my understanding of how maven resolves dependency conflicts

no, it lists 1.9.946

but i added [org.clojure/tools.reader "1.1.0"] to shadow-cljs.edn

btw libraries should always use [org.clojure/clojurescript "1.9.854" :scope :provided]

and that didn’t change

ah ok, i didn’t know that

try deleting the AOT cache

I’m regretting a bit that I relaxed the AOT compiler to only recompile when the shadow-cljs version changes

mistakingly assumed that would be enough 😛

maybe whenever deps change

it was whenever deps changed but it doesn’t really need to re-compile AOT when you change the version of a CLJS lib

i like how fast shadow-cljs usually give me feedback. more errors, earlier, than other tools i’ve used

I don’t like that the errors are so hard to track though 😉

ok, it is building, just a warning from transit

------ WARNING #1 --------------------------------------------------------------
 File: :332:1
--------------------------------------------------------------------------------
 328 |   "Construct a URI from a string."
 329 |   [s]
 330 |   (ty/uri s))
 331 |
 332 | (defn uri?
-------^------------------------------------------------------------------------
 uri? already refers to: cljs.core/uri? being replaced by: cognitect.transit/uri?
--------------------------------------------------------------------------------
 333 |   "Returns true if x is a transit URI value, false otherwise."
 334 |   [x]
 335 |   (ty/isURI x))
 336 |
 337 | (defn uuid
--------------------------------------------------------------------------------

old transit version probably 😛

why the heck is File: always empty, I need to fix that

ah found it

ah.. goog.require could not find: cljs.core$macros

maybe this is related to self-host stuff

yeah I still didn’t get to that

not the slightest idea how self host works

ok

what do you use it for?

https://www.maria.cloud, an editor environment

cool

let me check, maybe its just a property I forgot to set

so in the existing (non-shadow) build, window.cljs.core$macros is there, missing here

https://github.com/clojure/clojurescript/blob/300e326b83ba4110657bb646a9d396c5cb666501/src/main/clojure/cljs/closure.clj#L690

yeah I don’t compile the self hosted stuff properly

that just adds the dep, need to find where it compiles the macros

(ns cljs.js
  (:refer-clojure :exclude [require])
  (:require-macros [cljs.js :refer [dump-core]]
                   [cljs.env.macros :as env])
  (:require [clojure.string :as string]
            [clojure.walk :as walk]
            [cljs.env :as env]
            [cljs.spec.alpha]
            [cljs.analyzer :as ana]
            [cljs.compiler :as comp]
            [cljs.tools.reader :as r]
            [cljs.tools.reader.reader-types :as rt]
            [cljs.tagged-literals :as tags]
            [goog.crypt.base64 :as base64]
            [cljs.source-map :as sm])
  (:import [goog.string StringBuffer]))

(js/goog.require "cljs.core$macros")

this is just plain weird 😛

last time I talked to dnolen about this he said that core$macros are handled as a special case, other macro files are not compiled, you have to provide them manually (which is a big PITA)

and yes, weird!

still trying to figure out where exactly it gets compiled, there a whole lot of special cases for cljs.core$macros

had hoped for a cljs.compiler.api/compile-macro-ns or so 🙂

yeah! that would be nice. there is the jira issue: https://dev.clojure.org/jira/browse/CLJS-2270

so there is openness to improving it

Not enough time but I will look into it later today https://github.com/thheller/shadow-cljs/issues/103

It should not be hard, found a :macro-ns option that seems to control it

just a bunch of special cases in the code I don’t quite understand yet

ok. i realize this may be a messy thing. if we can get it working i would be very happy to use shadow-cljs for all of Maria’s builds, i really prefer it in the small cases i’ve tried

I definitely want to support this use case. It just scares me since I don’t really understand how self host works 🙂

plus i could probably use shadow-cljs to do the AOT macro compiles 🙂

makes my head hurt just thinking about it 🙂

if I figure out how to compile cljs.core it should be easy to extend it to others as well

yeah, this stuff is annoying.

Feedback from my tests, definitively shadow is nice for node + electron... perhaps doc 😉 need help ?

I looked on the lumo integration as repl, seems tedious. I have to look more on the whole ecosystem... coming from clojure.... 😉

But I have to put it on wheels with boot and lein. Big problems with boot pods that wipe the whole directory, hard to put your main.js in root of the project... well, not hard, but you loose the whole thing after compile 😄

@ivanpierre there has been some discussion about lumo repl integration in the lumo channel...I am very fond of the Language Server Protocol for that also seeing it is now supported everywhere but I haven't got around to doing it

@mhuebert can you give a minimal example cljs.js snippet so I can test if it works?

I have never used it before and don’t know how to verify if the macro compile worked

nevermind found one

sorry just saw this now