What's the current deal with inadvertently returning false from event handlers? Does re-frame handle that for me?

@mbertheau In what context would you accidentally return false? In my experience accidentally returning nil is more common. When using reg-event-fx returning nil simply means 'no effects' and works fine.

@curlyfry I mean for example an :on-click function

@mbertheau usually the only thing you will do in on-click is call a reframe dispatch

and reframe dispatches return nil, so you don't have to worry

https://github.com/Day8/re-frame/blob/master/src/re_frame/router.cljc#L229-L244

Discussed here https://github.com/Day8/re-frame/wiki/Beware-Returning-False

I liked being able to return false to stop event propagation to be honest.

@mikethompson @danielcompton @daiyi I updated the PR with a link to a build of docs on my local gh-pages, it gives you an idea about how the docs would be https://github.com/Day8/re-frame/pull/414#issuecomment-331123497

I’m trying to figure out a way to css animate element of the list before it gets removed by an event handler and nothing comes to my mind except dispatching an event [:item/hide id] that will change its class and then dispatching another [:item/delete id], say 300ms later by using js/setTimeout. This feels too inelegant. Is there another way?

I can’t help with the overall elegance of the problem but instead of using js/setTimeout directly just use the :dispatch-later effect

Whoa. @sandbags. That’s… awesome… despite the fact that I totally do not even comprehend any of it… Wow… Haha. My first reaction was, “Wow, cool!” My second reaction was, “What does that do?“. My third reaction was, “No wonder my attempt didn’t work — doesn’t look anything like that.” 🙂 Where do I go learn what :<- is?

@genekim Best place is in the todomvc example source code docs (weird … I know) https://github.com/Day8/re-frame/blob/master/examples/todomvc/src/todomvc/subs.cljs#L30

Theres a good amount in the docstring for reg-sub too https://github.com/Day8/re-frame/blob/master/src/re_frame/subs.cljc#L176-L261

Oooh… Cool… Thank you @kasuko!

thanks @kasuko didn’t know about :dispatch-later

@nooga you can use ReactCSSTransitionGroup

https://github.com/reagent-project/reagent-cookbook/tree/master/recipes/ReactCSSTransitionGroup

which, I think, does sort of the same thing, only based on extra lifecyle hooks of react elements

(I’ve used it with some success)

thx

@nooga my usage is here. Pardon the horrendous code and the usage of create-class, that is because of a different concern which could probably be handled more nicely. But the transitionGroup does work 🙂

https://github.com/Reefersleep/sleepydo/blob/master/src/sleepydo/core.cljs

@nooga in https://github.com/Day8/re-frame/blob/master/docs/External-Resources.md look at link for animation