Fork me on GitHub
#om
<
2019-02-04
>
Karol Wójcik15:02:23

What are your opinions about React.Fragment. It seems that it would be quite easy to add direct support for Fragment in om.dom using createElement function. It also seems that it will no be a breaking change :D

Karol Wójcik15:02:33

Is it worth adding?

wilkerlucio15:02:59

@kwcharllie379 I guess the reason for om.next not having is just because nobody is sending new code for it, in Fulcro we did add on the primitives (since its not a DOM specific thing, works the same on RN), using it should be easy, you can take a look at the Fulcro impl: https://github.com/fulcrologic/fulcro/blob/8792813a1304f73a912e21a0945402055a8f9795/src/main/fulcro/client/primitives.cljc#L658

👍 1
danielstockton15:02:52

I would definitely like to see it in om.next, it can be useful sometimes.

Karol Wójcik15:02:38

The question is whether the author is interested in that change.

Karol Wójcik15:02:58

Yes @wilkerlucio it seems quite easy to even add that function on one own. But I would rather have it in om.next

wilkerlucio15:02:32

@kwcharllie379 AFAIK the author has no interest in maintaining it, in the past 2 years om.next only got updates from the author when some new cljs made it unusable because of some breaking change, other than that nothing had happened and I believe it will keep that way

Karol Wójcik15:02:01

I will try to create pr. We will see :D

👍 2