Fork me on GitHub
#nbb
<
2022-06-10
>
cldwalker14:06:01

Experience report: Converted about 2k loc cljs to be nbb compatible (actually nbb-logseq compatible) - https://github.com/logseq/logseq/tree/master/deps . Overall, the conversion was smooth. The only code that was forced to differ from cljs was default requires for npm libs like https://github.com/logseq/logseq/blob/23e46588b35d85461e93ac470fbb87f16818d45a/deps/graph-parser/src/logseq/graph_parser/mldoc.cljc#L5-L6. Since we are on a fast moving codebase, nbb compatibility could accidentally break so we have a linting task to prevent that - https://github.com/logseq/bb-tasks/blob/main/src/logseq/bb_tasks/nbb/test.clj

borkdude15:06:15

Thanks for the experience report!

👍 2
cldwalker17:06:40

Forgot to mention that https://github.com/logseq/logseq/tree/master/deps/graph-parser/test/logseq contains a test suite that runs on cljs and nbb with no difference between the two

👍 1