lsp 2022-09-29 | Slack Archive

snoe17:09:47

I was checking out the performance on master (seems good so far) but I noticed that I no longer get proper analysis from jar files. Jump to def and hover find nothing. Anyone else notice this?

👍 1

Noah Bogart18:09:54

Same here

ericdallo19:09:27

only on master ? latest release does work for you?

snoe20:09:29

2022.09.01-15.27.31 works

ericdallo20:09:04

oh, I made some changes for supporting lsp-java when finding definition of a java class. Maybe this was introduced on https://github.com/clojure-lsp/clojure-lsp/commit/d3575d9101652107f6242e809fb2d06f48ccafc1, could you confirm @U0BUV7XSA?

👀 1

ericdallo20:09:57

2 things were made since latest release: • that fix for zipfile • supporting decompile whole jar when finding definition, adding support to use lsp-java Maybe the first one added some new issue where it was supposed to fix it 😂

snoe20:09:26

did the file v uri change make it in too? that was my suspect

ericdallo20:09:16

yes, was a @U07M2C8TT’s PR we merged since latest release too

snoe20:09:40

@UKFSJSM38 that commit seems to be working still

ericdallo20:09:02

Hum, so maybe it was the file vs uri change indeed

snoe20:09:02

(sorry I probably don't have time for a full bisect)

ericdallo20:09:30

This was the pr which changed uri vs filepath: https://github.com/clojure-lsp/clojure-lsp/pull/1231

👀 1

jacob.maine20:09:26

I noticed something like this but then couldn't reproduce it. I've been jumping around between old branches a lot though. Definitely needs a GitHub issue

snoe20:09:28

a4a44f55 passed (which came after the filepath uri, so something more recent still is the problem)

snoe17:09:56

https://github.com/clojure-lsp/clojure-lsp/issues/1287

ericdallo17:09:18

@U0BUV7XSA when you say inside a jar you mean in a clojure file insisde a jar file not a java one, right?

snoe17:09:31

yes

👍 1

ericdallo17:09:18

is it possible to append server logs and client <-> server logs when inside the jar to check what is missing? I can't test it easily since emacs uses jar and not zipfile :/

snoe17:09:59

is it working ok in emacs?

snoe17:09:57

added logs to the issue, not much to see though.

ericdallo17:09:18

yes, working on emacs, thanks! will take a look soon

snoe17:09:49

maybe it's possible to write an integration test that jumps into clojure.core?

ericdallo17:09:03

yes, sounds like a good case for integration-test!

Stefan T19:09:55

Is it possible to run the clean ns form command without reformatting :refers? I've tried disabling this with {:clean {:sort {:refer nil}}} but this only seems to disable the sorting, which does make sense but is somewhat confusing since this does configure the :max-line-length options.

Stefan T19:09:33

I've also got :document-formatting? and :document-range-formatting? disabled.

ericdallo19:09:52

hum, that is the way to stop touching refers, do you have a minimal repro?

Stefan T19:09:53

Sure, I let me put one together. Another thing I noticed, possibly not related, :clean :after-ns-refactor doesn't appear to do anything. That is, clean-ns-form no longer runs after ns refactor commands like auto-import. Works fine if I run it manually. TBH I wanted to disable that, but I couldn't figure out how to make it work. I'm on Calva running the nightly build right now.

ericdallo19:09:24

you meant :clean :automatically-after-ns-refactor right?

ericdallo19:09:45

ops, the docs are wrong, the correct is: :clean :automatically-after-ns-refactor

ericdallo19:09:49

will fix it right now

Stefan T19:09:17

Aaaah ok

Stefan T19:09:42

Is this feature disabled by default?

ericdallo19:09:54

it's true by default