it's a valid idea but not sure would be easy to implement since the code is already compiled

the format on this built-in script being is calling during compilation, so it's not dynamic code being executed

if user provide custom clojure-code, how we would run that on a running clojure procces (specially graalvm one)

So if defn- snipped was not buit-in, then the following snippet would not work

{:name "defn-"
  :detail "Create private function"
  :snippet (format "(defn%s ${1:name} [$2]\n  ${0:body})"
                   (if (:use-metadata-for-privacy? settings)
                     " ^:private"
                     "-"))}

Ah, its because clojure-lsp is compiled by Graal... I forgot that 🙂

yes, that wouldn't work

So if there was a useful case for including a bit of Clojure code, I should submit a PR to add a built-in snippet and then it would work (assuming the snippet pr is approved)

I think a feature to add custom clojure would be great, I just have no idea how we could achieve that 😅 , feel free to start with a issue where we can discuss the problem and ways to solve it

I'll try and think of some more snippets that would benefit from custom code. I'm just writing a blog and migrating my yasnippets snippets at the moment. I'll raise an issue later today. Thank you.

awesome, thanks!

this looks nice. should this be working in vscode/calva? haven’t seen any of the snippets yet and they don’t show up in the “insert snippet” command we were talking about adding something similar into calva, but helping with LSP would make more sense if the “custom clojure” part can work out somehow

Clojure-lsp already have a lot of snippets via completion https://clojure-lsp.io/features/#snippets

yeah I just saw those for the first time. My question is: does this work in calva out of the box? it seems to be broken for me

It follows the LSP completion snippet spec, so it should work OOTB AFAIK

so I’d just type in defn- hit ctrl+space and should see a snippet in my autocompletions? than its broken.

2022-01-16T16:33:21.967Z  DEBUG [clojure-lsp.server:?] - :codeAction 49ms
2022-01-16T16:33:27.329Z  DEBUG [clojure-lsp.server:?] - :completion 171ms
2022-01-16T16:33:27.396Z  DEBUG [clojure-lsp.server:?] - :resolveCompletionItem 42ms

Maybe calva should opt-in something on vscode API? Not sure, maybe @U9A1RLFNV may know more about it

Double check if client(calva) send the the completionSnippet support: https://microsoft.github.io/language-server-protocol/specification#textDocument_completion

yeah maybe, I’ll look into it more. was just wondering if my install is broken or if it never worked

you can check that on initialize request log on calva

thank you, i’ll check

yeah there seems to be no integration for this in calva unless I’m blind, but I also checked in source. Am I missing something @U0ETXRFEW?

If there is anything about that integration with lsp, should be on lsp/main on calva IIRC

maybe there is a missing opt-in that need to be done on calva side, like adda supportSnippets somewhere via the VScode lsp api

That sounds likely ^

@U02EMBDU2JU Feel free to create an issue for this. A PR is welcome too.

thanks @U9A1RLFNV, I’ll do that. just wanted to make sure its actually a missing link not a bug in something that should already work:)

puh finally got around to creating a ticket at least: https://github.com/BetterThanTomorrow/calva/issues/1483