Fork me on GitHub
#fulcro
<
2020-06-10
>
zilti13:06:55

The parameters sent back to the client mutation's ok-action contain the :outgoing-request under the :result key

tvaughan16:06:13

Is a route-segement with more than two items, like :route-segment ["drawing" :drawing/id "view"], valid? This produces /drawing/:drawing/id/39d38f08-4255-410d-93c8-4ace2209fb06. This does work when there are just two items, like :route-segment ["view-drawing" :drawing/id]

tony.kay18:06:55

@tvaughan don’t remember, to be honest

tony.kay18:06:42

in that I don’t remember if there is a real limitation necessary, or if misbehavior would be a bug

tony.kay18:06:31

I see no problem with it on the surface, and would lean towards “it should work”…but you have to run through the nesting cases. What if someone started with a parameter? IF two siblings did that matching could get difficult

tony.kay18:06:31

so route segments need to start with a solid string, and a trailing string really strains the possible problems with route matching. I would recommend making the 3rd a parameter if that really needs to vary, instead of trying to make route matching figure it out

grant18:06:00

@tony.kay, you mentioned yesterday that you could use query-inclusion on a report to get extra data for controls. I thought query-inclusion only worked for forms, fo/query-inclusion. There is ro/row-query-inclusion, that solves the problem for row controls. What if I want to get additional data to a report level control like “Add Item”? Should there be a ro/query-inclusion too?

tony.kay18:06:48

report level controls are what ro/controls are about

tony.kay18:06:26

ah, but you’re saying you want the report to get that data from where? There is no query for the report, only the rows

grant18:06:47

Yup. 🙂

tony.kay18:06:19

ah, ok, so you want like link-level queries and such. Sure, thats fine. Send a PR. Add an option to report-options, and then tweak the macro. It’s straightforward.

🙏 1
tony.kay21:06:22

the types of elements allowed in f-r-sui right now are anything that is in the deps, which includes SUI react.

tony.kay21:06:06

I’m considering adding one or two more deps, like react-number-format , which I find handy for a number of fields and use in my own projects…but I’m torn on that in the lib

tony.kay21:06:43

and it’s easy enough to just add your own per project…they are pretty darn simple to make

dvingo22:06:14

PSA, new version of shadow-cljs is out with improved inspect support: https://clojureverse.org/t/status-update-inspect-cljs-eval/6074

👍 2