Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2022-05-31

Channels

#cursive
<
2022-05-31
>
imre08:05:38

@cfleming I was thinking would it be feasible to treat paths of :local/root deps (direct and transitive alike) that resolve to within the intellij project as source roots as opposed to library roots?

cfleming10:05:23

@U08BJGV6E I commented over there - I’m instinctively reluctant, but I haven’t really thought it through.

cfleming10:05:37

Every time I go back to that issue I have to refresh my memory of how Polylith works, so it takes me a while to get back into it. Real world cache invalidation!

imre10:05:07

Thanks for that. My suggestion isn't polylith-specific, really (I'd prefer a general solution anyway). I'll review what you wrote there and see if I can support the idea a bit more. This should solve the polylith problem in a general way I think.

cfleming10:05:20

Thanks, if you think it’ll support polylith in a general way I’m all ears!

imre10:05:37

It should support any monorepo project that builds on local root deps

imre16:05:41

I've added a new demo case there that isn't polylith and could benefit from the same change.

imre05:06:11

Does that make sense, @cfleming?

cfleming10:06:22

@U08BJGV6E I'm super busy with non-work stuff, I haven't had a chance to think it through, sorry. I'll definitely look at it, though.

imre10:06:44

No worries and thanks for replying. I just didn't want it to be forgotten 🙂 Do you mind if I check back in a few weeks if there isn't any activity on it by then?

cfleming10:06:38

Not at all!

imre10:06:34

thanks Colin, good luck with nonwork stuff :)

imre08:06:57

Hey @cfleming, have you by any chance had time to check my suggestion there?

cfleming01:06:40

Hey @U08BJGV6E, no I haven't, but I haven't forgotten about it either!

imre13:06:22

Thanks, I'll check back in another few weeks then 🙂

cfleming03:06:14

I'll be back from vacation by then and will care more 🙂

🌴 1
imre07:07:02

Hey @cfleming, I thought I’d ping you again about this. Hope you had a good time off

chrisbroome14:05:51

quick question/comment: i think i found a bug in the way that the cursive repl outputs long strings that have a backslash following by the letter n: here's my input form: 

{:path "C:\\some-really-long-path\\that-would-make-the-string-wrap\\and-is-followed-by-a-part-that-starts-with-the-letter-n\\new.txt"}
but the output when evaluated looks like this: 
{:path "C:\\some-really-long-path\\that-would-make-the-string-wrap\\and-is-followed-by-a-part-that-starts-with-the-letter-n\
        ew.txt"}

chrisbroome14:05:01

I think it has to do with line wrapping - strings over 120 characters exhibit the bug, but strings under that length do not

chrisbroome14:05:00

Hmm... it doesn't do it if Split and align multi-line strings isn't checked... Not sure if that's a Cursive thing or not - this is under the Languages & Frameworks -> Clojure section in Preferences

cfleming07:06:47

Hmm, that looks like a bug, looks like it’s incorrectly treating that \n as a newline. Could you file an issue for that, please?

👍 1