Sorry to come in with such a newbie question, but would anyone please know why I would have references to window and document when I generate .js files with the compiler option set to :nodejs?

if the CLJS code includes references to window or document, they will not be removed

the :nodejs target for shadow-cljs simply does some extra work for you to optimize it correctly for Node.js. It won’t remove code that won’t work in Node.js

Anything else?

This is code that was in separate .clj and .cljs files. I already bring the code in as a library. But it needed an update, so in the process I decided to merge them into a .cljc file (The two original files were almost the same anyway). But now I can’t run the test, because when I try it tells me that I have references to document and window 

You can maybe compile with :optimizations :none, :pretty-print true and then grep the output for references to window or document.

I’ve usually found it straightforward to translate from js to cljs with those settings.

@quoll actually, did you by chance change the optimization level for your code? IIRC some of the optimizations will attempt to write a script tag to the dom.

I’m not sure what you mean by “translate from JS to cljs”. Do you mean, so that I can find the code that generated the reference?

yes, exactly

OK… I was AFK for a bit (and responding via my phone), but I’m back now

:optimizations :none is a bit difficult:

Assert failed: :nodejs target with :none optimizations requires a :main entry
(not (and (= target :nodejs) (= optimizations :none) (not (contains? opts :main))))

This is the code that’s reported (reformated by hand):

goog.testing.TestCase.prototype.getName = function() { return this.name_ };
goog.testing.TestCase.maxRunTime = 200;
goog.testing.TestCase.protectedSetTimeout_ = goog.global.setTimeout;
goog.testing.TestCase.protectedClearTimeout_ = goog.global.clearTimeout;
goog.testing.TestCase.protectedDate_ = Date;
goog.testing.TestCase.protectedPerformance_ = window.performance && window.performance.now ? performance : null;
goog.testing.TestCase.currentTestName = null;

hmm… :thinking_face:

well I got nothing for that :feelsbad:

OK… I’m seeing what has happened.

I think 🙂

The original code was all .clj. To make it compatible with ClojureScript, he copied the file to .cljs and modified it. (so far, so good)

But then he wrote a complete different set of tests for it.

In my process of merging the .clj and .cljs files, into a single .cljc I had also hoped to merge the tests.

But I thought I would check that my .cljc file would work with the existing test first

That’s what I’m trying to do, and that’s what fails for me

I just looked at this .cljs test file, and I see that he has incorporated: (:import [goog.testing TestRunner TestCase])

The code then creates these objects:

(def tr (TestRunner.))
(def test (TestCase. "The Project"))

(defn test-always []
  (parser-result? 5 (p/always 5) "")
  (parser-result? 5 (p/always 5) "abc"))

(.add test (TestCase.Test. "test-always" test-always))

(defn test-nxt []
  (parser-result? 5 (p/nxt (p/always 3)
                           (p/always 5)) ""))

(.add test (TestCase.Test. "test-nxt" test-nxt))

ah ok, yeah I was thinking, “surely cljs doesn’t depend on something that can’t be ported to node”

So it looks like the reliance on TestCase is bringing in these references

right, can that be ported to vanilla cljs.test?

i.e. I’m going to throw away the .cljs test file and port the .clj file into .cljc

there are already vanilla tests that use clj.test so it should be OK

I just caused myself grief by trying to make it work along the way. (I’m thinking that if I check the library out clean, then the ClojureScript tests still don’t work. I forgot to check them clean)

Can defs be marked for running by the compiler? e.g. statically run this

(def v1 {:key :val})
(def v2 {:key2 :val2})

(def v3 (merge v1 v2))

I'd like to have the compiler replace the merge with {:key :val :key2 :val2} by running the code during compilation. I have a large cljs app that's beginning to slow down from some more complex code in defs like this

Anyone have suggestions on what to read and where to start for deploying CLJS to AWS Lambda?

How can i write serialized java objects into a file and read them back into java objects in clojure? any serialization library for this?

you can just use Java serialization via Java interop

you can find some basic code in the Clojure test suite https://github.com/clojure/clojure/blob/master/test/clojure/test_clojure/serialization.clj#L12-L30

that doesn't handle the file part, but that's just a matter of layering in a FileInputStream / FileOutputStream in the chain

@cmcfarlen right, maybe there's a way to exclude those nses, but I don't know how to do that - none of the various things I tried work. AOT compilation in Clojure basically transitively compiles everything you need. Far as I know you can't link together independently AOTed things - or it's just outside of my experience how to accomplish that.

your other option is to just avoid the AOTed ClojureScript dep, this means a longer startup time - but if your workflow is heavily REPL driven then maybe that doesn't matter for you

we provide a sources dep

Just received this warning from the cljs compiler: "cljs.core//, all arguments must be numbers, got [cljs.core/LazySeq number] instead". I instantly knew what was wrong. So freaking cool. Thank you guys for the awesome type inference work!!

@dnolen Thanks for the info. I was not aware of the source cljs dep. We'll look at using that or adjusting our workflow to separate out the cljs dep.