has anyone used the xlink:href attribute with sablono? having issues with it working correctly

perhaps i should try om.dom

current strategy looks like

[:div {:class "menu"}
                 [:button
                  [:svg {:class "settings icon"}
                   [:use {"xlink:href" "#settings-icon"}]]]]

which isn’t working

oh, if you do xlinkHref its supported in React 0.14 but can use dangerouslySetInnerHTML for now

sorry, answered for myself

looks like om.next should have 0.14

hello

@bhauman: I only just noticed that you had replied re: ranges in Reagent now. Why is it that you propose that ranges probably shouldn't be controlled components? I mean, is there more to it than "it doesn't work properly currently"?

@sander: seems the latest cljs.jar 1.7.145 solves this problem.

cool

@blissdev: this might be relevant https://groups.google.com/d/topic/reagent-project/PMZPUy5yBCc/discussion

hi, is there a way to get all members and attributes of a js object?

@rbrtzbl: see the goog.object Closure namespace

thanks

@dnolen: I have rather weird question, but I'm not sure where to dig... So I have this server-side rendered app in React, and when I have a dev build, everything works just fine. But when I build an advanced minified version, running it with node spits out 'React is not defined'. Any pointers maybe how can I find out what's the problem?

@asolovyov: there’s a known bug with :main + :advanced and :foreign-libs that was filed by @maria

if it’s not the same issue then likely something with :advanced and Node.js that hasn’t been encountered before

:advanced w/ Node.js isn’t something we actively recommend or support

hm, let me look at that bug...

oh

should I use :simple for node?

hah, simple also fails!

are you using :main?

yes...

then that’s the bug

ok

@asolovyov: https://github.com/clojure/clojurescript/commit/a4d6a241cd9d45bf0356809c18df14585befd68f

just applied @maria’s patch

@dnolen: that's not my bug!

actually, React is included and it seems the problem is triggered somewhere inside of it

ah hmm then I don’t know without more information

minimal case, ticket etc.

http://paste.in.ua/713/

yeah, that's what hard, I'm not exactly sure how to get to that

@dnolen: what do you think, is running :none on nodejs in production somehow bad?

I can’t think of anything bad about that

you might want to compile with :static-fns true if you care about perf

ok thanks

you probably want :optimize-constants in a production build

makes sense!

@thheller: thanks!

@dnolen your last om commit contains a bug

https://github.com/omcljs/om/commit/f33977ab87053ba61c18eb3cffe2284eaf3243c4#diff-7e4043f05bbd8e76d2da4614c2566cfaR193

cond-> does not thread the test

@thheller: oops yeah thanks

om.next looks awesome so far, requires quite a bit of re-thinking of how to do things but that is good

@colin.yates: thanks

@thheller: thanks, I’m pretty excited about it

@steve: I tried your instructions and this is the output of my figwheel REPL: https://gist.github.com/bensu/a8901162387c3340fb8e

it seems to work, can you see if you did anything differently?

@steve please answer there and ping me when you are done

A patch from @tonsky that should tested by people who are interested in this fix http://dev.clojure.org/jira/browse/CLJS-1458

mostly concerned about unintended breakage in attempt to match Clojure

another one that will affect Node.js users that could use testing http://dev.clojure.org/jira/browse/CLJS-1466

What’s the fastest way to have figwheel pic up a library I just installed instead the compiled one? It’s a library I’m modifying, so, the version number is not changing in each modification.

pupeno: if i'm not mistaken, it helps to add -SNAPSHOT to the version number

@steve: no problem, glad it worked out

@bensu I'd been reading through some of the clojurescript code to see how the tests were setup there

and saw them setup and working as expected, so I was definitely scratching my head.

@dnolen: I tried a simple

(in-ns 'my.namespace) (def a 3)

and it fails with Error: Assert failed: (ana/ast? sym)

@richiardiandrea: that link has nothing to do with ClojureScript in any official way

tracked it down to defmethod emit* :var-special

anything you see there doesn’t mean anything wrt. ClojureScript

yes

I just wanted to ask if it can be a problem worth reporting (sorry if not) 😄

there’s nothing to report

that link has nothing to do with ClojureScript beyond somebody (a nice person) put it on the internet

Anyone using auth.0 from cljs? How do you inject the client id into the js that runs on the client? The client id is not secret, but is different for different environments (e.g. uat, stage, prod etc) but ideally we'd like an identical build in each environment. I'm thinking of just putting the client ids into a little S3 resource and looking them up when the app initializes. Does this seem sane?

kk now I know, just wanted to be helpful in finding problems I noticed...I apologize about it

@richiardiandrea: if you happen to find problems like those in either Planck or Replete, I'd be happy to look into GitHub issues and see if they can be isolated as minimal repros against the upstream ClojureScript self-host implementation. For in-ns it turns out that bootstrapped REPLs implement that REPL special (not ClojureScript proper).

yes I notices in the source of

kanaka/cljs-bootstrap

can you achieve a fully in-browser repl in your opinion? I am trying to figure that out

for example here env/compiler is missing completely and I guess it is necessary for both cljs analyzer and compiler

@richiardiandrea: That's what http://clojurescript.net is, unless you are additionally thinking of require and load-file REPL specials. ClojureScript's cljs.js support affords REPL implementors lots of flexibility, though.

oh maybe I am missing a piece then

@richiardiandrea: interesting... http://clojurescript.net certainly analyzes and compiles using only the JavaScript engine in your browser. Turn off your network connection and see. :)

yes I know, I am trying to create my own version based on that work 😄

@richiardiandrea: Cool! I've been down that path, using Joel's stuff, but targeting non-browser environments. :) Let me know if you have questions.

well the in-ns stuff does not work and I am trying to understand why, basically it needs to avoind using the env/compiler stuff

it is easy, it is just a map containing ::namespaces

I see in planck is using

(defonce current-ns (atom 'cljs.user))

but I don't want to spam the channel, maybe I will PM you 😄

@richiardiandrea: it is probably simply that in-ns is only doing half: Setting the ns but not creating it.

@richiardiandrea: yep. Probably better.

is there a way to tell the closure compiler not to minify a function? I'm trying to use leaflet and setRadius worked in dev mode but not when I attempted to compile for production

I had other use cases where I just used aget and applied the function, but this doesn't seem to work... So I'm wondering if there's a way to hint or ...?

@sjol: leaflet has a externs in cljsjs right?

yes, and I have it installed

[cljsjs/leaflet "0.7.3-4"]

good! then you can add setRadius there and nobody will face this problem again

just not sure where it is in my project?

it's not. I'll walk you through the process

yes please!

first get a copy of cljsjs, git clone

then, go to leaflet's externs file, under packages/leaflet/resources/cljsjs/common/leaflet.ext.js

or https://github.com/cljsjs/packages/blob/master/leaflet/resources/cljsjs/common/leaflet.ext.js

see it

now, in your source code, identify what is the class of the object that has setRadius

circleMarker

ok, so we need to tell the compiler that circleMarker has the property setRadius set to a function.

ok, the default is a function right now

d3 has a similar construct and an almost verbatim externs: https://github.com/cljsjs/packages/blob/master/d3/resources/cljsjs/d3/common/d3.ext.js#L773

right, it is ok that it is a function, since classes end up being constructors to the externs.

"CircleMarker": function () {},
  "circleMarker": function () {},
  "CircleMarker": {
    "setRadius": function () {}
  },
  "circleMarker": {              
    "setRadius": function () {}
  },

does that seem right?

No. That is saying circleMaker is an object that has the setRadius set to a function

You want to say, circleMaker is a constructor, whose constructed instances will have a setRadius set to a function. see the difference?

yes

As you can see in the d3 externs, you need to add a leaflet.circleMaker.prototype = function() {} to tell it it's a constructor

in d3 it's d3.geo.circle.prototype = function () {};

not many constructors in that file

once you have that you can use d3's next line: https://github.com/cljsjs/packages/blob/master/d3/resources/cljsjs/d3/common/d3.ext.js#L774

which talks about the instances

something like leaflet.circleMaker.prototype = { "setRadius": function() {} }

this is very useful for me too thanks @bensu

@sjol No, you are right, that probably means that no instantiated objects will have their properties available under :advanced.

@richiardiandrea: yeah, I might write this up somewhere

(not tonight it's late)

L.circleMarker.prototype = function () {};
L.circleMarker.prototype = {
    "setRadius": function () {},
    "addTo": function () {}
};

exactly

great!

@richiardiandrea: that would explain a lot of woes I had!

ok!

ok, with that in you need to build the package so that your other project has access to it

what next?

in my jqconsole package I have done something different though

I want to write a function that steps through a function like chromes dev tool, where should I start?

https://github.com/cljsjs/packages/pull/256/files#diff-f2ad16814edc8b8360d57bf1cc3a0e7fR56

but I see the function when :advanced

@sjol ok, with that in you need to build the package so that your other project has access to it

do you have boot installed?

er no only lein

https://github.com/boot-clj/boot#install

cljsjs uses boot

downloaded and ran boot libs are retrieving

good, so now you need to build and install the leaflet project

how?

boot package build-jar

cd-ing to your sub-dir first

you mean in the leaflet one or packages?

cd leaflet but first remove your old package with rm -r ~/.m2/repositories/cljsjs/leaflet

so that you can then check if it's there

seems to be done

and the new version is under .m2/repositories/cljsjs/leaflet

OMG! Circles!!!

lol

Thank you @bensu!

I can't believe it worked on the first try

but this is only for my machine... how do I push?

well, good instructions!

hahaha, no sir, I've dealt with enough tutorial related issues to know that instructions are not enough

I'd first recommend you to add all the symbols related to circleMaker and the other classes you might use in the future. You understand the process now, but you'll probably forget in the future when you need rectMaker and need to do everything again.

well this time it worked, I'll open a PR for my changes

yeah.... and other small ones

it is usually 10 minutes to go through the API of the class and copy paste the symbols

and then PR

great!

I'll open the pr so I don't forget 😉

in case, these instructions don't work and you are in a hurry, you can always try with (let [m (goog.object/get o "setRadius")] (m radius)) which should protect you from symbol munging

is this correct? #?(:cljs (satisfies? IWithMeta x) :clj (instance? clojure.lang.IMeta x)

o being my object

right

Great!

@thosmos: it looks fine, minus one closing parens

@sjol: glad to help.