Fork me on GitHub
#clojure-dev
<
2015-06-18
>
jonas02:06:43

@alexmiller: I added some tests to http://dev.clojure.org/jira/browse/CLJ-1562. This is my first patch to Clojure so feedback welcome!

alexmiller02:06:25

Great! I will take a look tomorrow. Have you signed a contrib agreement?

athos03:06:09

Hi, can I ask a question?

athos03:06:30

(run! reduced (range)) returns 0, though the docstring says it “returns nil”. Is this the intended behavior?

jonas03:06:31

@athos not sure if it’s intended behaviour, but looking at the source it will return whatever (proc <last-value-in-coll>) returns. So for example (run! identity [1]) returns 1, not nil as the doc suggests

alexmiller11:06:29

jonas: I'd say the run! thing is definitely a simple bug, thx for the ticket.

mikethompson11:06:24

Do Clojure and ClojureScript have an official birthday? If not, it seems a serious shortcoming: http://fsharpforfunandprofit.com/posts/happy-fsharp-day/ Should I open a ticket? simple_smile

slipset12:06:19

@alexmiller: I'm sure it's been discussed and described before, but I haven't found it, so I'll ask again. How come Clojure isn't developed with git pull-requests (and git issues)

alexmiller12:06:04

It would be better if the patch retained a commit with Jonas's original contribution

alexmiller12:06:32

Rich prefers reviewing patches to pull requests

slipset12:06:49

Fair enough

alexmiller12:06:59

There were concerns at one point over whether a pr was a clear point of contribution but that was in the early days of pull requests and may be less of a concern now

slipset12:06:20

concerning the patch with tests, you'd like to have two commits in there? one for Jonas and one for me?

alexmiller12:06:50

That would be nice to retain his contribution

alexmiller12:06:07

Or two patches

alexmiller12:06:22

And re github issues, at the point where the decision was made, github issues were really basic. I'm still not sure they are up to the task although they have come a long way.

slipset12:06:58

I think you have quite a workflow going on in Jira, which might be difficult to duplicate in github issues, although I'm not an expert on the subject.

alexmiller12:06:45

I know lots of people don't like jira but I like it better than github issues for doing real tracking.

alexmiller12:06:00

Although I wish we were actually using the workflow features jira actually has

slipset12:06:39

In danger of committing internet-suicide, I'll admit to liking Jira simple_smile

slipset12:06:02

I just find working with pull-requests easier than submitting patches.

chris12:06:26

If I would like to contribute, what’s a good place to jump in? I’m looking at the jira right now and there are a lot of issues, are there any markers for easy or just documentation fixes?

slipset12:06:42

@chris: I do believe there is.

slipset12:06:45

There is some sort of low hanging fruit thingy as well. I'll see if I can find it...

slipset12:06:18

There is of course this you'll need to read:

slipset12:06:41

where I found this:

chris12:06:08

ok, awesome, thanks

slipset12:06:22

Not that many marked as newbie though...

chris12:06:39

I read the contributing guide, but apparently not closely enough

slipset12:06:40

It would be cool if this channel could be used to solicit help from the community.

slipset12:06:53

Both ensime and cider have tagged some of their issues with low hanging fruits.

slipset12:06:19

Which is kind of nice for people starting out

andrewhr12:06:44

I think the idea here is really to supplant the almost dead clojure-dev mailing list as a communication media

andrewhr12:06:15

about other projects, maybe it's better to stick to their official communication channels

andrewhr12:06:44

I would suggest, for example, to create a #cider-dev

andrewhr13:06:19

but #C0617A8PQ folks already use gitter to do that

slipset13:06:35

Oh, I wasn't talking about getting cider-stuff in here, I was suggesting that the issues in Clojure could be tagged in the same way, so that it'd be easier for people to start contributing.

slipset13:06:54

btw I think the #C0617A8PQ people are here on Clojurians already.

andrewhr13:06:01

@slipset: ooohhh got it. Yeah, I agree that this could be really nice! simple_smile

andrewhr13:06:05

there is a #C0617A8PQ, but AFAIK user centric. Development discussions are made on Gitter (at least the last time I checked it out)

andrewhr13:06:22

anyway, back to clojure-the-lang....

andrewhr13:06:53

I like the idea of tagging issues on Jira simple_smile what we need to do to be able of doing that?

andrewhr13:06:33

@alexmiller: do you are in favor of this issue tagging?

alexmiller13:06:25

I already do that with the newbie tag

alexmiller13:06:40

it's just hard to find issues that are a) suitable for newbies b) don't quickly gain patches

alexmiller13:06:02

cider questions do not go here - use #C0617A8PQ etc for that

alexmiller13:06:35

the idea of this room is also not to supplant the clojure-dev mailing list but to serve as an additional channel

andrewhr13:06:52

@alexmiller: supplant was a bit stronger of my part - the mailing list is still a good channel for long-form reasoning, like the last conditional reader stuff

alexmiller13:06:54

there are many people on the mailing list (like Rich) that are not here and that group is archived and searchable (whereas this one is less so). but sometimes live chat is useful. In the past that's happened on #C03S1KBA2 irc.

alexmiller13:06:48

I'm happy to use all of them

alexmiller13:06:11

another place to look for things useful to work on are Triaged tickets with no patch

alexmiller13:06:21

is a quick search for those

andrewhr13:06:33

nice filter @alexmiller, thanks!

alexmiller13:06:32

@slipset: re 1542, dunno thus left there for Rich to look at eventually