Fork me on GitHub
#cljs-dev
<
2022-01-25
>
dnolen13:01:33

landed :as-alias support - probably worth poking around at both in projects and w/ REPL interactions to verify that it matches expectations

borkdude13:01:59

@dnolen Works here:

$ clj -Sdeps '{:deps {org.clojure/clojurescript {:git/url "" :git/sha "b3670a6d4a32dce751958ce393a16cf2e6e9c805"}}}' -M -m cljs.main -re node
Checking out:  at b3670a6d4a32dce751958ce393a16cf2e6e9c805
ClojureScript 0.0.1276343656
cljs.user=> (require '[foo.bar :as-alias foo])
nil
cljs.user=> ::foo/bar
:foo.bar/bar

cljs 2
dnolen13:01:40

@quoll have you created a JIRA patch yet for the math stuff? is there anything blocking you from doing that? just the tests?

quoll14:01:35

Christmas blocked me. I need to return to it. Main changes needed are to rename the namespace and clean it up in whatever ways you want to see for inclusion. I think it's generally in good condition.

quoll14:01:01

It's currently a .cljc file and that should change

quoll14:01:40

I’ll see if I can get it done by tonight

dnolen14:01:26

@quoll no rush actually, just following up 🙂

dnolen14:01:45

was mostly asking to see if I can assist

dnolen15:01:36

@henryw374 hello - you had some reader literal PRs yes? was it just one?

dnolen16:01:30

@henryw374 one question is though is that you made a functional change according to the commit notes

dnolen16:01:58

that should be removed to avoid any unintended impact

henryw37416:01:11

@dnolen ok I will revert that bit

henryw37416:01:46

@dnolen new patch attached to the ticket

dnolen17:01:52

@henryw374 thanks, re-running tests w/ new patch

dnolen18:01:11

@henryw374 merged, thanks!