Fork me on GitHub
#cljs-dev
<
2019-02-11
>
Roman Liutikov13:02:26

having the same issue as @kommen

Roman Liutikov13:02:01

Don’t know, seems like a result of a combination of multiple different forms.

thheller13:02:44

seems odd that it doesn't complain about the and uses above

Roman Liutikov13:02:31

as said above, for me the warning pops up only when the file is changed as well, initial compilation doesn’t trigger anything

Roman Liutikov13:02:00

also prod build with figwheel-main went without errors

thheller13:02:30

yeah but in the snippet you posted and is used 3 times and only warns on the last one. that is weird since its all compiled in the same pass.

Roman Liutikov13:02:33

In that 3rd and I’ve wrapped one of the subexpressions with (not ...) and the error is gone now

mfikes13:02:38

Smells like it could be related to truthy-induced, as that and involves simple symbols and it may expand to a case that triggers something based on that. (I can't see how.) But if you can repro it by switching back to involving simple symbols, then seeing if https://github.com/bhauman/figwheel-core/pull/2 fixes it would be valuable.

👍 5
john13:02:11

2 fixed it for me

mfikes13:02:25

Cool. That's good news.

Roman Liutikov13:02:46

@mfikes tried it, the error is gone 🎉

dnolen13:02:25

@mfikes I think worth waiting a bit just to see what falls out of the latest

dnolen13:02:47

still hearing reports of small things here and there

mfikes13:02:11

With respect to version numbers? Yeah, I'm mostly just curious about the process of when the bump to 11 occurs.

dnolen13:02:30

in the past we did bump after Clojure was released

dnolen13:02:42

and we're more or less going to do that - but no rush