Clojurians
#cljs-dev
<
2018-06-21
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

kommen08:06:23

@dnolen it probably never worked, but I think I never came that far with slate. I’ll see if immutablejs would work on it’s own

kommen16:06:34

fwiw: the webpack example also just works without webpack

kommen16:06:39

{:main hello.core
 :output-to "out/main.js"
 :output-dir "out"
 :infer-externs true
 :npm-deps false
 :foreign-libs [{:file ""
                 :provides ["react"]
                 :global-exports {react React}}
                {:file ""
                 :provides ["react-dom"]
                 :global-exports {react-dom ReactDOM}}]}

kommen16:06:55

(I also tried their official cdn links from https://reactjs.org/docs/cdn-links.html but those are erroring out for some reason when retrieved https://github.com/unpkg/unpkg.com/issues/114)

dnolen16:06:03

@kommen right that’s to be expected :slightly_smiling_face:

dnolen16:06:11

foreign-libs is pretty flexible

kommen16:06:59

:ok_hand:

dnolen18:06:58

@henryw374 thanks I’ve lowered the priority on that one for now - you may find this one is a bit tricky

dnolen18:06:17

the main challenge here is that it needs to work under advanced compilation

dnolen18:06:25

I’m also thinking we should check for a dupe?

henryw37419:06:52

@dnolen cool thanks. I did search Jira for an existing issue but failed to find one

dnolen19:06:14

@henryw374 I let a comment on the issue, maybe goog.reflect can help?

metametadata22:06:24

Maybe I've found a bug:

(defrecord A [])
(def x (map->A {1 2}))
(def y (map->A x))
(= x y)
Produces false in CLJS but true in Clojure.

mfikes23:06:19

@metametadata I'd file a JIRA