Clojurians
#cljs-dev
<
2018-06-22
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen18:06:08

I’m planning on cutting a release today - mostly for the :infer-externs with-out-str issue

dnolen18:06:14

anything else pressing I should look at?

ambrosebs19:06:16

@dnolen FYI I rebased and tested a new patch for this https://dev.clojure.org/jira/browse/CLJS-2260

dnolen19:06:28

@ambrosebs thanks!

ambrosebs19:06:07

:slightly_smiling_face:

mkvlr19:06:32

@dnolen we ran into an issue with the upgrade from 1.10.238 to 1.10.312 breaking transit metadata decoding. We plan on, but haven’t been able to bisect this yet. Or can you think of a specific commit I should try?

dnolen19:06:56

@mkvlr I can take a look at that too

mkvlr19:06:27

let me see if I can quickly come up with a minimal test case

mkvlr19:06:59

strange, looks like I’m having trouble reproducing it

mkvlr19:06:11

the problem we’re seeing is just like described in https://github.com/cognitect/transit-cljs/issues/46 (btw might be good if you could release transit-cljs to include https://github.com/cognitect/transit-cljs/commit/b5a67e7dddda159931c832883fcb46818376bb19)

mkvlr19:06:00

but I think we need to dig deeper to reproduce this next week

mkvlr19:06:00

@kommen also tried to reproduce this:

mkvlr19:06:10

> Tried to bisect this in ClojureScript by switching the org.clojure/clojurescript in deps.edn :local/root to a local ClojureScript checkout, but then the problem doesn’t reproduce any more.

mkvlr19:06:13

> So, I guess it’s either a problem with the jar itself or some weirdness of tools.deps.

mkvlr20:06:57

so sorry for the noise, calling it a day here. We’ll open a ticket if we do manage to reproduce it next week.

dnolen20:06:08

@ambrosebs applying and testing

dnolen20:06:30

looks good, hopefully if there any issues will get picked up by Canary

mfikes20:06:42

I'll kick off Canary when ready

dnolen20:06:06

patch applied & pushed to master

mfikes20:06:16

Based on previous Canary runs, it should be complete 24 minutes from now.

dnolen20:06:28

@henryw374 re: CLJS-2589 - need a properly formatted patch - added a comment

henryw37420:06:27

Thanks. Done that now

dnolen20:06:44

@mfikes is it possible to restart?

dnolen20:06:51

I don’t think I’m going to do any other patches today

dnolen20:06:17

k 1.10.328 ready if Canary doesn’t say different

dnolen21:06:08

@kommen good catch fixed

dnolen21:06:15

1.10.329 then :slightly_smiling_face:

mfikes21:06:02

2nd Canary run progressing now; ETA 25 minutes or so

mfikes21:06:03

2nd Canary run successful

mfikes21:06:18

CI is passing on Linux and Windows for 1.10.329

dnolen22:06:31

building now