cljs-dev 2018-06-22 | Slack Archive

dnolen18:06:08

I’m planning on cutting a release today - mostly for the :infer-externs with-out-str issue

dnolen18:06:14

anything else pressing I should look at?

ambrosebs19:06:16

@dnolen FYI I rebased and tested a new patch for this https://dev.clojure.org/jira/browse/CLJS-2260

ambrosebs19:06:48

both commits pass the travis tests https://github.com/frenchy64/clojurescript/pull/12

dnolen19:06:28

@ambrosebs thanks!

ambrosebs19:06:07

🙂

mkvlr19:06:32

@dnolen we ran into an issue with the upgrade from 1.10.238 to 1.10.312 breaking transit metadata decoding. We plan on, but haven’t been able to bisect this yet. Or can you think of a specific commit I should try?

dnolen19:06:56

@mkvlr I can take a look at that too

mkvlr19:06:27

let me see if I can quickly come up with a minimal test case

mkvlr19:06:59

strange, looks like I’m having trouble reproducing it

mkvlr19:06:11

the problem we’re seeing is just like described in https://github.com/cognitect/transit-cljs/issues/46 (btw might be good if you could release transit-cljs to include https://github.com/cognitect/transit-cljs/commit/b5a67e7dddda159931c832883fcb46818376bb19)

mkvlr19:06:00

but I think we need to dig deeper to reproduce this next week

mkvlr19:06:00

@kommen also tried to reproduce this:

mkvlr19:06:10

> Tried to bisect this in ClojureScript by switching the org.clojure/clojurescript in deps.edn :local/root to a local ClojureScript checkout, but then the problem doesn’t reproduce any more.

mkvlr19:06:13

> So, I guess it’s either a problem with the jar itself or some weirdness of tools.deps.

mkvlr20:06:57

so sorry for the noise, calling it a day here. We’ll open a ticket if we do manage to reproduce it next week.

dnolen20:06:55

@mkvlr k!

dnolen20:06:08

@ambrosebs applying and testing

😁 4

dnolen20:06:30

looks good, hopefully if there any issues will get picked up by Canary

mfikes20:06:42