@bhauman yeah now that we have this the watcher support in REPLs seems backwards

oh well live and learn

I don't understand

oh the support that is built into the repl

yes

@mfikes whoa 🙂

I'm working on the REPL based exception that you get when you run that. I suspect it might be the result of the way I replace the script tag completely.

@mfikes @bhauman I added a div with id app to master, I think it makes what you’re trying to do simpler

Cool

I'm all for it

I’m lukewarm now on browser REPL working without the compile step, I just can’t see a way to make it work without being messy

the only way I could think to do it cleanly was to add an output-to when compiling the repl client js

and then serving an html that points at that

yes but adding :output-to is yucky, you never have to supply that to REPLs

hopefully we are talking about the same thing

internally we can’t really know what it means since it could be supplied by user

since it’s fine to use some opts in a file for repl + build if you like

https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/repl/browser.clj#L232

@bhauman yeah we can’t use that

it’ll lead to very weird stuff

the client JS has to be in a separate dir so it doesn’t interact

you can’t have the page load from there

because user might want to do stuff at the REPL

ohhhhhhhhhh

then do things go into a directory that’s not supposed to change

I finally get it

yeah, it’s just too messy to make this easy

I'm good with this

wait, so clj -m cljs.main -re browser -r

doesn't even work with an custom index.html

BTW thanks @dnolen making use of your app addition makes the exception goes away

@dnolen thanks for taking the time to work on this

I'll try to kick prepls tires this week

@dnolen On a positive note, your app addition made this work 🙂 https://twitter.com/mfikes/status/967929140430229505

Cool!

Also nevermind I think I have a sensible way to make compile-less browser REPL work

Nothing a little laziness can’t solve I guess https://github.com/clojure/clojurescript/commit/d8e33cd9826cfc6da70e79f8f6984ad8c5caa9bb

@bhauman you can start browser REPLs now w/o compiles

sweet

I’m going to just shell out to call open so you don’t even need to open a browser

Maybe only do that on macOS?

Or is there a portable way?

@mfikes well if it fails we just ignore, so it’s not a big deal

cool

applied to master- I don’t think it gets any easier than this 🙂

this is amazing 🙂

clj -m cljs.main -re browser -c chambered.core -r after adding your dep just worked, open browser with running example

@mfikes ^

Nice!!!

On Linux it would be xdg-open 😉

Nice cross-os summary https://www.dwheeler.com/essays/open-files-urls.html

Happy to take a patch that fixes this up cross-platform, gotta switch gears for a bit

I’ll take a stab; I have all the OSs available to test with https://dev.clojure.org/jira/browse/CLJS-2555

cool thanks

(clojure.java.browse/browse-url url)

@dnolen ^

@mfikes ^

Yes. I’m actually testing something close to that, but will switch to exactly that instead.

(.browse (Desktop/getDesktop) (URI. (str "http://" (:host repl-env) ":" (:port repl-env))))

Oh… interesting. So that namespace uses clojure.java.shell instead of the facility in Java. Well, I’ll just use the clojure.java.browse one, as it lets users re-bind *open-url-script*

Ahh, nice, clojure.java.browse even falls back to the Desktop stuff I was just trying. 🙂

Cool. I think it is good to go. It actually opened the browser on Windows as well but failed for an unrelated reason https://gist.github.com/mfikes/b2b137e3c491bf3aaf34eff6b03a686d (I’ll see if I can get a minimal repro for JIRA)

Nice I wasn’t aware of clojure.java.browse looks like the handiwork of Christophe Grand

patch attached

applied

Captured a minimal repro for the issue mentioned a couple of messages back https://dev.clojure.org/jira/browse/CLJS-2556

thanks, just tried your Bocko gist, this is super cool 🙂

Yeah, this git deps stuff, composing with all this other stuff is definitely new territory. We definitely were not able to sling around code like this previously.

this kind of stuff is exactly what we were hoping to enable - it’s a lot of fun seeing y’all use it :)

thoughts:

display an informative message inside the index.html app div

the browser repl *could* be the default repl, it starts faster than nashorn and is still the most used CLJS environment

add the clojurescript favicon <link rel="icon" href="https://clojurescript.org/images/cljs-logo-icon-32.png"> to the index.html

note to self: this is getting very close to bare bones figwheel, the client just needs to know what files to require on change

I suppose if you made the browser REPL the default, then people could still run non-browser tests if desired (by specifying -re nashorn for example)

exactly

using V8 (via Project Detroit) in the future as the default would also be very compelling (speed, for one)

Riffing on Bruce's idea of an informative message, for the "compileless" browser REPL, we could slap a logo in there with a little extra code.

(server/send-and-close conn 200
            (str "document.write('<script>document.body.setAttribute(\"bgcolor\", \"#000000\");</script>');\n"
                 "document.write('<script>document.getElementById(\"app\").innerHTML = \"<canvas id=canvas width=1000 height=1000></canvas>\";</script>');\n"
                 "document.write('<script>ctx = document.getElementById(\"canvas\").getContext(\"2d\");</script>'); ctx.lineWidth = 12;\n"
                 "document.write('<script>ctx.fillStyle = \"#FFFFFF\"; ctx.beginPath(); ctx.arc(300, 150, 100, 0, 2 * Math.PI); ctx.fill();</script>');\n"
                 "document.write('<script>ctx.strokeStyle = \"#96CA4B\"; ctx.beginPath(); ctx.arc(300, 150, 86, 1.57, 4.71); ctx.stroke();</script>');\n"
                 "document.write('<script>ctx.strokeStyle = \"#5F7FBF\"; ctx.beginPath(); ctx.arc(300, 150, 86, 4.71, 1.57); ctx.stroke();</script>');\n"
                 "document.write('<script>ctx.fillRect(294, 55, 12, 190);</script>');\n"
                 "document.write('<script src=\"out/goog/base.js\"></script>');\n"
                 "document.write('<script src=\"out/goog/deps.js\"></script>');\n"
                 "document.write('<script src=\"out/cljs_deps.js\"></script>');\n"
                 "document.write('<script>goog.require(\"clojure.browser.repl.preload\");</script>');\n")
            "text/javascript"
            "UTF-8")

(That's produced by the 7 extra lines inserted above the normal code to load the Closure stuff and the browser REPL preload code.)

@mfikes while it’s nice to use some Canvas, we could probably just drop the logo there 🙂 I think there’s one in SVG floating around right?

Yes, the real one is at https://github.com/cljs/logo

Having browser REPL be the default is a good idea

I'll put together a patch that uses the real logo—we can then decide if we actually want it in the end.

https://dev.clojure.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+CLJS+AND+resolution+%3D+Unresolved+AND+priority+%3D+Critical+ORDER+BY+key+DESC&mode=hide

I added these as issues

Oh yeah we can also AOT compile the browser REPL client JS file - https://dev.clojure.org/jira/browse/CLJS-2561

@mfikes probably easier to just use an image tag that references a hosted image

Yeah

also in terms of the contents of the message

I might be nice to mention that the provided index.html is overridable

I don’t see a reason to not prefer SVG in this case, it can scale

and that it is provided by the browser repl

@bhauman no opinons on the copy, got any suggestions?

I don't know if I have access to see the images list in the clojurescript site. That png is https://clojurescript.org/images/cljs-logo-icon-256.png

a hosted svg would work

@dnolen I will work on some copy

@mfikes honestly I would just get the SVG from that repo and copy it into the ClojureScript JAR - we can serve it locally, ditto for the favicon

OK

Thinking about how this might work if ClojureScript is a git dep... perhaps it can be a resource...

Ill give it a shot to see if I can get it to work

@mfikes yes a resource

I can manage the build / deploy side, just put things in the right place for now and tweak the server

OK

@bhauman @mfikes thanks!

@dnolen ^

something along those lines

needs some tweaks

but I have to go

Thanks. I'll try incorporating that copy into the same patch used for the logo

Thanks @mfikes!!!

BTW mfikes if you can't get the resource you can fall back to the hosted images

now I really have to go

I didn't worry too much about styling, but the patch for the logo and copy is now attached. It looks like the following

Nice, I can tweak the styles, I might just copy a few things from the site

There is a vexing bug where the logo doesn't appear the first time you start it up. Maybe the solution will come to us if we ponder it a bit.

huh, I can take a look at that too

Yeah, it is strange. The logo is indeed copied and if you get the image address from your browser and then open it in another browser it works. I've tried adding a sleep after the code that copies the files to try to avoid any such race, but that doesn't do it either. Hrm.

It also works if you refresh your browser.

@mfikes I cleaned up the svg / png handling a bit, I don’t think there should be races now - I just avoid the filesystem

Nice! That better

with very basic styling, that’s all I’m planning on doing for now

Looks great!

clj -m cljs.main -r

Confirmed that the race is gone now. 🙂

Stupid slow filesystem 🙂

this is pretty slick 🙂

I'm updating the chambered and bocko-canvas demos to ensure they work with this latest stuff.

@potetm can we get a rebased patch for this https://dev.clojure.org/jira/browse/CLJS-2167? Sorry for the long delay but now’s a good time to spruce up Browser REPL 🙂

also https://dev.clojure.org/jira/browse/CLJS-2168?focusedCommentId=48330#comment-48330

I’m fine w/ disabling :optimizations that’s only for the client JS there’ no reason for the user to control that

in fact we’re going to AOT it so we won’t even bother

I updated your JIRA privileges

@dnolen for sure! hopefully can get to it this afternoon; tomorrow morning at the lastest.

@potetm no rush, thanks much

@dnolen @mfikes awesome!

I'm looking at the patch now

@dnolen can we move the style into the app div?

that way, when it gets overridden, its gone

That would be nice. (If you do that, can you style the whole body from within the app div?)

no but you can make the app div the size of body

well actually it would be a div inside the app div

@bhauman I don’t know what you mean by overriden?

if you mount app the contents are removed

There’s one more thing about the browser repl that’s on my todo list, I’m curious if someone already got to it: I think I know why the browser “misses” sometimes. IIRC The child-parent connection just uses a setTimeout before establishing a connection. There’s a pattern for send/ack outlined in Closure: The Definitive Guide that might fix that issue.

and you can go to town with your react app without having to override default styles

you would have to remove default margin on body

An consequence of what @bhauman is referring to is that chambered looks like the following

yeah this is fixable

All chambered is doing is

(set! (.-innerHTML (.getElementById js/document "app"))
      "<canvas id=\"game\" width=\"424\" height=\"240\"></canvas>")

@mfikes actually if you move the style tag inside the app that should work for you I think

@bhauman done

sweet

@potetm that would be sweet to fix that

@dnolen Cool. I’m hopping on a plane this evening. I should have some time to take a look at it while I travel.

Sweet. chambered is updated and it behaves properly (you see the expected brief flash of the default page, which gets replaced). chambered no longer requires -re browser as well, so simpler to start:

clj -Sdeps '{:deps {github-mfikes/chambered {:git/url "" :sha "3cbb5fef025ac5da39098e06429043216a6e97b9"}}}' -m cljs.main -c chambered.core -r

hubba hubba

@mfikes I don't know about shutting down the agents

Oh, wait, I guess you need an explicitly add -re browser to have it automatically start the browser.

Right, that's a bad patch if the JVM is still running something else.

yeah, you could do it at the end of main

Ahh, OK. Will try that instead.

Is the intent with the default REPL being browser that you don't need to specify -re browser? (Thinking about the fact that we lose auto-browser behavior.)

@mfikes yes

hmmm we shouldn't loose the default index html in that case

Working on the shutdown-agents issue https://dev.clojure.org/jira/browse/CLJS-2562

trying out the new stuff

See if omitting -re browser make it so the browser doesn't open localhost:9000 for you

you got it

@mfikes it works over here, but not if you have multiple one’s running because the address won’t bind

that’s why I prioritized tim’s ticket - to fix that

OK, yeah, my box might be in a bad state.

I'll log out and back in to be sure...

@mfikes works here 🙂

I was initially in a directory that had a deps file in it, and it launched a nashorn repl, so that was confusing

Well, clj -m cljs.main in the ClojureScript directory starts the browser. but in the chambered example, copied here:

clj -Sdeps '{:deps {github-mfikes/chambered {:git/url "" :sha "3cbb5fef025ac5da39098e06429043216a6e97b9"}}}' -m cljs.main -c chambered.core -r

it launched the browser for me

I used that exact command

I just did it again and it worked

@mfikes is that a deps problem?

Sorted: I had a local deps.edn overriding my ClojureScript dep and not taking the one from from the project

that's what happened to me

Makes sense

I need to learn what a "top" dep is and get this straight in my head

While we are on the issue of the server, now that CORS is a well supported thing. We could have a simpler repl connection that is supported by simple HTTP polling. No mess no fuss. No iframes, and very robust connection.

It would work everywhere all the time.

multiple connections would not cause race conditions

I’d be for that

though it’s a bit bigger than tweaking initialization

depending on when we’re looking to carve a release, I might be up for making the init tweak then swinging back around with a full rewrite

open to that, but not for the next release

heh AOT caching client makes bREPL much, much faster to start 🙂

but does it connect?

client js doesn’t hard code hort/port

Moving (shutdown-agents) to the end of cljs.main/-main fixes things, while not messing with js/setTimeout calls in flight, but seems like something else might go wrong. Anyway here is the potential patch for https://dev.clojure.org/jira/browse/CLJS-2562 https://github.com/mfikes/clojurescript/commit/a02bf1150fc069723ccd094a5151e2e91f2f3f1d

looks ok to me

give master a try by building, then bumping your deps.edn adding :classifier "aot"

Feels like the only way to find out is to try it for a while

cljs -m cljs.main -r is very quick

well these improvements are exciting, I can't pull myself away, I'm more rapt by this than by the Olympics

of course the Olympics are over so that helps

Wow, java -jar cljs.jar hauls ass

I wonder @dnolen, Safari seems to exhibit that behavior where it needs a refresh to work, when it is populating a fresh out directory—perhaps it is similar to the thing you just fixed with the png and svg, but for the script files being written to the filesystem and a race with Safari occuring.

hrm I can’t repro that here on this machine

It seems pretty deterministic for me. java -jar cljs.jar fails if out is not there, but it works if it is already there

perhaps we need the fix that @potetm is talking about

@mfikes just deleted out, it works via clj

trying the uberjar now

I will say - the uberjar is not long for this world

since clj is way better all around

Hah. I'm hoping for a cljs variant of clj some day 🙂

@mfikes uberjar worked for me too, no refresh

oops

not true one second

Hmm. Perhaps you have a faster filesystem.

inconsistent behavior here

so I think we just need to harden the browser REPL logic on the client

but this is really cool 🙂

like 1-2 seconds to get a REPL

Yeah. It really feels like some of the (valid) complaints that people have might be addressed by this release.

and not to mention (cljs.repl/repl (cljs.repl.browser/repl-env)) works fantasticly

but the chambered example failed to connect the repl every time, even after I killed the browser

I think chambered is a problem child in that it goes into a tight loop.

The bocko stuff connects on the other hand

yeah that makes sense

Ah hah! Here is what the Safari JavaScript console shows if you start up without a populated "out"

@bhauman chambered connects the 2nd time you execute that command. In other words, when you have a populated "out"

not for me 🙂

the tight loop must bog it down

FWIW, Bocko stuff updated and works fine with latest :sha (https://gist.github.com/mfikes/e00202b2de7cc2352fedcf92b1fe60dc)

yeah chambered goes into a loop and gives little control to the browser, so not a great example of REPL integration

@dnolen To save you some time in case you encounter it: jbake (the tool for clojurescript site) doesn't seem to work with Java 9; it is fine with Java 8. If you use Java 9 the failure will look like

$ jbake
JBake v2.5.0-SNAPSHOT (2015-11-04 14:58:30PM) []

An unexpected error occurred: null

k cool thanks

@mfikes I think I fixed https://dev.clojure.org/jira/browse/CLJS-2556 on master

Cool. Will give it a try

Drafted this reference page 🙂

😀

y'all.... this is ridiculously awesome!

@dnolen @mfikes @bhauman thank you so much for bringing all this together!

I'm getting spec errors about cljs.source-map.base64-vlq though

Was an issue with a dep, nevermind

Hello folks, is this correct with the new REPL namespaces? because it throws for me. I can open an issue of course, just wanted to be sure

clojure -J-Dclojure.server.repl='{:port 5044 :accept cljs.server.node/repl}' -A:cljs-canary 

that's not supposed to work yet

you need a repl-env

nope I'm wrong

trying the -re thing now

thats new functionality

@richiardiandrea throws how?

I hadn't seen it yet

ok

a sec, pasting to a file

I connect to it with nc localhost 5555

@richiardiandrea you need Clojure 1.10.0-alpha4

oh, gotcha thanks!

It works! Not for now now, but it would be awesome if a -o would accept a path to an already present cljsc_opts.edn file containing compiler options

or a way to use my own compiler options for the repl ... it does not seem to see my npm deps

@richiardiandrea it’s really not possible to get that much configuration out of this

make your own repl accept fn that does the configuration you want

what’s there is just the basics so people can experiment with pREPL integrations

I added -rf and -cf for setting config for REPLs & build directly via EDN string

check master, if you have better flag names I’m listening

ok lemme try that

@dnolen is -cf on master now? the last commit I see is allow setting browser host/post via cljs.main

dang!!

good stuff

yep having options from the command line is awesome, as I was saying earlier, having deps.edn plues cljsc_opts.edn in the project is definitely cool...plus I have a serverless-lumo.edn for lumo...each conf file is decoupled from the other

thank you folks for the work you put in last week/weekend, I was reading along 😄

@bhauman I just added minimal error handling, it should make the more cryptic cases more clear

nearly all the bad stuff is from falling into the main case, so we check everything there now

@dnolen great! my common problem was just adding -w without a path

I'll attempt to keep the content in the cljs.main reference PR up to date between now and release https://github.com/clojure/clojurescript-site/pull/173

@bhauman k added checking for -w

@potetm I went ahead and fixed the bind address case, it needed a couple of tweaks anyway

ok well, -cf seems not to complain but the the require of something from :npm-deps is not working yet...anyways thanks that is what I was hoping for, will try to dig when I have more time