freaking Jira. I just spent a half an hour composing a thoughtful ticket for the browser-repl supplying a index.html and Jira completely ate it due to session time out.

https://dev.clojure.org/jira/browse/CLJS-2553

a less elegantly phrased ticket

@bronsa you need a :excludes for read+string I think

yes

sorry was not testing on 1.10 yet

releasing alpha2

thanks

@bronsa I note the behavior of tools reader is different from Clojure

for read+string, with tools.reader I get the newlines, with Clojure I do not

ah?

oh I hadn't noticed clojure trimmed the output

yeah

@bronsa happy to test via deps.edn to make sure everything looking alright before you cut another release

thanks

I just pushed a fix for that

k testing

3cb5f68

@bronsa I think you introduced a bug somewhere, I get empty strings now

@bronsa 0618158132cc8a997143d73395dceeb1bdfeb833 gives me empty strings

f87e8db5dea5b1ebbe3e628a4de660d067ae1082 does not

try now

sorry haven't had much time to test this

@bronsa that works yes

@bhauman I left a comment on CLJS-2553, I think we should just emit index.html if not present - I don’t think we need to overthink this, browser REPL looks for index.html in the current directory - we should just do that - means fewer changes

gotcha

@bronsa there’s also a bug here in Clojure that you copied

if arg count is 1 you have to unpack and reverse order to call read

otherwise there’s no way for me to invoke arity 2 with the read cond stuff

gah, the arity is reversed

ok thanks

is there already a ticket for clojure?

no

give current master a try

@bronsa everything appears to be working now

cool

will cut alpha3

thanks for trying it out

thanks

I’m sure someone has mentioned this before, but this works clj -J-Dclojure.server.repl="{:port 5555 :accept cljs.repl.node/-main}"

and that should work for the prepl as well

yep

clj -J-Dclojure.server.repl="{:port 5555 :accept cljs.core.server/io-prepl}"

so the browser repl looks for the index.html in the :static-dir's which are overridable

you are saying just gen the html to "." regardless

which seems fine

yeah

@bhauman we do need a flag to disable the generated file, but it should default to true

again this makes me think serving it may be a simpler solution

hrm, but then the user has to know what will go in there if they need to provide their own …

The tradeoff seems thin for a 3 line html file. That everyone has to learn to write anyway. Serving it will work no matter what the config is, and adding a flag to prevent an unwanted index.html seems not the best

a flag to generate it is interesting ...

but that doesn't help the original problem

Looking over the prepl stuff, I think self hosted environments can choose to implement their own version of cljs.core.server/io-prepl (which involves self-hosted eval) and those supporting Socket REPL can allow users to hook into prepl via :accept. Perhaps an interesting consequence of all of this is that cljs.core/tap> and related fns, are really there for self-hosted environments, unless I'm thinking about this incorrectly.

They are there for both environments as far as I know.

Ahh... I can't yet see how the cljs.core/tap> works for non-self-hosted.

the repl implementation has to forward the message back

Ahh. OK.

and then call tap> on the "server" side

@bhauman yeah ok, let’s go with serving

darn I really have to play with it a bit

@dnolen good to hear

@mfikes well REPLs can call add-tap on the client side of their integration, so not just for self-hosted

OK. I'll read more code and see how it all hooks together 🙂

When I do

clj -J-Dclojure.server.repl="{:port 5555 :accept cljs.core.server/io-prepl}"

Unable to resolve symbol: PrintWriter-on in this context

that's clojure 1.10

Ahh thank you

and we can’t actually invoke io-prepl directly like that at the moment

OK

need to supply repl-env

OK, I'll use https://clojurians.slack.com/files/U050B88UR/F9DNQT4TB/-.clj as a model for now

(I suppose I can also just use Clojure 1.10 as a model as well.)

Like this

$ java -Dclojure.server.repl="{:port 5555 :accept clojure.core.server/io-prepl}" -jar clojure.jar

I updated master to make this easier

clj -J-Dclojure.server.repl="{:port 5555 :accept cljs.server.node/prepl}"

@mfikes ^

Cool. Thanks!

oh dang serving the browser repl index.html is a sweet experience

This will be good for Quick Start 🙂

hell yeah

IMHO, Quick Start today has the potential to turn away people who are not patient enough to make it through it. With this new stuff, devs who want instant gratification will be happy.

yep

but also it’s making it easier for everyone

Definitely true. Even for experts. 🙂

when you just want to try something quick, the new stuff makes it a lot easier

For example, I think I spent 10 to 15 minutes figuring out index.html. Life it too short for that.

@dnolen @mfikes should we add an <div id="app"></div>

?

I have no clue

I don’t think so, we’re just doing this so you get something if you don’t provide index.html

I agree

Did you find that you needed to make src match -o's value? (Curious.)

yeah just made it output-to

making the patch now

Cool. I suppose -o / --output-to is required for browser REPL (dunno)

(If it defaults to "out/main.js" or somesuch, even easier.)

hrm I haven’t use -o with browser REPL

"out/main.js" is the default

Cool. So Bruce's patch will honor -o if the user specifies it.

Patch sent https://dev.clojure.org/jira/browse/CLJS-2553

it requires :main and :output-to to be in the compiler options

my god what an improvement

testing it now

So am I 🙂

clj -m cljs.main -re browser -c example.core -r

was how I was using it

works

fun eh?

Cool. It doesn't even write to the filesystem

too bad I can't do clj -m cljs.main -re browser -r

Yeah, you need to compile something... hrm

I'm requiring a main to be present

@bhauman I don’t think main has to present

so that its a boostrap script

you always get a bootstrap script

unless target :none

oh yeah yeah

@bhauman so clj -m cljs.main -re browser -r

will try

could work now if you remove the need for :main

k will wait then, otherwise patch looks good

Everything is working for me. (It honors -o, leaves index.html there if it exists.)

:local/root deps rock (I just applied the patch and ran things without even building ClojureScript)

(from another project - Coal Mine)

so the default :optimizations is :simple ?

@bhauman only for the client script

(which goes in the iframe)

default optimizations is always :none

@mfikes nice

Safari is still doing that thing where you sometimes need to refresh your http://localhost:9000 page (but this is not a regression, this seems to have always been the case)

yeah

this is taking a bit longer than expected

@bhauman so dropping :main requirement creates some other problem?

yeah for clj -m cljs.main -re browser -r there is no output-to

in the compiler options

which leaves the generated script in the repl under its hash EF9FE3E.js

and so I'd have to require goog.base

ah right

the problem is this is -r but without -c

so that’s a different code path in cljs.cli

even with -o set it won't work

I think the original patch is the way to go

unless you want to pull from the .repl dir

this is not a limitation of what we have but how we manage the commands in cljs.cli

which is possible but I'd need a name for the script

I hear ya

@bhauman just drop the main bit from the patch, I think I know how to make this work

cool

will do

I have to say I think maybe adding an output-to to the client.js compile and then pulling the output-to from .repl dir might be a good solution because it doesn't couple the browser repl behavior to cljs.main

I don’t think is problem though

browser REPL is different from other REPLs - you need to generate bootstrap file

oh hrm …

yeah, it’s a fundamentally different case

… but browser REPL server could serve out/main.js if it doesn’t exist same as index.html

yeah

nothing needs to be in there except loading goog.base & the deps files

yep

that’s what we should do - then no change to anything else

so are you taking this over?

that'd be fine by me

I can do that bit sure

you still want me to update the patch?

nah

I think with what you are doing you don't even need to require output-to

coolio

An extremely nice consequence of the synthetic generation of index.html is that the code being compiled can now be a git dep. (This did not work previously because, even if you had an index.html in the git repo, it wouldn't be in the working directory. Now that it is synthetically created, things just work.)

now back to documenting rebel

@mfikes by the way I don't know if you tried running rebel-readline.main and then launched a rebel-readline.cljs.repl/repl from inside it

its' pretty sweet

nesting works perfectly

No, but I plan to mess with it some more 🙂

I'd like to make a "one line git dep" demo of this synthetic index.html generation. I don't know web tech enough to know if I can dynamically add a canvas element so that I cal slap the CLJS logo into the browser (using the bit of code at the bottom of http://blog.fikesfarm.com/posts/2017-04-29-clojurescript-ejecta.html)

sure you can

but you can just request an image?

I'm thinking you run clj -Sdeps ...` and then go to localhost 9000 in your browser and see something cool

yeah you can just append an image element to body

that points to one of the currently hosted logos

https://stackoverflow.com/questions/15741006/adding-div-element-to-body-or-document-in-javascript

Cool. I might try that. A browser-based version of something like https://twitter.com/mfikes/status/967038906893045760 to get more people interested in cljs.main and git deps, etc.

the first answer to that question should do it

Actually if it started playing Flappy Bird via Figwheel automatically. 🙂

I'll try a simple CLJS logo demo for now. 🙂

well that's possible

if you need me to commit a deps to the repo let me know

but no figwheel not yet

oh darn I didn't try the watcher yet

man there is very little in the way of args checking a simple check that prints a message non existence of needed paths would do wonders

watching with the repl attached is dang cool as well

the shared compiler env makes it sweet

define a new fn in your source, reload the browser, and call it from the repl, with no compile warning

Oh that's cool indeed as does it work in node as well?

Here is a cool demo of synthetic index.html (David will recognize it):

clj -Sdeps '{:deps {github-mfikes/chambered {:git/url "" :sha "7a04b48900041b6aefa8dbed6079d18952db5ee5"}}}' -m cljs.main -re browser -c chambered.core -r