Clojurians
#cljs-dev
<
2017-12-01
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen21:12:25

@levitanong have you submitted your CA? I don’t see on the list for some reason

dnolen21:12:34

@mfikes your patches are applied

mfikes21:12:42

:slightly_smiling_face:

levitanong21:12:35

@dnolen I have. :open_mouth: Perhaps i could forward you the email?

dnolen21:12:00

sure but why aren’t on the http://clojure.org contributors list? or did I miss it?

levitanong21:12:48

is the appearance on that list automatic?

levitanong21:12:52

@dnolen email forwarded

dnolen21:12:56

looks good, double checking with @alexmiller

dnolen21:12:53

ok checked out, will apply your :output-wrapper patch, if you’d like to submit a corresponding PR to the website that would be nice

levitanong21:12:25

Awesome! thanks! Re: PR, do you mean to add my name?

dnolen21:12:40

no update the :output-wrapper documentation :slightly_smiling_face:

levitanong21:12:48

oh right. LOL will do!

dnolen21:12:27

submit a PR for it, it will get merged in when we release

dnolen21:12:36

thanks much

dnolen21:12:02

@mfikes 2414 needs a rebase

dnolen21:12:30

@levitanong applied and pushed

levitanong21:12:42

@dnolen Awesome! I feel like such a grownup

alexmiller21:12:42

@levitanong we update the contributors list in batch, every couple weeks

dnolen21:12:01

@levitanong :slightly_smiling_face:

dnolen21:12:53

@mfikes I don’t really see a problem with CLJS-2387, can always revisit that later - it’s a simple patch

dnolen21:12:59

I’m applying 2405 now

levitanong21:12:33

@dnolen made the documentation PR

levitanong21:12:07

my pleasure!

dnolen22:12:09

done going through patches for the day, but if anyone wants to suggest some for me to look at over the weekend when I have some time - please do!

mfikes22:12:58

Need to head out, but this one might be easy to rectify: https://dev.clojure.org/jira/browse/CLJS-2426

mfikes22:12:30

^ (fresh builds are dead in the water; script/bootstrap fails)