FWIW I think CLJS-2288 is still wrong

I’m setting up Windows CI and I think I can provide fixes to all things windows that supersede those in the tickets

diff here https://github.com/clojure/clojurescript/compare/master...anmonteiro:appveyor?expand=1

(including relative-name, which is now well tested in both Windows / non-Windows)

^ actually attached what I have to https://dev.clojure.org/jira/browse/CLJS-2291

so that people can use in their own forks (cc @mfikes ) and make it better

there are like 5 failures in lein test and 3 failures in script/test

I got that down from 20 in lein test 🙂

Good stuff

A question, is there a way to access the current cljs.env/*compiler* from a cljs REPL ? I was working on supporting cljs completions in inf-clojure

no since it doesn’t exist in CLJS

you’d either need a macro or a special form for that

@anmonteiro nice!

@thheller thanks! Right a macro would not work I guess for completions if I end up in a vanilla cljs repl. There is a server starting there so maybe I can use that? How do you solve it in shadow-cljs?

do it from the CLJ repl

But the vanilla Repl drops you in a cljs repl immediately

thats why you open a second connection for tool stuff

Are we talking present repls or future repls?

You could also multiplex

(sorry off topic here)

weird because when I try to nc localhost port-of-a-vanilla-repl I receive a single ready as answer, how do you folks use it?

Maybe found a problem, I have this node_repl.clj:

(require 'cljs.repl)
(require 'cljs.build.api)
(require 'cljs.repl.node)

(cljs.build.api/build "src" {:main "logpoc.core"
                             :target :nodejs
                             :output-to "out/logpoc.js"
                             :verbose true})

(cljs.repl/repl (cljs.repl.node/repl-env)
  :watch "src"
  :output-dir "out")

$ cat out/watch.log 
Building ...
java.lang.AssertionError: Assert failed: :nodejs target with :none optimizations requires a :main entry
(not (and (= target :nodejs) (= optimizations :none) (not (contains? opts :main))))
	at cljs.closure$check_node_target.invokeStatic(closure.clj:1954)
	at cljs.closure$check_node_target.invoke(closure.clj:1951)
	at cljs.closure$build.invokeStatic(closure.clj:2475)
	at cljs.closure$build.invoke(closure.clj:2444)
	at cljs.closure$watch$buildf__6992.invoke(closure.clj:2647)
	at cljs.closure$watch.invokeStatic(closure.clj:2679)
	at cljs.closure$watch.invoke(closure.clj:2623)
	at cljs.repl$repl_STAR_$fn__7543$fn__7548.invoke(repl.cljc:902)
	at clojure.core$binding_conveyor_fn$fn__4676.invoke(core.clj:1938)
	at clojure.lang.AFn.run(AFn.java:22)
	at java.lang.Thread.run(Thread.java:748)

Watching paths: /home/arichiardi/git/logpoc/src

Hmm, check-source-map will give error if :source-map true is provided but no :optimizations https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L1886

There are a few other check-* functions that seem to presume :optimizations is always set, but most of them are being called with the original opts, not opts with implicit opts added

Maybe mine above is the same problem actually, I don't have any :optimizations

https://github.com/clojure/clojurescript/commit/79509651e16bf2b2fdc60a39de8671ef96206055 looks like check-preloads was fixed a while ago

I added the option to my node_repl.clj but no luck

@anmonteiro https://github.com/google/closure-compiler/pull/2596

There are two test cases which use :target :nodejs, without :optimizations and no :main, which breaks assertion at check-node-targets

uhm so mies does not have the build step as per the Getting Started for the repl

ok repository attached, I am going to wait before opening a ticket cause maybe it is expected: https://github.com/arichiardi/node-repl-main-error

@juhoteperi going to try Closure master + that patch with our tests

^ fixes it

@anmonteiro What did you use to run Closure tests? mvn, Idea?

@juhoteperi mvn -pl pom-main-unshaded.xml test -Dtest=RewriteJsonToModuleTest

that’ll run only 1 test

I tried using -Dtest yesterday but it didn't run anything

you probably need to add the pom-main

what does that -pl pom-main-unshaded.xml part do? I didn't use that

it makes maven aware of that pom

otherwise I think it only picks up pom.xml

Okay.

-pl,--projects <arg>                   Comma-delimited list of specified
                                        reactor projects to build instead
                                        of all projects. A project can be
                                        specified by [groupId]:artifactId
                                        or by its relative path

I'll have a quick look at those UMD wrappers

nice

@juhoteperi I started looking at the package.json browser field but got sidetracked with the Windows CI stuff yesterday

@juhoteperi https://github.com/google/closure-compiler/commit/afecc106ff2b7682cd3cb35c8c4b4f50d032552b

it’s a commit 🎉

might be in the next release, I don’t think they have cut a branch yet

I made some very small progress with wrappers, one problem was that if Immediately-invoked function expression was wrapped with ! it wasn't removed

But there are other probems, like function foo () { return 'export' }; module.exports = foo(); which are more complicated to fix

or function foo(exports) { exports.foo = 'hello'; }; foo(module.exports);

Got the ternary UMD wrapper working with Leaflet

https://github.com/google/closure-compiler/pull/2597

👍

Some wrapper could have code like this 😄

void !!-+-+!~! void !~!!~~~~!! function() { console.log("hello world") }()

But I hope no real library does that

hahaha

1 && function () { /* ... */ }();
0, function () { /* ... */ }();

probably these are not used as they take more chars than parenthesis or one of those operators

I started a Cljsjs wiki page to document which packages work with module processing, and to track the problems: https://github.com/cljsjs/packages/wiki/Closure-npm-Module-processing-status